February 2023 - Koha-bugs - lists.koha-community.org

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bibliwho(a)gmail.com | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #129 from Magnus Enger <magnus(a)libriotech.no> --- This made the sign display in the main table: diff --git a/tools/signs.pl b/tools/signs.pl index e243b59b97..5b317925d0 100755 --- a/tools/signs.pl +++ b/tools/signs.pl @@ -302,12 +302,12 @@ if ( $op eq 'add_stream' ) { } else { - my @streams = Koha::SignStreams->search(); - my @signs = Koha::Signs->search(); + my $streams = Koha::SignStreams->search(); + my $signs = Koha::Signs->search(); $template->param( - streams => \@streams, - signs => \@signs, + streams => $streams, + signs => $signs, -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #128 from Magnus Enger <magnus(a)libriotech.no> --- Great to see this is being kept alive after so many years! :-) I had the same initial error as David and Solene. I was able to make it go away by doing this: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt index 931079996c..f8b57c0db7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt @@ -373,7 +373,7 @@ </tr> </thead> <tbody> - [% FOREACH s IN signs %] + [% FOREACH s IN signs.next %] <tr> <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_sign&sign_id=[% s.sign_id | uri %]">[% s.name | html %]</a></td> <td>[% IF ( s.webapp ) %]Yes[% ELSE %]No[% END %]</td> @@ -413,7 +413,7 @@ </tr> </thead> <tbody> - [% FOREACH s IN streams %] + [% FOREACH s IN streams.next %] <tr> <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_stream&sign_stream_id=[% s.sign_stream_id | uri %]">[% s.name | html %]</a></td> <td title="ID: [% s.saved_sql_id | html %]">[% s.saved_sql.report_name | html %]</td> But I have problems getting the one sign I added to display, so that change might be just nonsense. I was also getting a JS error when viewing the table of signs. It seems to be am invalid value for sPaginationType, so this made the error go away: @@ -451,13 +451,13 @@ "aoColumnDefs": [ { "aTargets": [ -1 ], "bSearchable": false, "bSortable": false }, ], - "sPaginationType": "four_button" + "sPaginationType": "full" })); $("#table_streams").dataTable($.extend(true, {}, dataTablesDefaults, { "aoColumnDefs": [ { "aTargets": [ -1 ], "bSearchable": false, "bSortable": false }, ], - "sPaginationType": "four_button" + "sPaginationType": "full" })); Not sure if "full" is the pagination we want, though. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 32880] New: Show library's name instead of branchcode in dialog when overwriting an existing notice
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32880 Bug ID: 32880 Summary: Show library's name instead of branchcode in dialog when overwriting an existing notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When you copy a notice to a branch, that already has the notice and then save, you'll get a warning that the notice already exists. This message uses the branchcode instead of the library name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14911] Item search: Display additional 245 subfields in search results
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144529|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 146147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146147&action=e… Bug 14911: Add 245 fields to itemsearch title column via biblio-title.inc To test: 1. Have some records that have these 245 fields: -Title 245$a -Subtitle 245$b -Medium 245$h -Part number 245$n -Part name 245$p Note: IN KTD I have to run batchRebuildBiblioTables.pl -c 2. Apply patch and do an item search that will turn up items with the 245 fields lists above 3. Notice that those subfields are now included in the title column. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14911] Item search: Display additional 245 subfields in search results
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14911] Item search: Display additional 245 subfields in search results
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This works for the result list, but not for the CSV export. I've filed Bug 32879 - Item search: Display additional 245 subfields in CSV export I tried to provide a follow-up, but: The include used for the result lists adds spans, so we cannot use the same solution for the CSV export easily. I think this is still worthwhile as a first step. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14911] Item search: Display additional 245 subfields in search results
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |katrin.fischer(a)bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #141 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, with bug 16522 now pushed, this no longer applies. Could you pleas rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 3150: Move emails for sending cart and list contents to notices Using index info to reconstruct a base tree... M basket/sendbasket.pl M opac/opac-sendbasket.pl M opac/opac-sendshelf.pl M virtualshelves/sendshelf.pl Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 3150: Move emails for sending cart and list contents to notices hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-3150-Move-emails-for-sending-cart-and-list-con-7TAJ75.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21916] New: Add ability to specify where credits are used
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21916 Bug ID: 21916 Summary: Add ability to specify where credits are used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Bug 18805 adds the ability to apply credits to fines, which is amazing! However, it'd be good if one could specify which fines to pay with a credit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9