April 2023 - Koha-bugs - lists.koha-community.org

[Bug 33060] New: Fix yes/no setting to 1/0 in system preference YAML files
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33060 Bug ID: 33060 Summary: Fix yes/no setting to 1/0 in system preference YAML files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: katrin.fischer(a)bsz-bw.de Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 32713] New: x-koha-embed appears to no longer properly validate
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32713 Bug ID: 32713 Summary: x-koha-embed appears to no longer properly validate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com CC: tomascohen(a)gmail.com We migrated x-koha-embed into properly specified header parameters in bug 30536 however it appears that the upstream validation of those headers has since broken and we're now allowing open embed calls through from the API. At best this can lead to server errors leaking, at worst it exposed methods that should be private to the API. We need to write some tests to catch this and possibly re-instate the in-koha validation whilst the OpenAPI is updated. See 8e1265c45ddfc53d4bcbfc51e25b297e3592daf4 for some further details. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 32421] New: Add collection ( ccode ) column to holds to pull
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32421 Bug ID: 32421 Summary: Add collection ( ccode ) column to holds to pull Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Some libraries would find it helpful to include a column for collection to the holds to pull page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 32118] New: Clarify expansion/embed modifiers
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118 Bug ID: 32118 Summary: Clarify expansion/embed modifiers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com CC: tomascohen(a)gmail.com With bug 26635 we add a new additive function to the embed header options.. +av_expand.. this is a special case in that it's not just pulling in a related object, but also setting a flag to expand coded values and embed them within their own structure. We also have +relation_count.. to add a single field in a parent structure to just return the 'count' of a relation.. I think we should use :relation_count for this case? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 32923] New: x-koha-embed must be an enum
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Bug ID: 32923 Summary: x-koha-embed must be an enum Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: REST API Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com CC: tomascohen(a)gmail.com See bug 30536, since then new patches added more x-koha-embed not being enum. % git grep x-koha-embed api/v1/swagger/paths/|grep -v 'name: x-koha-embed' -- You are receiving this mail because: You are watching all bug changes.

1 67

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #136 from Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> --- (In reply to Katrin Fischer from comment #135) > Should this be needs documenting? I don,t think so. I already submitted something to the manual for this last week. I left it "Pushed to master" because to me, that means release maintainers haven't decided to backport it or not. If they have decided not to backport it, it can be set to resolved. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 32556] New: borrower_message_preference_id reaches limit
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 Bug ID: 32556 Summary: borrower_message_preference_id reaches limit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Symptom: Adding a new patron gives a 500 error. plack-error.log: C4::Members::Messaging::SetMessagingPreference(): DBI Exception: DBD::mysql::st execute failed: Out of range value for column 'borrower_message_preference_id' at row 1 at /usr/share/koha/lib/C4/Form/MessagingPreferences.pm line 98 MariaDB [koha]> select max(borrower_message_preference_id) from borrower_message_preferences; +-------------------------------------+ | max(borrower_message_preference_id) | +-------------------------------------+ | 2147475728 | +-------------------------------------+ 1 row in set (0.000 sec) MariaDB [koha]> show create table borrower_message_preferences\G *************************** 1. row *************************** Table: borrower_message_preferences Create Table: CREATE TABLE `borrower_message_preferences` ( `borrower_message_preference_id` int(11) NOT NULL AUTO_INCREMENT, `borrowernumber` int(11) DEFAULT NULL, `categorycode` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, `message_attribute_id` int(11) DEFAULT 0, `days_in_advance` int(11) DEFAULT 0, `wants_digest` tinyint(1) NOT NULL DEFAULT 0, PRIMARY KEY (`borrower_message_preference_id`), KEY `borrowernumber` (`borrowernumber`), KEY `categorycode` (`categorycode`), KEY `message_attribute_id` (`message_attribute_id`), CONSTRAINT `borrower_message_preferences_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `borrower_message_preferences_ibfk_2` FOREIGN KEY (`message_attribute_id`) REFERENCES `message_attributes` (`message_attribute_id`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `borrower_message_preferences_ibfk_3` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB AUTO_INCREMENT=2147483648 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci 1 row in set (0.000 sec) The site where this happens runs a nightly import from a student registration system, so patrons are updated frequently. Two questions: 1. How do we fix this for sites that reach the limit? I tried to disable foreign key checks and alter the column from signed to unsigned, but that did not work: MariaDB [koha]> SET FOREIGN_KEY_CHECKS=0; Query OK, 0 rows affected (0.000 sec) MariaDB [koha]> ALTER TABLE borrower_message_preferences MODIFY borrower_message_preference_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT; ERROR 1025 (HY000): Error on rename of './koha_hkr/#sql-3d8_41ab0' to './koha_hkr/borrower_message_preferences' (errno: 150 "Foreign key constraint is incorrectly formed") 2. How do we make sure this never happens? To extend the period before this happens, it might be a quick fix to change the borrower_message_preference_id column from SIGNED (the default) to UNSIGNED. As far as I can tell, this would double the number of IDs the column can hold. A better solution might be to make the borrower_message_preferences update in place, and not generate new borrower_message_preference_id's every time they are updated? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 15428] Different timeout preference for OPAC and staff interface
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #8 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Katrin Fischer from comment #7) > Marked bug 32385 as a dependency for this one. I think in order to have > different timeouts, we need different sessions first. I was thinking about alternatives but I think you might be right. In theory, an alternative would be to change how we handle timeouts. At the moment, the session is deleted if it's timed out, but we could remove those lines and leave the cleanup to the cleanup_database.pl cronjob. If someone was working in both the staff interface and OPAC, the OPAC could time out and prompt for login while they continued working in the staff interface. Then if they log into the OPAC, both interfaces will use the new session and new session cookie. However, I wonder if a browser might accidentally overwrite the new CGISESSID with the old CGISESSID if a staff interface action happens shortly after the new OPAC login... Maybe different sessions are the way to go. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 32385] New: OPAC and staff (intranet) should not share the same session and cookie
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32385 Bug ID: 32385 Summary: OPAC and staff (intranet) should not share the same session and cookie Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org See also bug 32369. A login via OPAC should imo not allow you to access staff too when you share the same domain (and cookies) between them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 15428] Different timeout preference for OPAC and staff interface
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

1 0