April 2023 - Koha-bugs - lists.koha-community.org

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '23

25 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150208|0 |1 is obsolete| | --- Comment #102 from Hammat wele <hammat.wele(a)inlibro.com> --- Created attachment 150217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150217&action=e… Bug 12532: Send email to guarantee and guarantor This patch allows guarantors to receive emails sended to their guarentees. This patch is a rebase of the previous patches. I took all the content of previous commit and put it in one commit. TO TEST: Before applying: 1) Search, or create, a patron with guarantor. 2) Enable checkout emails for both guarantors and guarantees. 3) Checkout an item. An email should be sent only to the guarantee. 4) Apply the patch. 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Run misc/cronjobs/process_message_queue.pl 8) Notice that the email should be sended to both the guarantee AND the guarantor. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '23

25 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #101 from David Nind <david(a)davidnind.com> --- (In reply to Hammat wele from comment #100) > I've made some fixes to the patch Thanks Hammat! Unfortunately, the patch no longer applies 8-(.. git bz apply 12532 Bug 12532 - Redirect guarantee email to guarantor 150208 - Bug 12532: Send email to guarantee and guarantor Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12532: Send email to guarantee and guarantor .git/rebase-apply/patch:37: trailing whitespace. unless ($to_address) { warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Letters.pm M Koha/Patron.pm M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref M t/db_dependent/Letters.t .git/rebase-apply/patch:37: trailing whitespace. unless ($to_address) { warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging Koha/Patron.pm Auto-merging C4/Letters.pm CONFLICT (content): Merge conflict in C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 12532: Send email to guarantee and guarantor hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12532-Send-email-to-guarantee-and-guarantor-W5BJUI.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27074] New: When a subscription is closed, it still shows as current in OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '23

25 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27074 Bug ID: 27074 Summary: When a subscription is closed, it still shows as current in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When a subscription is closed in the staff interface, it will still show as current (running) in the OPAC: Subscription from: 12/29/2019 to: now (current) This is due to the subscription history end date being empty. In order to fix this, you need to activate manual history and set it manually, lots of clicks. I suggest that we either automatically fill the subscription end date on closing the subscription (I think the predicted or receive date of the last issue would be good) or offer an option to do so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 29341] New: If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '23

25 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Bug ID: 29341 Summary: If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)univ-lyon3.fr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you activate the pseudonymization process and the system preference OpacRenewalBranch = opacrenew, there's an "internal server error" when patrons renew there loans at the OPAC. In logs, you can find : DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`pseudonymized_trans actions`, CONSTRAINT `pseudonymized_transactions_borrowers_ibfk_3` FOREIGN KEY (`transaction_branchcode`) REFERENCES `branches` (`branchcode`)) [for Stat ement "INSERT INTO `pseudonymized_transactions` ( `branchcode`, `categorycode`, `ccode`, `dateenrolled`, `datetime`, `has_cardnumber`, `hashed_borrowernu mber`, `holdingbranch`, `homebranch`, `itemcallnumber`, `itemnumber`, `itemtype`, `location`, `sort1`, `sort2`, `transaction_branchcode`, `transaction_ty pe`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='MAN', 1='ETUL3', 2=undef, 3='2021-01-11', 4='2021-10-27 06:28:28' , 5=1, 6="$xxxxxxxxxxxxxxxxxxxxxxxxx", 7='MAN', 8='MAN', 9='345 PIN', 10="728028", 11='PRET', 12='MANDG3', 13='ELdro', 14='3101000IL', 15='OPACRenew', 16='renew'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 49

[Bug 32439] New: Allow selective deletion of statistics entries based on type by cleanup_database
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '23

25 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32439 Bug ID: 32439 Summary: Allow selective deletion of statistics entries based on type by cleanup_database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrewfh(a)dubcolib.org QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Depends on: 19008, 24151 Cleanup_database can delete all statistics entries more than X days old. If one is using pseudonymization to create pseudonymized_transactions data, then one may wish to use that cleanup_database function to delete statistics entries that have been duplicated in pseudonymized_transactions. However, not all types of transactions in statistics are duplicated in pseudonymized transactions. Statistics includes checkouts, returns, renewals, payments, writeoffs, and localuse. Pseudonymized_transactions only includes checkouts, returns, and renewals. It would be helpful to be able to delete only statistics entries more than X days old and in a specified list of types. Approaching this from the other end, Bug 32438 suggests adding payments and writeoffs to pseudonymized_transactions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 [Bug 19008] Add more options to cleanup database script https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 28912] New: Pseudonymization should display a nice error message when brcypt_settings are not defined
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '23

25 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Bug ID: 28912 Summary: Pseudonymization should display a nice error message when brcypt_settings are not defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Currently we cause an ISE when bcrypt_settings are missing We should throw/catch an exception and display a nicer error message To recreate: 1 - edit koha-conf, remove 'bcrypt_settings' 2 - Enable pseudonymization 3 - Attempt a checkout 4 - Boom! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 24152] New: Add the ability to purge pseudonymized data
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '23

25 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Bug ID: 24152 Summary: Add the ability to purge pseudonymized data Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

1 45

[Bug 24151] New: Add a pseudonymization process for patrons and transactions
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '23

25 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Bug ID: 24151 Summary: Add a pseudonymization process for patrons and transactions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 176

[Bug 32672] New: Incorrect CSS path to jquery-ui
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '23

25 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Bug ID: 32672 Summary: Incorrect CSS path to jquery-ui Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 30011 Not sure how bad this is, but we are pointing to a non-existing css file: koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt: [% Asset.css("lib/jquery/jquery-ui-1.13.1.css") | $raw %] koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt:[% Asset.css("lib/jquery/jquery-ui-1.13.1.css") | $raw %] koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt: [% Asset.css("lib/jquery/jquery-ui-1.13.1.css") | $raw %] From commit de2d8ba3e4f611aadc29165a7748cc1797d87ce3 Bug 30011: Update links to jQueryUI assets, remove datepicker references, etc. - [% Asset.css("lib/jquery/jquery-ui-1.12.1.css") | $raw %] + [% Asset.css("lib/jquery/jquery-ui-1.13.1.css") | $raw %] We only have the min version for 1.13.1.css Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '23

25 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #100 from Hammat wele <hammat.wele(a)inlibro.com> --- (In reply to David Nind from comment #97) > I have tested (using koha-testing-docker), so that there is a sign-off from > someone other than InLibro staff. > > Notes from testing: > > 1. There are whitespace errors when applying the patches. [1] > > 2. Formatting patch titles - these should be in the format Bug XXXX: The > title for the patch AND Bug XXXX: (follow-up) The title for the follow-up > (see https://wiki.koha-community.org/wiki/Commit_messages#Subject_line) > > 3. Patches with the same name - this can be confusing, but I'm not sure of > the best way to do this for this bug. Also, as this bug has been around for > a while, and has a bit of history, maybe the patches should be consolidated. > I would ask on IRC to get expert advice on the best approach to take for > this bug (maybe have the main patch, a patch for the database update, and a > patch for test changes). > > 4. Running updatedatabase produced no output on the command line for me - > normally it does. The way to do database updates changed a while ago, but I > don't know enough about how this works to comment. Maybe ask on IRC or see > https://wiki.koha-community.org/wiki/Database_updates However, the new > system preference RedirectGuaranteeEmail appears for me. > > 5. Running the tests fail for: prove t/db_dependent/Members.t and prove > t/db_dependent/Letters.t [2] > > 6. Comment #70 - not sure whether any of the issues raised have been > addressed, or whether these should be addressed in a separate bug. I've made some fixes to the patch -- You are receiving this mail because: You are watching all bug changes.

1 0