July 2023 - Koha-bugs - lists.koha-community.org

[Bug 33370] New: Agreements_spec.ts is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33370 Bug ID: 33370 Summary: Agreements_spec.ts is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org On Koha_Master/2446 koha_1 | <testcase name="Agreement CRUD operations Add agreement" time="0.0000" classname="Add agreement"> koha_1 | <failure message="Timed out retrying after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it. koha_1 | at Context.eval (http://kohadev-intra.mydnsname.org:8081/__cypress/tests?p=t/cypress/integra…)></failure> koha_1 | </testcase> -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 33400] New: Titles_spec.ts is failing because alert is not visible
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33400 Bug ID: 33400 Summary: Titles_spec.ts is failing because alert is not visible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org <testcase name="Title CRUD operations Add title" time="0.0000" classname="Add title"> <failure message="Timed out retrying after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it. at Context.eval (http://kohadev-intra.mydnsname.org:8081/__cypress/tests?p=t/cypress/integra…)></failure> </testcase> We are expecting the error, but it appears at the top and it's not in the viewport. Only happens in without using the cypress UI -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 32926] New: Cannot expand or collapse some System preference sections after a search
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 Bug ID: 32926 Summary: Cannot expand or collapse some System preference sections after a search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: a.roussos(a)dataly.gr QA Contact: testopia(a)bugs.koha-community.org If you perform a System preferences search for a common word such as "type" or "log", you then lose the ability to expand or collapse the sections with names that appear more than once in the results page. All sections except the first one in each group of duplicates are affected by this. When you click on the 2nd, 3rd, etc. occurence of a section, the expand/collapse arrow does change, but in reality only the section that appears first in the page is actually toggled. I have created an animated GIF that shows this in action: https://imgur.com/a/NSslIcV This affects Koha 20.11.00 or later; `git bisect` tells me that the relevant commit is 9d890c7636ef1d6ec0a1de2161906fd9f4375e97 from Bug 23410. To reproduce: Perform a System preferences search for a common word such as "type" or "log". In the results page, the "Policy" section will appear more than once. Now try to expand/collapse any "Policy" section but the first one. It won't work, only the first "Policy" section is toggled. -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 32894] New: Objects cache methods' result without invalidation
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Bug ID: 32894 Summary: Objects cache methods' result without invalidation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, martin.renvoize(a)ptfs-europe.com, tomascohen(a)gmail.com In some of our Koha:: objects we have methods that cache their result and return it in subsequent calls. However there is no invalidation of the cache if the object is modified. For instance, in Koha/ArticleRequest.pm sub biblio { my ($self) = @_; $self->{_biblio} ||= Koha::Biblios->find( $self->biblionumber() ); return $self->{_biblio}; } This pattern exists in several places. It can lead to confusion and incorrect results, such as: use Koha::ArticleRequests; my $ar = Koha::ArticleRequest->new({ borrowernumber => 42, biblionumber => 42, })->store; say $ar->biblio->biblionumber; # Display 42, correct $ar->set({ biblionumber => 24 })->store; say $ar->biblio->biblionumber; # Display 42, wrong $ar->discard_changes; say $ar->biblio->biblionumber; # Display 42, wrong $ar->delete; We should remove those caching and rely on DBIC/DBMS caching mechanism instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 60

[Bug 34072] New: Holds queue search interface hidden on small screens
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Bug ID: 34072 Summary: Holds queue search interface hidden on small screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrewfh(a)dubcolib.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The search interface for the holds queue (view_holdsqueue.pl) is hidden on small/narrow screens. To recreate in Chrome: - go to /cgi-bin/koha/circ/view_holdsqueue.pl - inspect something within the page to open the dev tools - press ctrl-shift-m to show the device toolbar - use the device toolbar to reduce the resolution of your window - observe that the search controls are lost at smaller resolutions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 34359] New: Can we get rid of Koha/BiblioUtils ?
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Bug ID: 34359 Summary: Can we get rid of Koha/BiblioUtils ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org This is not used (only by itself): git grep BiblioUtils::Iterator Koha/BiblioUtils/Iterator.pm:package Koha::BiblioUtils::Iterator; Koha/BiblioUtils/Iterator.pm:Koha::BiblioUtils::Iterator - iterates over biblios provided by a DBIx::Class::ResultSet Koha/BiblioUtils/Iterator.pm: use Koha::BiblioUtils::Iterator; Koha/BiblioUtils/Iterator.pm: my $iterator = Koha::BiblioUtils::Iterator->new($rs); t/db_dependent/Koha/BiblioUtils/Iterator.t:use_ok('Koha::BiblioUtils::Iterator'); t/db_dependent/Koha/BiblioUtils/Iterator.t:my $iterator = Koha::BiblioUtils::Iterator->new($rs, items => 1 ); I know that someone kind of hates Util modules :) Unfortunately we cannot (yet) remove Koha::BiblioUtils module: Koha/BiblioUtils.pm:package Koha::BiblioUtils; Koha/BiblioUtils.pm:Koha::BiblioUtils - contains fundamental biblio-related functions Koha/BiblioUtils.pm: my $biblio = Koha::BiblioUtils->new($marc_record, [$biblionumber]); Koha/BiblioUtils.pm:Creates an instance of C<Koha::BiblioUtils> based on the marc record. If known, Koha/BiblioUtils.pm: my $biblio = Koha::BiblioUtils->get_from_biblionumber($biblionumber, %options); Koha/BiblioUtils.pm:This will give you an instance of L<Koha::BiblioUtils> that is the biblio that Koha/BiblioUtils.pm: my $it = Koha::BiblioUtils->get_all_biblios_iterator(%options); Koha/BiblioUtils.pm:Koha::BiblioUtils of each biblio. This will include the item data. Koha/BiblioUtils.pm: my $marc = Koha::BiblioUtils->get_marc_biblio($bibnum, %options); misc/release_notes/release_notes_22_05_00.html:<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625">[29625]</a> Wrong var name in Koha::BiblioUtils get_all_biblios_iterator</li> misc/release_notes/release_notes_22_05_00.md:- [[29625]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625) Wrong var name in Koha::BiblioUtils get_all_biblios_iterator misc/search_tools/rebuild_elasticsearch.pl:use Koha::BiblioUtils; misc/search_tools/rebuild_elasticsearch.pl: return ($r, Koha::BiblioUtils->get_from_biblionumber($r, item_data => 1 )); misc/search_tools/rebuild_elasticsearch.pl: my $records = Koha::BiblioUtils->get_all_biblios_iterator(%iterator_options); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 15701] New: Port Koha::Contrib::Tamil koha-cloud into Koha code base
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701 Bug ID: 15701 Summary: Port Koha::Contrib::Tamil koha-cloud into Koha code base Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: mtj(a)kohaaloha.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Port Koha::Contrib::Tamil koha-cloud into Koha code base more info to come... -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 15957] New: Move AO in Patron Status
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15957 Bug ID: 15957 Summary: Move AO in Patron Status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 34433] New: 'Custom cover image' in lightbox is untranslatable
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34433 Bug ID: 34433 Summary: 'Custom cover image' in lightbox is untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Created attachment 153974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153974&action=e… Sample records In the staff interface, when viewing a custom cover image in the lightbox, at the bottom, it says 'Custom cover image'. This string is not translatable. To test: Note: I attached a file of sample (MARC21) records that I use for various image sources, in which one record has a URL to an image in 956$u, you can import this file into Koha, if needed - Download the attached marc file (coverimages.mrc) - In the Koha staff interface, go to Cataloging > Stage records for import - Click the "Choose file" or "Browse" button and choose the downloaded file - Click "Upload file" - Click "Stage for import" - Click "View detail of the enqueued job" - Click "View batch" - Click "Import this batch into the catalog" 1. Enable CustomCoverImages 1.1. Go to Administration > System preferences 1.2. Search for CustomCoverImages 1.3. Select "Show" in CustomCoverImages 1.4. Set CustomCoverImagesURL to {956$u} 1.5. Click "Save all Enhanced content preferences" 2. Install new language 2.1. gulp po:update --lang fr-CA 2.2. Search for "Custom cover image" in the staff-prog.po file, make sure it is translated 2.3. Install translations ./misc/translator/translate install fr-CA 2.4. In the staff interface, go to Administration > System preferences 2.5. Search for language 2.6. Check the box next to the newly installed language 2.7. Click "Save all I18N/L10N preferences" 3. View the image in the lightbox in the staff interface 3.1. If using the attached records, search the catalog in the staff interface for "As you like it"; If not using the file, add an image URL in 956$u, or finagle something with CustomCoverImagesURL 3.2. Click on the title to view the detailed record 3.3. Click on the image to view it in the lightbox --> In the image box, notice that it says "Custom cover image" 3.4. Click the X to close the lightbox 5. Change the language of the staff interface 6. Reopen the lightbox --> The caption of the lightbox is still "Custom cover image" in the other language even if the string was translated in the po file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 27881] New: Markup error in masthead-langmenu.inc
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Bug ID: 27881 Summary: Markup error in masthead-langmenu.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 20168 masthead-langmenu.inc has a few instances of this error: <a class="dropdown-item"<a href="#" tabindex="-1" class="menu-inactive" role="menuitem"> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes.

1 15