July 2023 - Koha-bugs - lists.koha-community.org

[Bug 24359] New: Remove items from Holds Queue when checked in
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Bug ID: 24359 Summary: Remove items from Holds Queue when checked in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: joy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Currently, if an item is checked in and the hold is triggered/captured, the item will not come off the holds queue until the the cronjob runs again. This causes some confusion for multibranch systems when other branches attempt to fill holds that have already been filled. Proposal: Remove bib/items from the Holds Queue after checkin and before the next holds queue cron runs to update the holds queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 31735] New: Circulation optimizations
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Bug ID: 31735 Summary: Circulation optimizations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We recently had time-out issues and high server loads for patrons with high checkout counts (some patrons have several hundreds, up to about 400). One of the major bottlenecks turned out to be C4::Circulation::CanBookBeRenewed. The primary reason it performed so poorly was constant re-fetching of different database entities which could just as well be passed down directly instead of passing ids which requires re-fetching further down the call stack. After refactoring the most performance critical subroutines to take objects instead of object ids the calls to expensive DBIx-methods has been greatly reduced. In addition some other optimizations and bug fixes related to non working caching resulted in further speedups. The performance gain for a patron with around 400 checkouts is currently about 500%. I made an effort to fix all tests affected by the changes, but I can not guarantee there are absolutely no regressions left in the test-suite. Since many tests seem to fail due to reasons not related to this patch, mainly due to the state of my local instance triggering tests-bugs (for example caused by preferences not being mocked correctly, or relying on database test-entries that are not guaranteed to exist), it was impractical and very time consuming to make sure all tests still run successfully. So subset of tests where the changed subroutines are called directly was selected and these should now pass. The following tests should be effected by the changes and should be run as a part of the test-plan: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t The following still fails for me but should either work on a fresh Koha installation, or fail for unrelated reasons (that is they also fail in Koha master): t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Items.t t/db_dependent/SIP/ILS.t To be able to run t/db_dependent/Circulation.t in my Koha instance there where some existing bugs that needed fixing, so this patch have a dependency on Bug 31676. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 109

[Bug 34445] New: Default budget is not selected in addorderiso2709.pl
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34445 Bug ID: 34445 Summary: Default budget is not selected in addorderiso2709.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: matt.blenkinsop(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org When adding order lines to a basket from a staged marc file using the mappings in MarcItemFieldsToOrder a default budget should be selected when adding order lines if no budget is selected in the UI. Currently this does not happen and the order line creation fails. To replicate: 1) Add the following to the syspref MarcItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$p replacementprice: 975$v 2) Save the file attached ready to stage 3) Navigate to Acquisitions, choose a vendor and then create/choose a basket 4) Click Add to basket and then From a new file 5) Choose the file you just saved 6) Change the Record matching rule to ISBN and the Action if matching record found to Ignore incoming record. Click stage for import 7) When the job progress is complete, click the Add staged files to basket button 8) Click on the Item information tab and in field y - Koha item type select Books 9) Click Select all on the table 10) Observe that under Item record 1, the budget_code field says "Select a fund...". Do not change this field, this is just to show that no budget has been selected 11) At the bottom of the form, click Save 12) You should be back on the basket page - observe that no order lines have been added -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 34115] New: When editing bibliographic frameworks, the right tab is not always preselected
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34115 Bug ID: 34115 Summary: When editing bibliographic frameworks, the right tab is not always preselected Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org There are 2 small regressions here that probably happened when the tabs handling was updated: 1) Shortcut to edit a subfield from search form This is a somewhat hidden feature, but really nice: * Go to administration > bibliographic frameworks * Any framework > MARC structure * "Search for tag" enter 245$b --> Verify you see the edit form, but tab 0 is active 2) Shortcut to edit a subfield from subfield letter/number * Go to administration > bibliographic frameworks * Any framework > MARC structure * Search for 952 * Actions > View subfields * Click on any subfield but 0 --> Verify you see the edit form, but tab 0 is active -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 34095] New: Shipping cost should default to a blank box instead of 0.00
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095 Bug ID: 34095 Summary: Shipping cost should default to a blank box instead of 0.00 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: Laura.escamilla(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Shipment cost should default to a blank box instead of 0.00. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 34066] New: Datatable options don't fully translate on list of saved reports
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34066 Bug ID: 34066 Summary: Datatable options don't fully translate on list of saved reports Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Created attachment 152484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152484&action=e… screenshot of saved reports In the screenshot you can see that some of the datatables related string translate, while others remain in English, especially: Showing x to x entries Show x entries First previous next last Search On other pages, like administration > libraries the translation is complete. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 34307] New: Update plugin wrapper to use template wrapper for breadcrumbs
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 Bug ID: 34307 Summary: Update plugin wrapper to use template wrapper for breadcrumbs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Depends on: 31339 The staff side wrapper template for tool plugins needs an update to create breadcrumbs using the template wrapper for breadcrumbs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 34386] New: Inconsistencies in Cities and tows page titles, breadcrumbs, and header
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34386 Bug ID: 34386 Summary: Inconsistencies in Cities and tows page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Cities and towns page, here is what should be changed to make it consistent with the other pages in the module: Page title - Add city name, in single quotes, to Modify X (e.g. Modify city 'Montreal') - Add city name, in single quotes, to Confirm deletion of X (e.g. Confirm deletion of city 'Montreal') Breadcrumb - Add city name, in single quotes, to Modify X (e.g. Modify city 'Montreal') - Add city name, in single quotes, to Confirm deletion of X (e.g. Confirm deletion of city 'Montreal') Page header - Change 'Modify a city' to "Modify city 'Y'" (as above) - Change "Delete city 'Y?'" to "Confirm deletion of city 'Y'" -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 34385] New: Inconsistencies in Transport cost matrix page header
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34385 Bug ID: 34385 Summary: Inconsistencies in Transport cost matrix page header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Transport cost matrix page, here is what should be changed to make it consistent with the other pages in the module: Page header - Change 'Defining transport costs between libraries' to 'Transport cost matrix' -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 34379] New: Inconsistencies in Library groups page
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34379 Bug ID: 34379 Summary: Inconsistencies in Library groups page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Libraries page, here is what should be changed to make it consistent with the other pages in the module: - Change the 'Add group' button to 'New group' -- You are receiving this mail because: You are watching all bug changes.

1 13