July 2023 - Koha-bugs - lists.koha-community.org

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153258|0 |1 is obsolete| | --- Comment #55 from Sam Lau <samalau(a)gmail.com> --- Created attachment 153277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153277&action=e… Bug 6796: Fix saving of libraries and tests Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153257|0 |1 is obsolete| | --- Comment #54 from Sam Lau <samalau(a)gmail.com> --- Created attachment 153276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153276&action=e… Bug 6796: Fix atomic updates Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153256|0 |1 is obsolete| | --- Comment #53 from Sam Lau <samalau(a)gmail.com> --- Created attachment 153275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153275&action=e… Bug 6796: Updated schema files Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153255|0 |1 is obsolete| | --- Comment #52 from Sam Lau <samalau(a)gmail.com> --- Created attachment 153274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153274&action=e… Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153254|0 |1 is obsolete| | --- Comment #51 from Sam Lau <samalau(a)gmail.com> --- Created attachment 153273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153273&action=e… Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153253|0 |1 is obsolete| | --- Comment #50 from Sam Lau <samalau(a)gmail.com> --- Created attachment 153272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153272&action=e… Bug 6796: ConsiderLibraryHoursWhenIssuing system preference Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153252|0 |1 is obsolete| | --- Comment #49 from Sam Lau <samalau(a)gmail.com> --- Created attachment 153271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153271&action=e… Bug 6796: Add branch_hours table and set opening hours for library Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 33888] New: Overdue fines not displayed branchoverdues.pl error 500
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Bug ID: 33888 Summary: Overdue fines not displayed branchoverdues.pl error 500 Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cacho(a)genac.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If there are no overdue items with fines, the report works, but if there are overdues with fines, they won't display, the script returns a 500 error, and the log records this: [Fri Jun 02 12:35:22.463020 2023] [cgi:error] [pid 8954] [client 192.168.1.1:47406] AH01215: Template process failed: undef error - : filter not found at /usr/share/koha/lib/C4/Templates.pm line 127.: /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl, referer: http://bibliotecacho-intra.locales/cgi-bin/koha/circ/circulation-home.pl [Fri Jun 02 12:35:22.527939 2023] [cgi:error] [pid 8954] [client 192.168.1.1:47406] End of script output before headers: branchoverdues.pl, referer: http://bibliotecacho-intra.locales/cgi-bin/koha/circ/circulation-home.pl This happens for 23.05 too. I tested this with a new install, english only, from debian packages. Also happened when updating a couple of unrelated servers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 33885] New: Get HTTP 500 when retrieving orders created by a non-existent (deleted) user
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33885 Bug ID: 33885 Summary: Get HTTP 500 when retrieving orders created by a non-existent (deleted) user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: slavashishkin(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 33293 Problem description: Occurs for orders where 'created_by' is NULL with the message in log: DBIC result _type isn't of the _type Borrower at /usr/share/koha/lib/Koha/Objects.pm line 463. This did not occur before in version 22.11 because there was no modal and the logic was different. Generally, according to the design, it is assumed that 'created_by' can be NULL, for example, due to a constraint that cleans it when the borrower record is deleted from the database. Steps to reproduce: 1. Create a superuser. 2. Add an order to the cart as a new user. 3. Delete the new user from the system. 4. Go to the orders section and select an order created by the non-existent user. 5. Click the "Get Order" button. Expected behavior: When attempting to retrieve an order created by a non-existent user, a confirmation pop-up window should appear for order retrieval. Actual behavior: Clicking the "Receive" button results in a JS alert with 'error 500 / The system is unable to process the request and returns an internal server error' message. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 [Bug 33293] Use template wrapper for tabs: Holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17