August 2023 - Koha-bugs - lists.koha-community.org

[Bug 33370] New: Agreements_spec.ts is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33370 Bug ID: 33370 Summary: Agreements_spec.ts is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org On Koha_Master/2446 koha_1 | <testcase name="Agreement CRUD operations Add agreement" time="0.0000" classname="Add agreement"> koha_1 | <failure message="Timed out retrying after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it. koha_1 | at Context.eval (http://kohadev-intra.mydnsname.org:8081/__cypress/tests?p=t/cypress/integra…)></failure> koha_1 | </testcase> -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 33400] New: Titles_spec.ts is failing because alert is not visible
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33400 Bug ID: 33400 Summary: Titles_spec.ts is failing because alert is not visible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org <testcase name="Title CRUD operations Add title" time="0.0000" classname="Add title"> <failure message="Timed out retrying after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it. at Context.eval (http://kohadev-intra.mydnsname.org:8081/__cypress/tests?p=t/cypress/integra…)></failure> </testcase> We are expecting the error, but it appears at the top and it's not in the viewport. Only happens in without using the cypress UI -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 32926] New: Cannot expand or collapse some System preference sections after a search
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 Bug ID: 32926 Summary: Cannot expand or collapse some System preference sections after a search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: a.roussos(a)dataly.gr QA Contact: testopia(a)bugs.koha-community.org If you perform a System preferences search for a common word such as "type" or "log", you then lose the ability to expand or collapse the sections with names that appear more than once in the results page. All sections except the first one in each group of duplicates are affected by this. When you click on the 2nd, 3rd, etc. occurence of a section, the expand/collapse arrow does change, but in reality only the section that appears first in the page is actually toggled. I have created an animated GIF that shows this in action: https://imgur.com/a/NSslIcV This affects Koha 20.11.00 or later; `git bisect` tells me that the relevant commit is 9d890c7636ef1d6ec0a1de2161906fd9f4375e97 from Bug 23410. To reproduce: Perform a System preferences search for a common word such as "type" or "log". In the results page, the "Policy" section will appear more than once. Now try to expand/collapse any "Policy" section but the first one. It won't work, only the first "Policy" section is toggled. -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 32894] New: Objects cache methods' result without invalidation
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Bug ID: 32894 Summary: Objects cache methods' result without invalidation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, martin.renvoize(a)ptfs-europe.com, tomascohen(a)gmail.com In some of our Koha:: objects we have methods that cache their result and return it in subsequent calls. However there is no invalidation of the cache if the object is modified. For instance, in Koha/ArticleRequest.pm sub biblio { my ($self) = @_; $self->{_biblio} ||= Koha::Biblios->find( $self->biblionumber() ); return $self->{_biblio}; } This pattern exists in several places. It can lead to confusion and incorrect results, such as: use Koha::ArticleRequests; my $ar = Koha::ArticleRequest->new({ borrowernumber => 42, biblionumber => 42, })->store; say $ar->biblio->biblionumber; # Display 42, correct $ar->set({ biblionumber => 24 })->store; say $ar->biblio->biblionumber; # Display 42, wrong $ar->discard_changes; say $ar->biblio->biblionumber; # Display 42, wrong $ar->delete; We should remove those caching and rely on DBIC/DBMS caching mechanism instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 60

[Bug 15341] Performance - Retrieve all sysprefs at once
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #25 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Katrin Fischer from comment #24) > (In reply to David Cook from comment #23) > > Looks like an old one, but I've often wondered why we haven't fetched all > > the system preferences at once to avoid subsequent calls to the database. > > > > I suppose it does introduce overhead though as you are getting everything > > when in practice you might only use a few preferences. And the more > > preferences you have, the slower that fetch will become. It wouldn't scale. > > > > I suppose the L1/L2 caching we have now should take care of this, although > > I'm trying to see where the L2 cache gets intialized... > > Joubu, reading this, would you agree we can close this bug? No, I still think this is a good one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8838] Digest option for HOLD notice
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154948|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 154950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154950&action=e… Bug 8838: Add digest option for HOLD notice Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new digest option for "Hold filled" messages 5) Trap multiple holds for a patron 6) Note a single notices is generated for all the trapped holds! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8838] Digest option for HOLD notice
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Assignee|koha-bugs(a)lists.koha-commun |kyle(a)bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8838] Digest option for HOLD notice
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154947|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 154948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154948&action=e… Bug 8838: Add digest option for HOLD notice Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new digest option for "Hold filled" messages 5) Trap multiple holds for a patron 6) Note a single notices is generated for all the trapped holds! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8838] Digest option for HOLD notice
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 --- Comment #26 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 154947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154947&action=e… Bug 8838: Add digest option for HOLD notice Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new digest option for "Hold filled" messages 5) Trap multiple holds for a patron 6) Note a single notices is generated for all the trapped holds! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 34072] New: Holds queue search interface hidden on small screens
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Bug ID: 34072 Summary: Holds queue search interface hidden on small screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrewfh(a)dubcolib.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The search interface for the holds queue (view_holdsqueue.pl) is hidden on small/narrow screens. To recreate in Chrome: - go to /cgi-bin/koha/circ/view_holdsqueue.pl - inspect something within the page to open the dev tools - press ctrl-shift-m to show the device toolbar - use the device toolbar to reduce the resolution of your window - observe that the search controls are lost at smaller resolutions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16