August 2023 - Koha-bugs - lists.koha-community.org

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '23

26 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #124 from Hammat wele <hammat.wele(a)inlibro.com> --- Created attachment 154857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154857&action=e… Bug 12532: (follow-up) Send email to guarantor using the CC field In This patch the CC field is used to send the message to the guarantors. If the «to» field is empty (the guarantee has no address) we send the message «to» the garantors. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '23

26 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151029|0 |1 is obsolete| | --- Comment #123 from Hammat wele <hammat.wele(a)inlibro.com> --- Created attachment 154856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154856&action=e… Bug 12532: (QA follow-up) Clean up notice_email_address Reduce some of the code duplication -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '23

26 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151028|0 |1 is obsolete| | --- Comment #122 from Hammat wele <hammat.wele(a)inlibro.com> --- Created attachment 154855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154855&action=e… Bug 12532: (QA follow-up) Undo changes to Koha::Email The changes here aren't required (Email::Address already deals with lists of addresses internally) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '23

26 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150256|0 |1 is obsolete| | --- Comment #121 from Hammat wele <hammat.wele(a)inlibro.com> --- Created attachment 154854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154854&action=e… Bug 12532: Send email to guarantee and guarantor This patch allows guarantors to receive emails sended to their guarentees. This patch is a rebase of the previous patches. I took all the content of previous commit and put it in one commit. TO TEST: Before applying: 1) Search, or create, a patron with guarantor. 2) For both guarantors and guarantees: - Add an email address - Update the 'Patron messaging preferences' section so that an email is sent for item checkouts 3) Checkout an item. An email should be sent only to the guarantee. 4) Apply the patch. 5) Run updatedatabase.pl 6) Run prove t/db_dependent/Members.t and prove t/db_dependent/Letters.t 7) Enable 'RedirectGuaranteeEmail' 8) Run misc/cronjobs/process_message_queue.pl 9) Notice that the email should be sended to both the guarantee AND the guarantor. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '23

26 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #120 from Hammat wele <hammat.wele(a)inlibro.com> --- (In reply to Martin Renvoize from comment #116) > Sorry, I also meant to say I think the guarantor email should go in the cc > field rather than to field (unless the to field is empty in which case just > put guarantor in to). This complicates things a little but I feel it's the > right behaviour (In reply to Martin Renvoize from comment #118) > I agree Marcel.. It was late last night. > > So.. In short, I'd like some explanations from the original author as to why > they picked the changes they did.. I still don't understand a number of them. > > I think hooking into _send_message_by_email in C4::Letters is starting to > feel like it might be the right place... but setting a `cc` rather than > additional `to` Hi martin, The main goal here was to send email to both the guarantor and the guarantee either we use the to or cc field. But I agree with you, we should use the cc field to send the message to the garantors instead adding garantor addresses to the to field. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34603] New: Deleted biblio causes holdshistory.tt to explode
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '23

25 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34603 Bug ID: 34603 Summary: Deleted biblio causes holdshistory.tt to explode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: 1. Make some holds for a patron 2. Fulfill the hold then check it back in 3. Delete the biblio 4. Explode Template process failed: undef error - DBIC result _type isn't of the _type Biblio at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt line 73. at /kohadevbox/koha/C4/Templates.pm line 127 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 33176] New: paycollect.pl should have a check for payment type if RequirePaymentType
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '23

25 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 Bug ID: 33176 Summary: paycollect.pl should have a check for payment type if RequirePaymentType Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com We have notices, with RequirePaymentType on, that sometimes payments still go through without a payment type. RequirePaymentType adds the required attribute to the template but this can be circumnavigated by using your browser's dev tools. We should add a check in the script to make sure there is a payment type and if not, prevent the payment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 34

[Bug 32764] New: [DOCS] Update some information in I18N system preferences chapter
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '23

25 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32764 Bug ID: 32764 Summary: [DOCS] Update some information in I18N system preferences chapter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Found while translating, so just quickly noting it here: https://koha-community.org/manual/22.11/en/html/i18npreferences.html The page mentions the wiki page and some old command to install additional languages. It would be better to always link to the wiki page. Package commands should be preferred for package installations and the listed command should not be used there. The description of the date formats omits the DD.MM.YYYY format. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 34044] New: System preference EmailOverduesNoEmail is missing in manual
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '23

25 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34044 Bug ID: 34044 Summary: System preference EmailOverduesNoEmail is missing in manual Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: michaela.sieber(a)kit.edu QA Contact: testopia(a)bugs.koha-community.org There is no description for system preference EmailOverduesNoEmail It should be part of the chapter Global system preferences > Administration > interface options See: https://koha-community.org/manual//23.05/de/html/administrationpreferences.… Text for manual: Asks: ___ overdue notices for patrons without email address to staff. Default: Send Values: Don’t send Send Description: If this system preference is enabled overdue notices for patrons without email address to staff (see system preference AddressForFailedOverdueNotices). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 34615] New: Fix POD of C4::Circulation::AddReturn
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '23

25 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34615 Bug ID: 34615 Summary: Fix POD of C4::Circulation::AddReturn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Developer documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org Part of the POD currently looks like this: $messages is a reference-to-hash giving feedback on the operation. The keys of the hash are: "BadBarcode" No item with this barcode exists. The value is $barcode. "NotIssued" The book is not currently on loan. The value is $barcode. "withdrawn" This book has been withdrawn/cancelled. The value should be ignored. "Wrongbranch" This book has was returned to the wrong branch. The value is a hashref so that "$messages-"{Wrongbranch}->{Wrongbranch}> and "$messages-"{Wrongbranch}->{Rightbranch}> contain the branchcode of the incorrect and correct return library, respectively. "ResFound" The item was reserved. The value is a reference-to-hash whose keys are fields from the reserves table of the Koha database, and "biblioitemnumber". It also has the key "ResFound", whose value is either "Waiting", "Reserved", or 0. "WasReturned" Value 1 if return is successful. "NeedsTransfer" If AutomaticItemReturn is disabled, return branch is given as value of NeedsTransfer. "RecallFound" This item can fill a recall. The recall object is returned. If the recall pickup branch differs from the branch this item is being returned at, "RecallNeedsTransfer" is also returned which contains this branchcode. "TransferredRecall" This item has been transferred to this branch to fill a recall. The recall object is returned. When I run a barcode through AddReturn and dump $messages, I get something like this: $VAR1 = { 'WrongTransferItem' => x, 'NotIssued' => 'y', 'WrongTransfer' => 'Z', 'TransferTrigger' => 'Reserve' }; Looks like at least WrongTransferItem, WrongTransfer and TransferTrigger are undocumented? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0