September 2023 - Koha-bugs - lists.koha-community.org

[Bug 34489] New: Koha/Patrons.t: Run get_age and is_valid_age in UTC
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '23

17 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Bug ID: 34489 Summary: Koha/Patrons.t: Run get_age and is_valid_age in UTC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Running in Amsterdam TZ gives: # Subtest: get_age not ok 5 - Today=2020-02-28, dob=2004-02-28, should be 16 # Failed test 'Today=2020-02-28, dob=2004-02-28, should be 16' # at t/db_dependent/Koha/Patrons.t line 814. # got: '15' # expected: '16' not ok 9 - Today=2020-02-28, dob=2002-02-28, should be 18 not ok 16 - Today=2020-02-29, dob=2004-02-29, should be 16 not ok 19 - Today=2020-03-01, dob=2002-03-01, should be 18 not ok 23 - Today=2020-03-01, dob=2004-03-01, should be 16 not ok 25 - Today=2019-01-31, dob=2001-01-31, should be 18 not ok 28 - Today=2019-01-31, dob=2003-01-31, should be 16 # Looks like you failed 7 tests of 31. not ok 18 - get_age # Subtest: is_valid_age not ok 2 - Today=2020-02-28, dob=2009-02-28, is 11, should be valid=0 in category AGE_5_10 # Failed test 'Today=2020-02-28, dob=2009-02-28, is 11, should be valid=0 in category AGE_5_10' # at t/db_dependent/Koha/Patrons.t line 893. # got: '1' # expected: '0' not ok 7 - Today=2020-02-28, dob=2015-02-28, is 5, should be valid=1 in category AGE_5_10 # Failed test 'Today=2020-02-28, dob=2015-02-28, is 5, should be valid=1 in category AGE_5_10' # at t/db_dependent/Koha/Patrons.t line 893. # got: '0' # expected: '1' # Looks like you failed 2 tests of 10. not ok 19 - is_valid_age Adding a tzset to UTC in the test as a workaround. Bug 25621 suggests patching DateUtils.pm as a definitive solution? -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 34446] New: Typo: Can be guarantee
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '23

17 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Bug ID: 34446 Summary: Typo: Can be guarantee Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The setting's label in administration > patron categories is missing a colon at the end: Can be guarantee: -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 34443] New: Spelling: Patron search pop-up Sort1: should be Sort 1:
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '23

17 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34443 Bug ID: 34443 Summary: Spelling: Patron search pop-up Sort1: should be Sort 1: Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The patron search pop-up (linking guarantors, adding roles to agreements) has 2 new search fields: * Sort1: * Sort2: Both should be relabelled to match with the normal patron form: * Sort 1: * Sort 2: It might also be nice to move them into a second column next to the other search options as currenlty they take up a lot of space in the small pop-up window. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 34748] New: wrong column name in Table settings in orders table
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '23

17 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34748 Bug ID: 34748 Summary: wrong column name in Table settings in orders table Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: noemie.labine(a)collecto.ca QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In the table settings, under Acquisition table, the first column of the orders table is basket_number. But in the table, in a basket, this column doesn't show the basket number but the order line. The name of this column should be order_line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 34653] New: Make koha-foreach return the correct status code
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '23

17 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34653 Bug ID: 34653 Summary: Make koha-foreach return the correct status code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: evan(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Hi Related to #33645 (and probably #25634), I notice that koha-foreach always returns 0 (success) even if the commands it tried to run failed. I think the correct behavior for this script should be that koha-foreach will return success if all the commands it tried to run succeeded, but failure if any of the commands failed. Test plan: 0) `koha-foreach /bin/true; echo $?` 1) Note that the exit status is 0 2) `koha-foreach /bin/false; echo $?` 3) Note that the exit status is 0 (incorrect) 4) Apply patch 5) `koha-foreach /bin/true; echo $?` 6) Note that the exit status is 0 7) `koha-foreach /bin/false; echo $?` 8) Note that the exit status is 1 (correct) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 34302] New: Checkin and renewal error messages disappear immediately in checkouts table
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '23

17 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34302 Bug ID: 34302 Summary: Checkin and renewal error messages disappear immediately in checkouts table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 28653 Since bug 28653, the checkouts table is automatically refreshed after checkin/renew. This prevents seeing error messages that are normally put inside this table. Steps to reproduce: 1. Apply the patch on bug 27249 2. Follow the test plan in bug 27249 comment 3 3. See that the table is automatically refreshed. You should see a message replace the checkbox for a few milliseconds, and then the message will be replaced by a checkbox. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653 [Bug 28653] Sorting loans by due date doesn't work after renewing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 34848] New: SIP/Message.t is failing if the DB has been upgraded
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '23

17 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 Bug ID: 34848 Summary: SIP/Message.t is failing if the DB has been upgraded Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 34841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34841 [Bug 34841] The test suite is failing is the DB has been upgraded -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 34843] New: Koha/Database/Commenter.t is failing if the DB has been upgraded
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '23

17 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34843 Bug ID: 34843 Summary: Koha/Database/Commenter.t is failing if the DB has been upgraded Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: m.de.rooy(a)rijksmuseum.nl Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 32334 Blocks: 34841 To recreate: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only kohadev-koha@kohadevbox:koha$ prove t/db_dependent/Koha/Database/Commenter.t t/db_dependent/Koha/Database/Commenter.t .. # Failed test 'No comment for toc_request' # at t/db_dependent/Koha/Database/Commenter.t line 40. # got: '0' # expected: '1' # Failed test 'Reset for one-columned article_requests' # at t/db_dependent/Koha/Database/Commenter.t line 55. # 'ALTER TABLE koha_kohadev.article_requests MODIFY COLUMN `cancellation_reason` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL; # ALTER TABLE koha_kohadev.article_requests MODIFY COLUMN `debit_id` int(11) DEFAULT NULL; # ALTER TABLE koha_kohadev.article_requests MODIFY COLUMN `toc_request` tinyint(4) NOT NULL DEFAULT 0 COMMENT 'borrower requested table of contents';' # doesn't match '(?^um:ALTER.*toc_request.*DEFAULT 0;(.*\n)+ALTER.*toc_request.*COMMENT.*$)' # Looks like you failed 2 tests of 9. t/db_dependent/Koha/Database/Commenter.t .. 1/2 # Failed test '->new, dry_run' # at t/db_dependent/Koha/Database/Commenter.t line 58. # Looks like you failed 1 test of 2. t/db_dependent/Koha/Database/Commenter.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 [Bug 32334] Sync comments in database with schema https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34841 [Bug 34841] The test suite is failing is the DB has been upgraded -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 34054] New: Allow to embed biblio on GET /items
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '23

17 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34054 Bug ID: 34054 Summary: Allow to embed biblio on GET /items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: REST API Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com CC: tomascohen(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 34846] New: SIP/ILS.t is failing if the DB has been upgraded
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '23

17 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34846 Bug ID: 34846 Summary: SIP/ILS.t is failing if the DB has been upgraded Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: a.roussos(a)dataly.gr Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 34258 Blocks: 34841 The number of renewals allowed needs to be mocked/set, or the tests are failing. To recreate: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only kohadev-koha@kohadevbox:koha$ prove t/db_dependent/SIP/ILS.t t/db_dependent/SIP/ILS.t .. 14/15 # Failed test 'Renewal succeeded' # at t/db_dependent/SIP/ILS.t line 346. # got: '0' # expected: '1' # Looks like you failed 1 test of 2. # Failed test 'renew' # at t/db_dependent/SIP/ILS.t line 348. # Looks like you failed 1 test of 15. $transaction->{screen_msg} contains "Item has reached maximum renewals". Please fix ASAP. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258 [Bug 34258] Cannot renew item via SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34841 [Bug 34841] The test suite is failing is the DB has been upgraded -- You are receiving this mail because: You are watching all bug changes.

1 13