September 2023 - Koha-bugs - lists.koha-community.org

[Bug 34217] New: Add missing cypress tests for vendors in agreements and licenses
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34217 Bug ID: 34217 Summary: Add missing cypress tests for vendors in agreements and licenses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: pedro.amorim(a)ptfs-europe.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, matt.blenkinsop(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com Bug 34206 made it evident we are missing tests for vendors in agreements and licenses. -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 34414] New: Remove DBD::Mock
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34414 Bug ID: 34414 Summary: Remove DBD::Mock Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Bug 33940 will remove t/Members/cardnumber.t that APPEARS to use a feature of DBD::Mock, i.e. filling $dbh->{mock_add_resultset}. But since the module is not loaded there (since ages), the whole thing is not even working! Simple illustration. Suppose you have borrower 50. Run update cardnumber='123456789' where borrowernumber=50; Now run t/Members/cardnumber.t not ok 3 - 123456789 is shorter than 10 # Failed test '123456789 is shorter than 10' # at t/Members/cardnumber.t line 36. # got: '1' # expected: '2' What happened? Instead of using the mocked empty set, checkcardnumber finds your 123456789 cardnumber in the database. Deception ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 34338] New: Cardnumbers should be trimmed before insertion
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34338 Bug ID: 34338 Summary: Cardnumbers should be trimmed before insertion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 33940 You can set cardnumber to NULL even if not allowed Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33940 [Bug 33940] Move get_cardnumber_length and checkcardnumber to Koha -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 33940] New: Move get_cardnumber_length and checkcardnumber to Koha
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33940 Bug ID: 33940 Summary: Move get_cardnumber_length and checkcardnumber to Koha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org C4::Members::get_cardnumber_length and C4::Members::checkcardnumber must be moved to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

1 45

[Bug 34228] New: Add translation context to "Managed by"
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34228 Bug ID: 34228 Summary: Add translation context to "Managed by" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr "Managed by" is used for both basket and purchase suggestions. In french, those two things have different genders, so "managed" is written differently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 34336] New: Can we get rid of Test::DBIx::Class?
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Bug ID: 34336 Summary: Can we get rid of Test::DBIx::Class? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org See 33833 Our use is limited. The tests are harder to read imo than the TestBuilder tests, but that could be a personal idea. Using the module may hide/oversimplify what we actually need. When removing the module somewhere, a constraint came up that was hidden by TDC but should be dealt with in the test. The module has a history of laborious installing but that is probably history. I opt for removing it in the few tests using it. What do you think? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27

[Bug 34812] New: Remove Test::DBIx::Class from Koha.t
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34812 Bug ID: 34812 Summary: Remove Test::DBIx::Class from Koha.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 34415] New: t/EdiTransport.t
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415 Bug ID: 34415 Summary: t/EdiTransport.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Remove Test::DBIx::Class -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 33924] New: Improve translation of title tags: Rotating collections
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33924 Bug ID: 33924 Summary: Improve translation of title tags: Rotating collections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 33906 This patch will modify rotating collections templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 33003] New: Show the vendor type description in supplier.pl
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33003 Bug ID: 33003 Summary: Show the vendor type description in supplier.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org Bug 31017 added a new vendor type field, where we can either enter a free text or add authorized values in the VENDOR_TYPE category to get a drop-down menu. When using the authorized values, we should show the authorized value description in supplier.pl. To test: 1. Add at least one authorized value in VENDOR_TYPE 1.1. Go to Administration > Authorized values 1.2. Search for VENDOR_TYPE 1.3. Click 'Add' 1.4. Fill out the form - Authorized value: BOOK - Description: Print books 1.5. Click 'Save' 2. Add a new vendor 2.1. Go to Acquisitions 2.2. Click 'New vendor' 2.3. Fill out the form - Name: ABC Bookstore - Vendor type: Print books 2.4. Click 'Save' 3. Go to the vendor page 3.1. Click on the vendor name --> The value in "Type" is BOOK, it should be "Print books" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23