November 2024 - Koha-bugs - lists.koha-community.org

[Bug 36797] New: Record with 1000+ holds and unique priorities causes a 500 error
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36797 Bug ID: 36797 Summary: Record with 1000+ holds and unique priorities causes a 500 error Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com To recreate: 1. Find a record that has 1000 non-waiting holds with different priorities. 2. Try loading the reserve page for that record ( /reserve/request.pl?biblionumber=X ) 4. Error: Template process failed: undef error - WHILE loop terminated (> 1000 iterations) This looks to be because of TT 'While' loop in holds_table.inc: [% BLOCK priority_dropdown %] [%- SET loop_priority = 1 -%] [%- WHILE loop_priority <= last_priority -%] [%- IF this_priority == loop_priority -%] <option value="[% loop_priority | html %]" selected="selected">[% loop_priority | html %]</option> [%- ELSE -%] <option value="[% loop_priority | html %]">[% loop_priority | html %]</option> [%- END -%] [%- loop_priority = loop_priority + 1- %] [%- END -%] [% END %] TT documentation states that it will terminate a WHILE loop larger than 1000 to prevent runaways: https://template-toolkit.org/docs/manual/Directives.html#section_WHILE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 35559] New: Can't change the pickup date of holds on the last day of expiration
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Bug ID: 35559 Summary: Can't change the pickup date of holds on the last day of expiration Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: stalkernoid(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Our libraries complained that the expiration date of holds awaiting pickup can no longer be changed on the last day of the pick-up period. In the previous version, it was possible. To reproduce the problem: 1) Create or use existing hold that is awaiting pickup. 2) Set it's expiration date to today. 3) Check that you can't change the expiration date anymore as it says "Expired: %date%" -- You are receiving this mail because: You are watching all bug changes.

1 37

[Bug 36482] New: Make it possible to embed desks and cash_registers on /libraries
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Bug ID: 36482 Summary: Make it possible to embed desks and cash_registers on /libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com CC: tomascohen(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 35

[Bug 36495] New: Add resource_not_found() and resource_deleted() helpers
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Bug ID: 36495 Summary: Add resource_not_found() and resource_deleted() helpers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com CC: tomascohen(a)gmail.com In order to get consistent in our response structures I propose to introduce a couple Mojolicious helpers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 48

[Bug 18885] New: Onsite Checkout has a weird behaviour concerning sticky due date
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885 Bug ID: 18885 Summary: Onsite Checkout has a weird behaviour concerning sticky due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: baptiste.wojtkowski(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you perform an onsite checkout, the next checkout is pre-setted as follows: - Specify due date => today - Onsite checkout => not checked I don't think this is is a correct behaviour: according to me there are 3 solutions, but I don't know which is the best: - Maintaining "onsite checkout" checked - Don't change duedatespec in interface when onsite checout is clicked and process it in the intranet part - Remove the duedatespec on the new checkout page loading This part of the code is really hard for me since it were patched and re patched and I'm not sure of the expected behaviour of all lines, so I would like some expert opinion before coding a solution -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 36459] New: Backdating checkouts on circ/circulation.pl not working properly
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Bug ID: 36459 Summary: Backdating checkouts on circ/circulation.pl not working properly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To recreate: 1. Go to circ/circulation.pl and check an item out to a patron. 2. Backdate it to sometime in the past using the "Specify due date (MM/DD/YYYY) : " input 3. A modal appears to "Please confirm checkout". The date is no longer populated in that field. 4. You must add the date again here. This is due to Bug 18885. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 36

[Bug 25560] New: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Bug ID: 25560 Summary: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: alexbuckley(a)catalyst.net.nz Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Currently the UpdateNotForLoanStatusOnCheckin syspref will update the items.notforloan value of ALL items checked in regardless of itemtype. It would be useful to be able to exclude specific itemtypes. This enhancement will add a checkbox 'Update not for loan status on check-in' to the administration item types page (Administration > Item types). When the UpdateNotForLoanStatusOnCheckin syspref contains content and this checkbox is unticked then that itemtype is excluded from having its items.notforloan changed upon checkin. -- You are receiving this mail because: You are watching all bug changes.

1 142

[Bug 36385] New: HTML escaped via JavaScript should encode all entities
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36385 Bug ID: 36385 Summary: HTML escaped via JavaScript should encode all entities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In staff-global.js, we have a function escape_str. This function only encodes a tiny subset of html characters. We should use https://github.com/mathiasbynens/he to encode the full set of html entities. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 36673] New: Limit search for used categories and item types to current branch
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36673 Bug ID: 36673 Summary: Limit search for used categories and item types to current branch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Bug 36447 limited the categories looped on the smart-rules page to those currently used - we can go a bit further and limit them to the current branch we are loading -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 36159] New: Patron imports record a change for non-text columns that are not in the import file
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159 Bug ID: 36159 Summary: Patron imports record a change for non-text columns that are not in the import file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When importing patrons we assume a default of '' for borrower columns not supplied in the file. When saving we compare the new object we built to the one form the database - for columns are that are not text type we get undef from the db and '' in the object we make. This means we see a difference and log into the BorrowersLog: "date_renewed" : { "after" : "", "before" : null }, "dateofbirth" : { "after" : "", "before" : null }, "debarred" : { "after" : "", "before" : null }, "flags" : { "after" : "", "before" : null }, "gonenoaddress" : { "after" : "", "before" : null }, "lost" : { "after" : "", "before" : null }, "password_expiration_date" : { "after" : "", "before" : null }, "sms_provider_id" : { "after" : "", "before" : null } } This can mean a lot of useless logging in sites that do automated imports -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 32