December 2024 - Koha-bugs - lists.koha-community.org

[Bug 37913] New: Remove more unreachable code in aqcontract.tt
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37913 Bug ID: 37913 Summary: Remove more unreachable code in aqcontract.tt Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Acquisitions Assignee: phil(a)chetcolibrary.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 37728 Bug 37823 removes one set of unreachable code from aqcontract.tt, a block that tried to tell you that you had created a new contract rather than just showing you the new contract, but there is another: When you delete a contract, what actually happens is that you are shown the details page for the vendor, which lists the contracts for that vendor at the bottom, thus showing you that the contract has been deleted, but the template has a block which thinks it is going to tell you "<h1>Contract deleted</h1>" and then have you click an OK button to POST a form with no op param starting with cud-, which now fails the CSRF protection. Luckily, it's unreachable (and has been since aqcontract.pl first landed, it has always redirected after deleting, and has never shown that block), but having it there still fails a test once bug 37728 lands and lets the test see it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 [Bug 37728] More "op" are missing in POSTed forms -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 38200] New: Remove dead code to delete authorities in authorities/authorities.pl
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Bug ID: 38200 Summary: Remove dead code to delete authorities in authorities/authorities.pl Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: phil(a)chetcolibrary.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org authorities/authorities.pl (the authority editor) has an op cud-delete. Hypothetically, it might have been run at some point before the template transition 13 years ago: somewhere between the initial commit of authorities support 20 years ago and then, the editor might have had a delete button that called it. Since then, it hasn't had one. You can see that it hasn't been run in the past 8 years by looking at the use block: before 8 years ago we had use C4::AuthoritiesMarc; but since then we've used specific exported things from it, never including DelAuthority. You might think it was used by deleting authorities in auth_finder.pl, a rather odd thing to have, but no: from the start, when it was auth_linker.pl, it has not had UI to delete. It did have the param nonav which it used to send people back to auth_linker after they created an authority, but since it was also passing myindex, the index of the bib field where auth_linker was supposed to put the results of its lookup, now the existence of that says it's an authority created from auth_finder and nonav is dead, too. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 38325] New: Cannot delete invoice while viewing it
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Bug ID: 38325 Summary: Cannot delete invoice while viewing it Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 36192 In the list of invoices in invoices.pl, an invoice that can be deleted (because nothing has ever been received into it) has a Delete action that uses submit-form-link and works with CSRF protection. In invoice.pl where you are viewing an individual invoice, the Delete link still thinks that invoice.pl?op=delete will work, which it won't. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 38734] New: Default notice templates should use preferred_name
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38734 Bug ID: 38734 Summary: Default notice templates should use preferred_name Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: emily.lamancusa(a)montgomerycountymd.gov QA Contact: testopia(a)bugs.koha-community.org Depends on: 28633 Default notice templates should be updated to use the preferred_name field, since that field was designed to override the first name (or stay identical to the first name if the field is hidden everywhere). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 [Bug 28633] Add a preferred name field to patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 38317] New: Support hiding preferred_name from patron modification screen on OPAC but not staff client (or vice versa)
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38317 Bug ID: 38317 Summary: Support hiding preferred_name from patron modification screen on OPAC but not staff client (or vice versa) Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: emily.lamancusa(a)montgomerycountymd.gov QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 28633 If preferred_name is hidden from either staff modification or patron self-modification, the firstname field will be copied into that field whenever edits to the patron are made from that screen. It's possible that a library may want to use the preferred_name field, but restrict editing either to patrons only or staff only for whatever reason. It would be nice to be able to hide preferred_name from one screen and not the other, without overwriting the preferred_name every time the patron account is edited from a screen where the field is hidden. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 [Bug 28633] Add a preferred_name field and an effective_name method to patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 30122] New: Display note fields in authority result list
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30122 Bug ID: 30122 Summary: Display note fields in authority result list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 35328] New: Add a notes pop-up for authority records to authority search results
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328 Bug ID: 35328 Summary: Add a notes pop-up for authority records to authority search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 38344] New: Dont send "Thank you !" as screen message
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38344 Bug ID: 38344 Summary: Dont send "Thank you !" as screen message Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org $ grep -rn "Thank you !" * C4/SIP/ILS.pm:317: return (1, 'Thank you !', ''); We should remove the space before the exclamation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 38742] New: C4::AuthoritiesMarc::merge should call ModBiblio only if really needed
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38742 Bug ID: 38742 Summary: C4::AuthoritiesMarc::merge should call ModBiblio only if really needed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: januszop(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Currently, the function C4::AuthoritiesMarc::merge calls ModBiblio for all bibliographic records linked to the modified authority record. It could seem a just behavior but we know that this could lead to performance problems. This is why AuthorityMergeLimit systempreference with merge_authorities.pl was introduced (earlier: dontmerge). Although this partially solves the performance problems, for moderately large and large catalogs (500+ K) and authority records linked with a large number of bibliographic records, performance problems still occur, even with overnight processing with merge_authorities.pl. This problem is particularly apparent when updating authority records from central databases, whose modifications are beyond our control. It turns out, however, that many such modifications to authority records involve fields other than the heading field (1XX in MARC 21), so these updates in fact do not modify bibliographic records. However, with the current merge function, every touch on an authority record forces a call to the ModBiblio function. The number of relatively expensive ModBiblio calls could be reduced by checking whether there has been an actual change in the field associated with the authority record. However, with IncludeSeeFromInSearches or IncludeSeeAlsoFromInSearches preferences enabled, the record should be refreshed in the search engine just in case (should the 4XX, 5XX fields have changed, which we don't know at this point). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 38743] New: Links to UNIMARC field manuals are broken
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38743 Bug ID: 38743 Summary: Links to UNIMARC field manuals are broken Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: baptiste.wojtkowski(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: aude.charillon(a)ptfs-europe.com, philip.orr(a)lmscloud.de In UNIMARC, links to IFLA are broken and referring to a very old version of MARC format. 502 function _UNIMARCFieldDoc(field) { 503 /* http://archive.ifla.org/VI/3/p1996-1/ is an outdated version of UNIMARC, but 504 seems to be the only version available that can be linked to per tag. More recent 505 versions of the UNIMARC standard are available on the IFLA website only as 506 PDFs! 507 */ 508 var url; 509 if (field == 0) { 510 url = "http://archive.ifla.org/VI/3/p1996-1/uni.htm"; 511 } else { 512 var first = field.substring(0,1); 513 url = "http://archive.ifla.org/VI/3/p1996-1/uni" + first + ".htm#"; 514 if (first == 0) url = url + "b"; 515 url = first == 9 516 ? "http://archive.ifla.org/VI/3/p1996-1/uni9.htm" 517 : url + field; 518 } 519 window.open(url); 520 } To my knowledge, there is no good solution to this pb : - According to the code and to my investigation, IFLA is not providing split files, field by field (except fields which have been updated after 2008, which can be accessed through the atomic updates) - transition-bibliographique.fr is providing such a work but only in french -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3