December 2024 - Koha-bugs - lists.koha-community.org

[Bug 38385] New: DB updates not displayed properly on the UI
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 Bug ID: 38385 Summary: DB updates not displayed properly on the UI Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: tomascohen(a)gmail.com 1. say_success, say_info, etc. show the span tags and are not colored 2. "Everything went okay" shown even if atomic updates failed 3. The same error can be displayed several time (see https://snipboard.io/IGiKgM.jpg) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #139 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- @Marcel de Rooy Hereafter my comments to all remarks from QA concerning the provided follow up :) > In the course of time, both module and tests have been modified quite a bit over these patches. I feel that it needs a squash. Do you agree? I think it has become necessary, hence, concerning my patch, feeld free > Please clarify this comment a bit further. It seems to be quite crucial here. I updated a few comments in the follow up > During the development it looks like both directions were examined, later on this was reverted again? Why is the check as we do now? I do not have access to the exact answer but since the info of the transferbranch is used by AddReturn, there is no very satisfying solution: - Either the transferbranch is calculated and transferred to CanBookBeReturned - Or the transferbranch is calculated twice > my $hbr = Koha::CirculationRules->get_return_branch_policy($item); > # get the proper branch to which to return the item > my $returnbranch = $hbr ne 'noreturn' ? $item->$hbr : $branch; > # if $hbr was "noreturn" or any other non-item table value, then it should 'float' (i.e. stay at this branch) > > [...] > > # check if the return is allowed at this branch > my ($returnallowed, $message) = CanBookBeReturned($item, $branch, $returnbranch); > > => Looks like we should not pass $returnbranch if it equals $branch, right? If both branches are equal, then the transfer is possible and passing $returnbranch has no impact. I don't think it is more clear or secure if we add a check before the call. > Would it be useful to include a test case for: > get_return_branch_policy > noreturn: do not return, let item remain where checked in (floating collections) > ? I added the tests, but we have to test addReturn, so I added it in a separate test :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #138 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Note: Had to rebase so setting it back to NSO -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #137 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175697&action=e… Bug 7376: (follow-up) Add tests on no_return Note: tests have to be performed on addReturn and have therefore been added in a separate test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #136 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175696&action=e… Bug 7376: Allow passing 'transferbranch' to CanBookBeReturned This patch adds the optional 'tranferbranch' parameter to the CanBookBeReturned routine. This allows for passing the correct 'ReturnToX' transfer to be tested at return time for transfer limit restrictions. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #135 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175695&action=e… Subject: [PATCH] Bug 7376: Clarify tests further We want to prevent returns where the item cannot be transfered 'back to where it came from (be that Homebranch or Holdingbranch as defined respectively in the circulation rules). This patch clarifies the tests further by testing this transfer functionality distinctly from the 'AllowReturnToBranch' preference functionality. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #134 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175694&action=e… Bug 7376: (follow-up) Fix C4/Circulation.pm This follow-up patch actually fixes the issue. This patch forbids a patron to return a book to a library from where the book may not return to its home or holding library. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #133 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175693&action=e… Bug 7376: (follow-up) Make extended tests mock the actual desired behaviour Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #132 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175692&action=e… Bug 7376: (follow-up) Extend test coverage and document I'm not sure about the requirements for this bug. This patch extends the tests to cover the new combinations introduced and highlights exactly what changes in the logic.. which appears to be fairly little. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #131 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175691&action=e… Bug 7376: Unit test Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0