February 2024 - Koha-bugs - lists.koha-community.org

[Bug 35949] New: Useless code pointing to branchreserves.pl in request.tt
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35949 Bug ID: 35949 Summary: Useless code pointing to branchreserves.pl in request.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Reports Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org 171 [% IF ( messagetransfert ) %] 172 <div class="dialog message"> 173 <h2>Hold found for ([% nextreservtitle | html %]), please transfer</h2> 174 <p>Hold placed by : <strong> [% nextreservsurname | html %] [% nextreservfirstname | html %]</strong> at : <strong> [% branchname | html %] </strong>, Please transfer this item. 175 </p> 176 <form name="cancelReservewithtransfert" action="branchreserves.pl" method="post"> 177 [% INCLUDE 'csrf-token.inc' %] 178 <input type="submit" class="button" /> 179 </form> 180 </div> 181 [% END %] messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist! -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 29033] New: Add C4::Context->multivalue_preference
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Bug ID: 29033 Summary: Add C4::Context->multivalue_preference Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org I've seen many places in which a syspref is read, and then split used to convert the contents into a list. It seems it would be simple to add a method to do that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 45

[Bug 23540] New: Gender 'N' is not translatable
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '24

18 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23540 Bug ID: 23540 Summary: Gender 'N' is not translatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: pasi.kallinen(a)koha-suomi.fi QA Contact: testopia(a)bugs.koha-community.org Patrons of type 'I' (institution) automatically get their sex/gender set to 'N' (which is short for "None"), but the 'N' is not translatable and actually shows up in the patron details page. Relevant code in memberentrygen.tt: [% IF ( I ) %]<input type="hidden" name="sex" value="N" />[% END %] The template code for showing the gender text should be unified into single included file, instead of spread over multiple places like: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: [% IF ( patron.sex == 'F' ) %]Female[% ELSIF ( patron.sex == 'M' ) %]Male[% ELSE %][% patron.sex | html %][% END %] koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt: [% IF ( patron.sex ) %]<li><span class="label">Gender:</span>[% IF ( patron.sex == 'F' ) %]Female[% ELSIF ( patron.sex == 'M' ) %]Male[% ELSE %][% patron.sex | html %][% END %]</li>[% END %] -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 21314] New: Koha enforces 3 character password length even if RequireStrongPassword is disabled
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '24

18 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Bug ID: 21314 Summary: Koha enforces 3 character password length even if RequireStrongPassword is disabled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 18298 added the option to enforce password complexity *if* the new system preference RequireStrongPassword is enabled. However, it appears that the code defining the minimum number of characters was not put under control of this preference and thus Koha enforces a minimum password length of 3 even if RequireStrongPassword is disabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 33262] New: When an ordered record is deleted, we lose all information on what was ordered
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '24

18 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Bug ID: 33262 Summary: When an ordered record is deleted, we lose all information on what was ordered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: clemens.tubach(a)kit.edu, michaela.sieber(a)kit.edu Blocks: 10758 I am moving this out from bug 10758 that was filed for the display issue. But that is actually only the symptom, while we are actually facing a data loss issue. Libraries need to be able to account for the money they spent even after the items and records have been removed from their collection. At the moment we lose the connection between order and bibliographic record when the record is deleted: -- -- Table structure for table `aqorders` -- DROP TABLE IF EXISTS `aqorders`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `aqorders` ( `ordernumber` int(11) NOT NULL AUTO_INCREMENT COMMENT 'primary key and unique identifier assigned by Koha to each line', `biblionumber` int(11) DEFAULT NULL COMMENT 'links the order to the biblio being ordered (biblio.biblionumber)', [...] CONSTRAINT `aqorders_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE SET NULL ON UPDATE CASCADE, We do have the information about the deleted record and the items, but we need to preserve the link between order and deleted record in some way. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 [Bug 10758] Show bibliographic information of deleted records in acquisitions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 47

[Bug 27679] New: The notices and slips management area should be moved to 'Administration'
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '24

18 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27679 Bug ID: 27679 Summary: The notices and slips management area should be moved to 'Administration' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org As the title says, the Notics and Slips "tool" isn't really a tool.. it's a system administration task.. so it should live under administration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 20657] New: Globally enable PRE_CHOMP and POST_CHOMP in Template Toolkit configuration
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '24

18 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20657 Bug ID: 20657 Summary: Globally enable PRE_CHOMP and POST_CHOMP in Template Toolkit configuration Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org As it currently stands, the HTML output by Template Toolkit includes whitespace anywhere there was a template tag. For example, this is a portion of the generated source of the staff client home page: 1 2 3 4 <!DOCTYPE html> 5  6 7 8 9 10 <html lang="en"> 11 <head> 12 13 <title>Koha staff client</title> Developer tools report: 26.69 KB / 5.83 KB transferred In contrast, this what the same content looks like with PRE_CHOMP and POST_CHOMP enabled: 1 <!DOCTYPE html> 2  3 <html lang="en"><head> 4 <title>Koha staff client</title> Developer tools report: 23.29 KB / 5.65 KB transferred In the samples I looked at this change did not make the HTML source significantly more difficult to read. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 19548] New: Search Result Second page not available
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '24

17 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548 Bug ID: 19548 Summary: Search Result Second page not available Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs(a)lists.koha-community.org Reporter: rainer.stowasser(a)zamg.ac.at QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl With the SRU/Z39.50 search using a quotation mark has the interesting effect that the first page of a result is displayed but a second page is not available. Looking at the pl source it seems that quotation marks are used and escaped for the first page but not for a second recall. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 31567] New: Onboarding stuck at "Cardnumber or Userid may already exist"
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '24

17 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31567 Bug ID: 31567 Summary: Onboarding stuck at "Cardnumber or Userid may already exist" Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I'm installing Koha 22.05.04-1 on Ubuntu 20.04.5, using the Debian packages. When I got to the "create a user" part of the onboarding I entered some made up user data and tried to save. This gave the message "The patron has not been created! Cardnumber or Userid may already exist." Tried with another cardnumber and userid, but got the same message. Checked the logs and saw this: ==> /var/log/koha/koha/intranet-error.log <== [Thu Sep 15 09:09:38.507240 2022] [cgi:error] [pid x] [client x.x.x.x:x] AH01215: {UNKNOWN}: Can't open /var/log/koha/koha/opac-error.log (Permission denied) at /usr/share/perl5/Log/Log4perl/Appender/File.pm line 151. at /usr/share/koha/lib/Koha/Patron.pm line 362: /usr/share/koha/intranet/cgi-bin/installer/onboarding.pl, referer: http://koha.example.com/cgi-bin/koha/installer/onboarding.pl Checked the permissions of the logs files: $ sudo ls -l /var/log/koha/koha/* -rw-r--r-- 1 koha-koha koha-koha 0 Sep 14 10:08 /var/log/koha/koha/indexer-error.log -rw-r--r-- 1 koha-koha koha-koha 3884632 Sep 15 08:43 /var/log/koha/koha/indexer-output.log -rw-r--r-- 1 root root 259998 Sep 15 09:09 /var/log/koha/koha/intranet-error.log -rw-r--r-- 1 root root 5465262 Sep 14 16:33 /var/log/koha/koha/opac-error.log -rw-rw-r-- 1 koha-koha koha-koha 0 Sep 15 06:25 /var/log/koha/koha/plack-api-error.log -rw-rw-r-- 1 koha-koha koha-koha 0 Sep 15 06:25 /var/log/koha/koha/plack-intranet-error.log -rw-rw-r-- 1 koha-koha koha-koha 0 Sep 15 06:25 /var/log/koha/koha/plack-opac-error.log -rw-rw-r-- 1 koha-koha koha-koha 0 Sep 15 06:25 /var/log/koha/koha/sip.log -rw-r--r-- 1 koha-koha koha-koha 0 Sep 14 10:08 /var/log/koha/koha/worker-error.log -rw-r--r-- 1 koha-koha koha-koha 258 Sep 14 10:08 /var/log/koha/koha/worker-output.log -rw-rw-r-- 1 koha-koha koha-koha 0 Sep 15 06:25 /var/log/koha/koha/z3950-error.log -rw-r--r-- 1 koha-koha koha-koha 0 Sep 14 10:08 /var/log/koha/koha/zebra-error.log -rw-r--r-- 1 koha-koha koha-koha 0 Sep 14 10:08 /var/log/koha/koha/zebra-output.log Changed the ownership of all logs: $ sudo chown koha-koha:koha-koha /var/log/koha/koha/* And now I could add the patron without any problems. Two problems here: - The ownership of the logs - The error message pointing in the wrong direction -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 31729] New: Enable automatic filesystem refresh in Plack
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '24

15 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Bug ID: 31729 Summary: Enable automatic filesystem refresh in Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtj(a)kohaaloha.com QA Contact: testopia(a)bugs.koha-community.org this patch adds an automatic filesystem refresh in Plack, patch uses the following module... https://metacpan.org/pod/Plack::Middleware::Refresh to test: 1/ start ktd 2/ add warn to about.pl file, loadpage, observe no output in log :( 3/ apply patch to /etc/koha/plack.psgi 4/ restart plack 5/ add warn to about.pl file, loadpage, observe output in log :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 73