March 2024 - Koha-bugs - lists.koha-community.org

[Bug 25790] New: [OMNIBUS] warnings removal
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Bug ID: 25790 Summary: [OMNIBUS] warnings removal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: nugged(a)gmail.com Reporter: nugged(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart(a)bugs.koha-community.org, slavashishkin(a)gmail.com, stalkernoid(a)gmail.com Depends on: 25440, 25491, 25506, 25533, 25695 This is an omnibus report to group tickets/tasks related to cleaning up of warnings, mostly now emitted in logs in various cases after "use warnings" added and also where something suspicious going on. Let's clean up our beautiful Universe from noise and potential bugs! <3 :P Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 [Bug 25491] Perl warning at the login page of installer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25506 [Bug 25506] Perl undef warning on the "About Koha" page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25533 [Bug 25533] Perl "not numeric" warning on the "Holds" page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25695 [Bug 25695] Missing logging of $@ in onboarding.pl after eval block -- You are receiving this mail because: You are watching all bug changes.

1 87

[Bug 31613] New: koha-z3950-responder doesn't log (apart from YAZ logging in theory)
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31613 Bug ID: 31613 Summary: koha-z3950-responder doesn't log (apart from YAZ logging in theory) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl While we pass a log file to koha-z3950-responder, that is just used by the YAZ toolkit. That's why issues like bug 28364 can't be seen. We're not logging what happens in the actual koha-3950-responder or its child processes. Most of the time that is fine... except when you have an error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 36191] New: Logs format should be consistent
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36191 Bug ID: 36191 Summary: Logs format should be consistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Koha logs are hard for tracking things. The main problem is they are inconsistent: api-error.log: [2022/07/06 12:01:26] indexer-error.log: 20240201 18:50:39 indexer-output.log -> NO DATE intranet-error.log.1 -> [Wed Feb 21 00:05:46.156462 2024] plack-api-error.log -> [2024/02/25 03:47:47] plack-error.log -> NO DATE plack-intranet-error.log -> [2024/02/25 15:17:15] plack.log -> 159.65.246.210 - - [25/Feb/2024:00:00:05 -0300] plack-opac-error.log -> [2024/02/25 00:12:27] sip.log -> NO DATE worker-error.log -> 20240201 18:50:29 worker-output.log -> no tiene fecha z3950-error.log -> [2024/01/23 15:21:58] z3950.log -> NO DATE zebra-error.log -> 20220222 16:10:50 zebra-output.log -> 22:15:17-18/09 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 16329] New: Koha::Logger->sql(). Unified interface to log SQL statements OR use DBIx::Log4perl
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16329 Bug ID: 16329 Summary: Koha::Logger->sql(). Unified interface to log SQL statements OR use DBIx::Log4perl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Instead of whenever needing to log SQL statements, making a custom logging output/function, introduce a centralized subroutine to handle all sql-statement logging. How the SQL-statements should be logged remains to be seen, but currently simply presenting very simple formatting we can discuss about. SQL libraries (DBI, DBIx) also allow logging SQL-statements but lack the fine-grained control Log4perl offers. Or maybe Log4perl can be integrated better to DBI / DBIx with this: https://metacpan.org/pod/DBIx::Log4perl Because I am not a huge fan of DBIx and also integrating that to Koha::Object is a lot of work, will not pursue that track further. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 16304] New: Koha::Logger, lazy load loggers so environment can be properly set.
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16304 Bug ID: 16304 Summary: Koha::Logger, lazy load loggers so environment can be properly set. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org If you instantiate Koha::Loggers before having set the C4::Context->interface, their interface defaults to 'opac'. This is rather undesired especially for 'commandline' scripts such as cronjobs. A solution to this is to lazyLoad loggers when they are really needed. LazyLoading might also have a performance boost when using packages that initialize a package-level logger but which never gets used. see t/Koha/Logger.t on how to replicate this issue, but here is a nutshell of how to replicate this issue: @@ file A.pm package A; use Koha::Logger; my $logger = Koha::Logger->get({category => __PACKAGE__}); #interface unknown sub doStuff { $logger->error('My interface is always "opac"'); } @@ script run.pl use C4::Context; C4::Context->interface('commandline'); use A; A::doStuff(); #error is logged using the "opac"-interface instead #of the "commandline"-interface -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 36164] New: Bring more consistency to our module landing pages
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Bug ID: 36164 Summary: Bring more consistency to our module landing pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Koha's modules have a variety of landing page designs. We should try to move to a more consistent approach across landing pages. This bug serves as a collector for such work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 35750] New: Add DataTables responsive plugin to staff interface
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35750 Bug ID: 35750 Summary: Add DataTables responsive plugin to staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The OPAC has the DataTables responsive plugin to deal with tables on smaller screen sizes. The staff interface should have the same. The holdings table is a good example of a table that does work well with smaller screens. To recreate: 1. Go to detail page and look at the holdings table 2. At about 1000px or less you will start to see the table run off the screen 3. Look at the holdings table on an OPAC detail page. The table responds to screen size. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 31916] New: It would be nice to make the paging in datatables and search results consistent
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31916 Bug ID: 31916 Summary: It would be nice to make the paging in datatables and search results consistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The paging UI is nice in the catalog search results.. it would be great to clone that styling to the general datatables paging? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 34358] New: Generalise library selection filter for datatables
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34358 Bug ID: 34358 Summary: Generalise library selection filter for datatables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com We add a custom library select option to the patron search results datatable. We should really generalise this away from the patron-search includes so it could be used on other ajax driven datatables with the header row filters enabled. We should support both 'data-filter="libraries"' at the table heading line definition and 'filter: "libraries"' in the datatable column settings definition level. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 23981] New: Inconsistencies with the different prices
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981 Bug ID: 23981 Summary: Inconsistencies with the different prices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org I was investigating bug 18639 and I came across some inconsistencies in the prices, where they are used, the calculations, etc. To reproduce : (Note: my vendor setting is "tax excluded" for both list and invoice price, I tried with different settings and as far as I can tell, the result is the same) 1- Create a new basket 2- Add an order 3- In the financial details, enter the following informations (I know it doesn't make sense IRL, but we are entering different prices just to see what goes where): - Vendor price: 10.99 - Tax rate: 0% - Discount: 0% - Retail price: 12.99 - Replacement cost: 15.99 - Actual cost: 18.99 4- Note that Budgeted cost and Total are based on *vendor* price (10.99) 5- Save your order 6- If you have access to your database, check the info that is entered (if you don't have access to your database, you can do an SQL report with the following query SELECT * from aqorders where basketno = X; Substitute de X for your basket number My db shows the following: listprice: 10.990000 unitprice: 18.990000 rrp: 12.99 replacementprice: 15.990000 rrp_tax_excluded: 12.990000 rrp_tax_included: 12.990000 ecost: 10.99 ecost_tax_excluded: 12.990000 ecost_tax_included: 12.990000 Note that the ecost_tax_excluded and ecost_tax_included are not based on ecost, but on rrp. 7- Go back to acquisitions home page and click on the amount ordered in your budget 8- Find your order and note that the estimated cost per unit is the retail price (12.99), not the vendor price (10.99) and not the budgeted cost as calculated during the order (10.99). 9- Close the basket 10- Receive the order 11- On the receipt summary page (which lists all the items yet to be received), the unit cost is the retail price (12.99) and the replacement cost is correct 12- On the item receiving page, the retail price is correct, the replacement price is correct, the budgeted cost is the retail price not the vendor price (listprice) nor the budgeted cost calculated during the order (ecost), the actual price is correct. 13- In the already received page, the prices are correct 14- In the "Spent column" of the budget, the price taken out of the fund is the actual price, which is correct. Summary: - The vendor price/listprice is not used anywhere else than during the first step of the order - The budgeted cost (ecost) is based on the retail price, the order form needs to reflect that Propositions: - Unless there is a good reason to keep it (like someone wanting to discriminate between how much the vendor sells it vs how much another vendor might sell it), I would remove the vendor price completely and replace it with the retail price - Correct the order form to show the real estimated price, based on the retail price - Correct the db calculations to make sure the ecost is based on the rrp and that the tax are calculated on the ecost I'm sorry if this is all over the place, hopefully by following the steps, you will see what I mean. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27