May 2024 - Koha-bugs - lists.koha-community.org

[Bug 36739] New: Unable to delete a budget
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '24

04 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36739 Bug ID: 36739 Summary: Unable to delete a budget Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org I'm unable to delete a budget that has no funds, even with superlibrarian privileges. To recreate: 1. Go to Administration > Budgets 2. Click New budget 3. Enter a start and end date, a name and an amount (For the test, I entered April 1st, 2024 to April 30, 2024, named the budget "April", and gave it an amount of 100) 4. Click Save 5. Go to Inactive budgets 6. Click Actions next to the budget and choose the Delete option 7. Click Yes, delete 8. Go to Inactive budgets --> The budget is still there -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 35062] New: addbiblio: Allow a framework plugin to add class to prevent submit during ajax call
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '24

04 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35062 Bug ID: 35062 Summary: addbiblio: Allow a framework plugin to add class to prevent submit during ajax call Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl I have a plugin that does a REST API call wrapped in an ajax construct: jQuery.ajax({ rest api stuff }).done(function() ...).fail(function() ...); Rapidly clicking Save (while the ajax is triggered by the Change event) lets the plugin shortly show an error before the form submits. Which is obviously undesirable. If we would replace this in addbiblio.tt: var onOption = function () { - return Check(); + if ( $('.plugin-blocks-submit').length==0 ) return Check(); } We can conditionally and temporarily block submittal. When the change event of the plugin fires, I add class plugin-no-submit to the html element involved. In the done and fail functions I remove the class again from the element. This effectively works. While several other approaches in addbiblio failed. (Removing the event handler is just too late.) This is a one-liner that will do the job. On bug 34860 I will still submit a ISBN/ISSN plugin using this class that will demonstrate its use. In the meantime this is a harmless check. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 36151] New: Update leaflet.js to current version
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '24

04 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Bug ID: 36151 Summary: Update leaflet.js to current version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: domm(a)plix.at QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Koha comes with leaflet.js 1.0.3 which is quite old. We need a current leaflet for Bug 31652, so we propose to upgrade to the current version 1.9.4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 31335] New: unnecessary holds fetch in serials/routing-preview.pl
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '24

04 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31335 Bug ID: 31335 Summary: unnecessary holds fetch in serials/routing-preview.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The following code is not needed. my $holds = $biblio->current_holds; my $count = $holds->count; while ( my $hold = $holds->next ) { $count-- if $hold->is_waiting; } -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 35783] New: Remove Koha::Template::Plugin::Biblio::RecallsCount
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '24

04 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Bug ID: 35783 Summary: Remove Koha::Template::Plugin::Biblio::RecallsCount Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 35781 RecallsCount must be replaced with biblio.recalls.search( completed => 0).count Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 35782] New: Remove Koha::Template::Plugin::Biblio::HoldsCount
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '24

04 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35782 Bug ID: 35782 Summary: Remove Koha::Template::Plugin::Biblio::HoldsCount Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 35781 HoldsCount must be replaced with biblio.holds.count Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove uneeded Koha::Template::Plugin methods -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 35788] New: Remove Koha::Template::Plugin::Biblio::BookingsCount
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '24

04 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Bug ID: 35788 Summary: Remove Koha::Template::Plugin::Biblio::BookingsCount Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 35787 Blocks: 35781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35787 [Bug 35787] Remove Koha::Template::Plugin::Biblio::CanBook -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 35789] New: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '24

04 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 Bug ID: 35789 Summary: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveC ount Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 35782 Blocks: 35781 Can be replaced with biblio.article_requests.filter_by_current.count Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35782 [Bug 35782] Remove Koha::Template::Plugin::Biblio::HoldsCount -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 35781] New: [omnibus] Remove uneeded Koha::Template::Plugin methods
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '24

04 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 Bug ID: 35781 Summary: [omnibus] Remove uneeded Koha::Template::Plugin methods Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Some of our methods (or even modules) in Koha::Template::Plugin are not needed and not a good pattern/practice to follow. Sometimes we need to use the Koha::Object passed to the template instead of using a TT template. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 35790] New: Remove Koha::Template::Plugin::Biblio::CanArticleRequest
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '24

04 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35790 Bug ID: 35790 Summary: Remove Koha::Template::Plugin::Biblio::CanArticleRequest Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 35789 It is no longer used anywhere. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35789 [Bug 35789] Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount -- You are receiving this mail because: You are watching all bug changes.

1 11