July 2024 - Koha-bugs - lists.koha-community.org

[Bug 29523] New: Add a way to prevent embedding objects that should not be allowed
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '24

23 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Bug ID: 29523 Summary: Add a way to prevent embedding objects that should not be allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com A user can be allowed to see only patrons from its own library, for example. So fetching (through the API) all the current checkouts for a biblio and embedding the patron each checkout in the response, could violate this rule (this is the case on bug 29275). We need some mechanism to prevent this at a lower level so controller developers don't need to code for that, and also to avoid unintended leaks. Possible implementations will need to standardize things like the one used in bug 29506, which relies on the existence of ->search_limited to filter out forbidden results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 225

[Bug 14250] Can generate discharge for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '24

23 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #6 from Theodoros Theodoropoulos <theod(a)lib.auth.gr> --- Please take some time to consider Jonathan's solution and rebase/fix this (serious) issue! It seems that original implementers of this feature believed that having a fine is not a blocking reason for issuing a discharge, but this concept should be reconsidered! Also, at the same time, additional lines will be required in discharge.tt to handle inability to issue a discharge because of pending fines. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 37431] New: A way to access the Plugin itself from a Mojolicious Controller
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '24

23 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37431 Bug ID: 37431 Summary: A way to access the Plugin itself from a Mojolicious Controller Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: tadeusz(a)sosnierz.com QA Contact: testopia(a)bugs.koha-community.org While a Koha::Plugin has handy builtins for configuration in the form of store_data() and retrieve_data(), these are not easily accessible from the Mojolicious controllers that we configure in `api_routes()`. My use case specifically is allowing the plugin users to configure an API key in the Plugin (using `configure()`), and then using that API key in the Mojolicious controller. The way to accomplish this currently is manually instantiating the plugin in the controller and using that for the lookup as so: `Koha::Plugin::MyOrg::MyPlugin->new->retrieve_data(...)` This does not feel like a good solution since it's hard to say how Koha will react to us instantiating a Plugin multiple times without reading the code. It seems harmless for now, but there's no guarantee that it won't break something in the future. Ideally I'd see the alternative as something akin to https://metacpan.org/pod/Mojolicious::Controller#app method which currently that gives us a Koha::REST::V1 instance. I'd like to have a `plugin()` available in there as well, so that I could do a `$c->plugin->retrieve_data()` in my routes. Not sure how an implementation of that would look; perhaps there are better alternatives? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 14250] Can generate discharge for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '24

23 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Theodoros Theodoropoulos <theod(a)lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod(a)lib.auth.gr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9596] Allow longoverdue.pl to be configured per library on the command line
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '24

23 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 --- Comment #15 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 169407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169407&action=e… Bug 9596: (QA follow-up) Only find a given patron once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 9596] Allow longoverdue.pl to be configured per library on the command line
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '24

23 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 --- Comment #14 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 169406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169406&action=e… Bug 9596: (QA follow-up) Add some clarifying comments Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 9596] Allow longoverdue.pl to be configured per library on the command line
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '24

23 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167343|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 169405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169405&action=e… Bug 9596: Add branch and skip-branch options to cronjobs/longoverdue.pl This script doesn't seem to be included in cron files by default. This change is to allow script parameters to effect only certain branches. This allows the script to be added multiple times to a cron file with different settings for different branches. Test plan: 1. apply patch 2. identify two books at different branches the same number of days overdue. 3. run the longoverdue.pl script specifying one of the branches in the --branch command line parameter. i.e. koha-shell -c 'misc/cronjobs/longoverdue.pl --branch branch_code --lost 60=2 --maxdays=61 --confirm' instance_name 4. observe that the book at the specified branch has been or would be affected by the script while the other book is not. Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz(a)sosnierz.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 9596] Allow longoverdue.pl to be configured per library on the command line
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '24

23 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13888] 'Lists' permission should allow/disallow using the lists module in staff
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '24

23 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #25 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Follow-up pushed, thanks Jake -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13888] 'Lists' permission should allow/disallow using the lists module in staff
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '24

23 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888 --- Comment #24 from Jake Deery <jake.deery(a)ptfs-europe.com> --- Created attachment 169394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169394&action=e… Bug 13888: (follow-up) fix tests for Virtualshelves This patch fixes failing tests resulting from oversight in the previous attachments I supplied to this bug number. -- You are receiving this mail because: You are watching all bug changes.

1 0