September 2024 - Koha-bugs - lists.koha-community.org

[Bug 8855] Link from receipt to invoice
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '24

02 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8855 --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I realize there was some confusion, this patch already has proper attribution. Please disregard the last comment. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '24

02 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 Jonathan Druart <jonathan.druart(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37807 --- Comment #47 from Jonathan Druart <jonathan.druart(a)gmail.com> --- (In reply to Jonathan Druart from comment #29) > (In reply to Jonathan Druart from comment #28) > > 2. > > # Failed test 'Update child to patron' > > # at t/db_dependent/selenium/update_child_to_adult.t line 153. > > Error while executing command: unexpected alert open: Dismissed user prompt > > dialog: Are you sure you want to update this child to an Adult category? > > This cannot be undone. at /usr/share/perl5/Selenium/Remote/Driver.pm line > > 411. > > > > This is happening because the "Update child to adult" item in the "More" > > menu (members module) is clickable. There is a tooltip and prior to this > > change the item was not clickable and we didn't get the alert. > > Related to this, it seems that the next entry "Export today's checked in > barcodes" is not shown and disabled when needed. We certainly want this > change: > > [% IF Koha.Preference('intranetreadinghistory') %] > - [%IF ( privacy == 2 ) %] > + [%IF ( patron.privacy == 2 ) %] Opened bug 37807. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37807 [Bug 37807] "Export today's checked in barcodes" not disabled when needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '24

02 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 --- Comment #46 from Jonathan Druart <jonathan.druart(a)gmail.com> --- (In reply to Jonathan Druart from comment #45) > It fixes the test but it is a change in the behaviour. Prior to this > patchset, beep was played. Now it's opening. > It happens because we have the modal in the DOM, and it has the > 'audio-alert-action' class. And opening is not played when it should: Turn on WaitingNotifyAtCheckout Place a hold and checkin barcode_1 (waiting hold) checkout barcode_2 => modal is displayed ("This patron has waiting holds"), but nothing played. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '24

02 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #32 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- (In reply to Katrin Fischer from comment #31) > As the both text blocks appear to be added by this patch set - could we > reuse the same text block for both, defined in one spot? Hum.. Yes I tried to focus on the change needed. I think the page needs a cleanup out from this scope. The business of the function was quite messy, with multiple variables containing the same information but for different purposes (for example has_issues and has_checkout do not have the same content according to the fact the user can or cannot be discharged). In a first while, we should probably use two different texts, one referring to the fact that the user cannot ask for a discharge and one referring to the fact that user's state has changed between the load of the page and the click on the discharge button (but tbh I don't know if anyone will see it). In a second while, I'll submit a separate patch to de-duplicate variables and clean the function itself. I think this will be easier to track the changes so. Does this solution looks fine for you ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '24

02 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 --- Comment #45 from Jonathan Druart <jonathan.druart(a)gmail.com> --- It fixes the test but it is a change in the behaviour. Prior to this patchset, beep was played. Now it's opening. It happens because we have the modal in the DOM, and it has the 'audio-alert-action' class. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '24

02 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #31 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- As the both text blocks appear to be added by this patch set - could we reuse the same text block for both, defined in one spot? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35374] New: Translations contain config from ERM/data providers
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '24

02 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Bug ID: 35374 Summary: Translations contain config from ERM/data providers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr, jonathan.druart+koha(a)gmail.com, matt.blenkinsop(a)ptfs-europe.com https://translate.koha-community.org/translate/koha/master/messages-js/de/?… This shouldn't appear in translations: return url }, getTableColumns() { const column_options = [ { used_by: ["title", "platform", "item", "database"], column: { title: __( this.data_type.charAt(0).toUpperCase() + this.data_type.slice(1) ), data: this.data_type, searchable: true, orderable: true, }, }, { used_by: ["item", "database", "platforms"], column: { title: "Platform", data: "platform", searchable: true, orderable: true, }, }, { used_by: ["title", "item", "database"], column: { title: "Publisher", data: "publisher", searchable: true, orderable: true, }, }, { used_by: ["title", "database"], column: { title: "Publisher ID", data: "publisher_id", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "DOI", data: "title_doi", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "Print ISSN", data: "print_issn", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "Online ISSN", data: "online_issn", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "URI", data: "title_uri", searchable: true, orderable: true, }, }, ] const columns = column_options .filter(column => column.used_by.includes(this.data_type)) .map(result => result.column) return columns }, }, mounted() { if (!this.building_table) { this.building_table = true this.getData() } }, props: ["data_type"], components: { KohaTable }, name: "UsageStatisticsProviderDataList", } </script> <style scoped> #title_list { display: table; } </style> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 8855] Link from receipt to invoice
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '24

02 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8855 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |katrin.fischer(a)bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thank you Jennifer! I have updated the patch in main to have your name and email address as set in Bugzilla: Author: Jennifer Sutton <jennifersutton(a)catalyst.net.nz> This is to make sure you get proper credit in release notes and on the dashboard and hopefully is OK with you! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 37581] New: Use split button for label creator "new" operations
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '24

02 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37581 Bug ID: 37581 Summary: Use split button for label creator "new" operations Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 37250 Created attachment 170102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170102&action=e… Gif showing the behavior of the new buttons Currently the toolbar shown on label creator pages is labeled "New" with a dropdown for all the options (New batch, new layout, etc.) I propose that we make this a split button where the default action of the button changes with the context: If you're on the "Label layouts" page for example, the button says "New label layout" and the secondary button triggers a dropdown with all the options. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 [Bug 37250] Redesign labels home page to match other module home pages -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 02 Sep '24

02 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #30 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- (In reply to Katrin Fischer from comment #26) > I think this will always show the note about checkouts: > > - [% ELSIF has_issues %] > - <p>You cannot be discharged, you have checked out > items. Please return items before asking for a discharge.</p> > + [% ELSIF failure %] > + <p>You cannot be discharged because you have > checked out items. Please return your checked out items before asking for a > discharge.</p> > + <ul> > + [% IF has_debt %] > + <li>You have unpaid charges. Please pay your > charges before reapplying.</li> > + [% END %] > + [% IF has_issues %] > + <li>You have checked out items. Please return > your checked out items before reapplying.</li> > + [% END %] > + [% IF !has_issue and !has_debt %] > + <li>You cannot be discharged for an unknown > reason. Please contact library staff for more information.</li> > + [% END %] > + </ul> > > I believe we should remove/rephrase the <p> line? If I understand well, these sentences have been rephrased here (https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170708&action=d…) right ? -- You are receiving this mail because: You are watching all bug changes.

1 0