October 2025 - Koha-bugs - lists.koha-community.org

[Bug 39152] New: Variables defined as `our` not tidied
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39152 Bug ID: 39152 Summary: Variables defined as `our` not tidied Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If you look at `tools/newHolidays` you will notice the file is not tidy. To reproduce: 1. Look at `tools/newHolidays` which is clearly not tidy 2. Run: $ ktd --shell k$ perl misc/devel/tidy.pl tools/newHolidays.pl k$ git diff => FAIL: No changes! 3. Replace `our` for `my` on the variable definitions 4. Repeat 2 => SUCCESS: The file is correctly tidied now! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 39087] New: Some files are uglier when tidy
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39087 Bug ID: 39087 Summary: Some files are uglier when tidy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.json.inc a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/* Not a big deal IMO as those files are wrong anyway (we should not build json or csv using TT) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 39084] New: Unnecessary spaces added by the tidy all work
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39084 Bug ID: 39084 Summary: Unnecessary spaces added by the tidy all work Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 Should not hurt but those can be removed: - <button class="btn btn-default dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false"> - <i class="fa fa-plus"></i> New authority - </button> + <button class="btn btn-default dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false"> <i class="fa fa-plus"></i> New authority </button> We don't need the space before the i tag. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 39085] New: No space preserved incorrecly after END
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39085 Bug ID: 39085 Summary: No space preserved incorrecly after END Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 The prettier plugin cannot guess if the absence of space was needed, so it got preserved. However in some cases it's not needed. Eg. koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt + [% END %]</li + > We could move the closing li on a separate line for better indentation and readability. Also the closing title almost everywhere: -[% END %]</title> If we don't want spaces we need to CHOMP List the candidates with `git grep -P 'END %][^\s|>|;|)|"|[]' **/*.tt` Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 39086] New: Lines incorrectly split
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39086 Bug ID: 39086 Summary: Lines incorrectly split Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 This is weird: koha-tmpl/intranet-tmpl/prog/en/includes/filter-orders.inc - <li><label for="from">From: </label> + <li + ><label for="from">From: </label> <input type="text" size="10" id="from" name="from" value="[% filters.from_placed_on | html %]" class="flatpickr" data-date_to="to" /> <div class="hint">[% INCLUDE 'date-format.inc' %]</div> </li> - <li><label for="to">To: </label> + <li + ><label for="to">To: </label> Why aren't they kept on the same line? I didn't find many occurrences. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 38952] New: JS function messenger not used in acq.js
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Bug ID: 38952 Summary: JS function messenger not used in acq.js Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/js/acq.js 166 function messenger(X,Y,etc){ // FIXME: unused? 167 win=window.open("","mess","height="+X+",width="+Y+",screenX=150,screenY=0"); 168 win.focus(); 169 win.document.close(); 170 win.document.write("<body link='#333333' bgcolor='#ffffff' text='#000000'><font size='2'><p><br />"); 171 win.document.write(etc); 172 win.document.write("<center><form><input type=button onclick='self.close()' value='Close'></form></center>"); 173 win.document.write("</font></body></html>"); 174 } % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/intranet-tmpl/prog/js/acq.js koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 39149] New: .PL files not tidy
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39149 Bug ID: 39149 Summary: .PL files not tidy Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Somehow we missed we have `.PL` files in the codebase. They are not considered in `tidy.pl` and remain untidy. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 39324] New: [OMNIBUS] All QA tests should pass
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39324 Bug ID: 39324 Summary: [OMNIBUS] All QA tests should pass Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Currently we have the QA script (qa-test-tools) running the tests before and after the patches we are testing. Then we compare the results and raise errors in case of new introduced errors. It is causing several problems: 1. Bad detection of deleted/moved files 2. False positives and some errors we don't catch 3. It is slow to run, especially because of the git manipulation (switch of branches) Ideally we need the tests to pass on the whole codebase, so we just need to run the tests on the file modified by the patchset. This is an omnibus bug in order to track the different steps we need to make the tests pass on the whole codebase, before being able to adjust the QA script. See also https://gitlab.com/koha-community/qa-test-tools/-/issues/93 -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 39835] New: Tidy is_boolean / tinyint
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39835 Bug ID: 39835 Summary: Tidy is_boolean / tinyint Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 39324 We have a test in the QA script to catch missing "is_boolean" in the schema if the column is a tinyint(1)/boolean. We need to add it to all the attributes, so the new version of the script can know if something is missing. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39324 [Bug 39324] [OMNIBUS] All QA tests should pass -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 31345] New: Add ability to exit process_message_queue.pl early if any plugin before_send_messages hook fails
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345 Bug ID: 31345 Summary: Add ability to exit process_message_queue.pl early if any plugin before_send_messages hook fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Sometimes it would be better for process_message_queue.pl to stop if a plugin hook fails rather than continue processing. It would be nice if that was a command line option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25