- Koha-bugs - lists.koha-community.org

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '25

23 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181343|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '25

23 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #69 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 181363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181363&action=e… Bug 9762: (QA follow-up) Remove superflous string construction We never actually pass `$message` back to anywhere so there's no reason to create it in the first place. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '25

23 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #68 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 181362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181362&action=e… Bug 9762: (QA follow-up) Fix failing test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '25

23 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181346|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 181361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181361&action=e… Bug 9762: (QA follow-up) Add missing issueconfirmed check -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '25

23 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #66 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 181360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181360&action=e… Bug 9762: (QA follow-up) Fix executable bit -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '25

23 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181342|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 181359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181359&action=e… Bug 9762: Test CanBookBeIssued.pm To test: 1) Apply the patch 2) run prove t/db_dependent/Circulation/CanBookBeIssued.t --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") Bug 9762: change permission -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '25

23 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181341|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 181358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181358&action=e… Bug 9762: Change how to pass the param -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '25

23 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181340|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 181357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181357&action=e… Bug 9762: Log circulation overrides This patch allows you to save commands that have been overridden by someone. The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17 are still not functional. Tests 15 and 16 need to be fixed as they do not display the barcode. All other tests should be functional. To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '25

23 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #62 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Comment on attachment 181340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181340 Bug 9762: Log circulation overrides Review of attachment 181340: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=976…) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +832,4 @@ > my $circ_library = Koha::Libraries->find( _GetCircControlBranch( $item_object, $patron ) ); > > my $now = dt_from_string(); > + my $message; I don't see `$message` passed anywhere.. we seem to construct what could be a huge concatenated string below, but then never output it anywhere. We also have this on line 1822: `my ( $allowed, $message ) = CanBookBeReturned( $item_unblessed, C4::Context->userenv->{branch} );` This will overwrite whatever was in $message above.. and it's intended to just be a branchcode passed back in that case. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '25

23 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 181346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181346&action=e… Bug 9762: (QA follow-up) Add missing issueconfirmed check -- You are receiving this mail because: You are watching all bug changes.

1 0