- Koha-bugs - lists.koha-community.org

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '25

03 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180072|0 |1 is obsolete| | --- Comment #155 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 180593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180593&action=e… Bug 7376: (follow-up) Make extended tests mock the actual desired behaviour Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '25

03 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180071|0 |1 is obsolete| | --- Comment #154 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 180592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180592&action=e… Bug 7376: (follow-up) Extend test coverage and document I'm not sure about the requirements for this bug. This patch extends the tests to cover the new combinations introduced and highlights exactly what changes in the logic.. which appears to be fairly little. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '25

03 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180070|0 |1 is obsolete| | --- Comment #153 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 180591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180591&action=e… Bug 7376: Unit test Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '25

03 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180069|0 |1 is obsolete| | --- Comment #152 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 180590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180590&action=e… Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) TEST PLAN: Note: older signoffs did not validate this test plan Considering you use a ktd-like database. Log in at centerville Allow transfers between centerville, Midway and Franklin, don't allow transfers between Fairfield, Liberty and all other libraries. In addition, allow the transfer between Liberty and Midway Transfer as much books as you can from Centerville to Midway. Log in as Midway, check out as many books from Centerville as you can to Henry Acevedo. If you don't have enough books during the test plan, feel free to check out books again. During the whole test, without further precision, items checkout out in such conditions should be checked in. You will also need 6 checked out floating books at midway Note: '-> ok' means the checkin is allowed '-> not ok' means the checkin is not allowed Apply patch I - Test AllowReturnToBranch During this part of the test plan, you want to have all following configuration : 'CircControlReturnsBranch' -> 'The library the item is checked in at' In CIRC rules: 'Default holds policy and return policy' -> 'Item returns home' (make sure you have no other holds policy on any library) 'AllowReturnToBranch' -> as follows 1 - Set to "Either at the library the item is from or at the library the item was checked out from" X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> not ok X d - Check in to Fairfield -> not ok 2 - Set to "Only at the library the item was checked out from" X a - Check in to Centerville -> not ok X b - Check in to Midway -> ok X c - Check in to Franklin -> not ok X d - Check in to Fairfield -> not ok 3 - Set to "Only at the library the item is from" X a - Check in to Centerville -> ok X b - Check in to Midway -> not ok X c - Check in to Franklin -> not ok X d - Check in to Fairfield -> not ok 4 - Set to "Any library" X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok II - Transfer and check out 6 floating items at midway. 1 - X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> ok 2 - Set 'AllowReturnToBranch' to 'home library' X a - Check in to Centerville -> ok X b - Check in to Midway -> not ok III - Pathological & asymetrical cases. During this part of the test plan, you want to have all following configuration : 'CircControlReturnsBranch' -> 'The library the item is checked in at' 'Default holds policy and return policy' -> 'Item returns home' (make sure you have no other holds policy on any library) 'AllowReturnToBranch' -> 'Any library' FOR THIS PART OF THE TESTS ONLY (until IV): Don't allow tranfers from midway to centerville, but allow from centerville to midway X 1 - Check in a book at midway -> not ok Set 'Default holds policy and return policy' -> 'Item returns to issuing library' X 2 - Check in a book at centerville -> ok FOR THIS PART OF THE TESTS ONLY (until IV): Don't allow tranfers from centerville to midway X 3 - Check in a book at centerville -> not ok X 4 - Set 'AllowReturnToBranch' to "Only at the library the item was checked out from" X a - check in to Centerville -> not ok X b - check in to Midway -> not ok IV - Test 'CircControlReturnsBranch' (remove the precedent transfer restriction) During this part of the test plan, you want to have all following configuration : 'Default holds policy and return policy' -> 'Item returns home' (unchanged) 'Default checkout, hold and return policy for Midway' -> 'Item returns to issuing library' 'Default checkout, hold and return policy for Franklin' -> 'Item floats' 'Default checkout, hold and return policy for Fairfield' -> 'Item returns to issuing library' 'Default checkout, hold and return policy for Liberty' -> 'Item returns home' 'AllowReturnToBranch' -> "Any library" (unchanged) 'CircControlReturnsBranch' -> as follows 1 - 'The library the item is checked in at' X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok X e - Check in to Liberty -> not ok 2 - 'The library the current item is held by X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok X e - Check in to Liberty -> ok 3 - 'the library the item is owned by' X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok X e - Check in to Liberty -> not ok Sponsored-by: National Library of Finland Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 39551] New: Handle diffs between Elasticsearch mappings.yml and DB/UI
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '25

03 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39551 Bug ID: 39551 Summary: Handle diffs between Elasticsearch mappings.yml and DB/UI Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: domm(a)plix.at QA Contact: testopia(a)bugs.koha-community.org As discussed on the Koha Hackfest 2025: * Show diffs between mappings.yml and DB values * reconcile mappings against file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 35613] New: Migrate spec to OpenAPI v3
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '25

03 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35613 Bug ID: 35613 Summary: Migrate spec to OpenAPI v3 Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com CC: tomascohen(a)gmail.com Things to do: - Convert our spec into OpenAPIv3 (probably using redocly) - Migrate array types ("type" and "null") into using the "nullable": true provided attribute - Verify no regressions found - Report potential issues to https://github.com/jhthorsen/mojolicious-plugin-openapi - Split the bundled spec into pieces as we have now. - The generated api.koha-community.org documentation needs to be at least the same in terms of information and usability. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 37424] New: Batch checkout silently fails if item contains materials specified (952$3)
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '25

03 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Bug ID: 37424 Summary: Batch checkout silently fails if item contains materials specified (952$3) Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: catrina(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 169379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169379&action=e… Screenshot where the 952$3 should display As noted in 15718 and 23780, when using the batch checkout feature, there’s no preview of the 952$3 in the confirm checkout screen to let you know why the checkout needs confirmation, but also the checkout silently fails even when selecting "Checkout or renew". It sounded most similar to 30995, but my user has the force_checkout permission, so that doesn’t apply. Test plan: 1. Set a staff member with circ permissions, including FORCE_CHECKOUT 2. Turn on: CircConfirmItemParts, BatchCheckouts, BatchCheckoutsValidCategories (all) 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 from the batch checkout tab 5. The item with a 952$3 displays, but the copy/text of the materials specified note does not. 6. When you select “Checkout or renew,” you are taken back to the batch check out screen, but the item with the 952$3 is NOT checked out to the patron, nor are you given any warning that an error occurred. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 23780] New: Batch check out fails to inform or trap
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '25

03 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780 Bug ID: 23780 Summary: Batch check out fails to inform or trap Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I have managed to catch failures in Batch check out on the following scenario: Patron has fines over the allowed limit. Item type only allows 5 check outs. When checking out 6 of this item type, Batch check out failed to: * Show any information that the patron had reached fine limit * Show that the patron was checking out too many of this item type If I checked out these 6 items without the fine, it gives the warning about too many items and asks me to confirm. If I check out 5 of these items with the fine, it does not explain why I need to confirm. It seems that Batch check out: * Is not displaying a reason for confirmation with the fine block. * Is not displaying a reason for confirmation when there are multiple blocks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 37396] New: Batch checkout does not checkout items if OverduesBlockCirc set to Ask for Confirmation
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '25

03 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37396 Bug ID: 37396 Summary: Batch checkout does not checkout items if OverduesBlockCirc set to Ask for Confirmation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P4 Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: Laura.escamilla(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 23780 To test: 1. Set the system preference 'OverduesBlockCirc' to 'Ask for Confirmation' 2. Enable the BatchCheckout system preference 3. Checkout an item to a patron and backdate the due date so that it is overdue. 4. Attempt to checkout an item or a set of items using the Batch Checkout feature. The batch checkout page will ask you to confirm the checkouts because the 'Patron has 1 overdue item'. 5. Confirm the checkout and go to the patron's holdings table. The items you checked out via the batch checkout were not issued to the patron. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780 [Bug 23780] Batch check out fails to inform or trap -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 15279] Deprecate bespoke syntax for Slips and Notices
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '25

03 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 Bug 15279 depends on bug 36815, which changed state. Bug 36815 Summary: Add the option to 'Reset to default' in the notices editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36815 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0