- Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #491 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 183915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183915&action=e… Bug 15516: (follow-up) Fix some merge bugs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #490 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #488) > (In reply to Pedro Amorim from comment #486) > > - Staff: Hold group modal (when clicking the "(part of a hold group link)") > > contains out of date UI elements styling > > How do you mean? (I'll take a look at other modals for inspiration while I > wait to hear back.) I'm comparing "koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc" to the modals in "koha-tmpl/intranet-tmpl/prog/en/includes/modals". Unfortunately, not sure what you mean here. > > - Staff: Hold group modal 'x' and 'close' button don't work. > > Yep, known issue. I'll look at fixing that. Fixed in next patch upload. > > - Staff: After the above, when visiting the holds queue page, I get a 500 > > error with the following entry on the logs: > > # Not an ARRAY reference at /kohadevbox/koha/circ/view_holdsqueue.pl line 58. > > Yep known issue. (It works locally so I'll have to investigate why it works > locally. ) Locally, we've just removed support for "(part of a hold group link)" in http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl because the table there is from the tmp_holdsqueue table and hold_group_id is not a column in that table. I'm going to do the same thing in the next patch upload, but this might need a better solution. In practice, the lack of support here hasn't been an issue for the library using this feature. > > - OPAC: Using koha:koha user in ktd, when creating a hold group from the > > OPAC, following the "Gairm" and "Clean code" example, I get the following > > error message: > > # One or more holds were not placed due to following errors: You have > > exceeded the number of concurrent holds for this record > > But if I place both holds without ticking the 'treat as hold group' > > checkbox, both holds are correctly placed. > > I was unable to follow the rest of the OPAC test plan. Fixed in next patch upload. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #489 from David Cook <dcook(a)prosentient.com.au> --- Additional note: 1. At http://localhost:8080/cgi-bin/koha/opac-user.pl?&opac-user-holds=1 if you click on "(part of a hold group)" it doesn't open in a modal. It just shows in the "Title" table cell which looks weird. I guess this isn't a bug so much as a suboptimal part of the feature. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #488 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Pedro Amorim from comment #486) > - Staff: Hold group modal (when clicking the "(part of a hold group link)") > contains out of date UI elements styling How do you mean? (I'll take a look at other modals for inspiration while I wait to hear back.) > - Staff: Hold group modal 'x' and 'close' button don't work. Yep, known issue. I'll look at fixing that. > - Staff: Created a hold group searching 'music' and picking 1st and 3rd > records. After checking in one item of a hold group and confirming, the item > became in transit, the other hold was not deleted (I would expect it to be > deleted as per the test plan) I'm not able to reproduce this. I thought that I did reproduce it... but it was just because I forgot to checkbox the "hold group" box. > - Staff: After the above, when visiting the holds queue page, I get a 500 > error with the following entry on the logs: > # Not an ARRAY reference at /kohadevbox/koha/circ/view_holdsqueue.pl line 58. Yep known issue. (It works locally so I'll have to investigate why it works locally. ) > - OPAC: Using koha:koha user in ktd, when creating a hold group from the > OPAC, following the "Gairm" and "Clean code" example, I get the following > error message: > # One or more holds were not placed due to following errors: You have > exceeded the number of concurrent holds for this record > But if I place both holds without ticking the 'treat as hold group' > checkbox, both holds are correctly placed. > I was unable to follow the rest of the OPAC test plan. Ok I've reproduced this. It's one of those examples of something I've fixed locally in production but hadn't fixed in the Bugzilla patches... I'll get that fixed. Simple fix. > - Staff: As above, when doing the same exercise on Staff UI, only 'Clean > code' hold goes through, 'Gairm' hold is never created. No error message > shown. This is very weird. I just re-tried the test plan again and it worked for both the OPAC and Staff interface. Are you sure that you applied the patch, updated the schema, and restarted your Starman? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #487 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Pedro Amorim from comment #486) > As stated above by Andrew Fuerste-Henry, we have a project to develop this > functionality into Koha, some of the requirements overlap with what we > already have here, but others differ, namely: > - 'Hold groups' are referred to as 'HyperHolds'. This is but a naming > divergence but possibly worth considering adopting as the naming of 'hold > groups' already exist in Koha as stated by > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516#c275 > - Only Staff members are able to create hold groups - This may be addressed > by updating the DisplayAddHoldGroups sys pref to 'OPAC', 'Staff', 'OPAC and > Staff', 'Disabled' > - The creation of a hold group must be possible from the list of existing > holds in a patron record page - I believe the idea here is a patron may > place holds on multiple similar biblios without necessarily creating a > 'group hold' themselves. Staff members are then able to group said existing > holds together. From my understanding this is not possible with the current > implementation. The current implementation only considers the creation of a > group hold directly from the search results. > - Holds remain counted separately for circ rule limits - This could possibly > be addressed by a new 'Default hold groups policy' where one would be able > to set 'A hold group is considered a single hold for circulation rules hold > limits purposes'. If 'Yes', hold groups are treated as single holds for circ > rules limit purposes, otherwise hold groups are ignored and each individual > hold is considered for circ rules limit purposes. > - Patron record page, 'Holds' tab, instead of having the '(part of a hold > group)' link next to the hold title, have a new 'hold group' column that > displays the hold group id, which can be sorted ASC or DESC. > - The hold group (hold_groups table) also contains expiration date, future > hold date, pickup location, suspension and changes made to the hold group > reflect to the holds contained in it > - REST API endpoints for hold groups CRUD is required > > All of these (and others) I intend to do in follow-up bugs, but keeping > within the community spirit, it would most definitely be more productive to > first help move this patchset along, especially given the amount of interest > and time already invested here given that this is, at the very least, the > base of the functionality that we now require for the project. This sounds good to me! Very compatible with what we've got here (and locally). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 40224] New: Replace use of location.href with POST logout form
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40224 Bug ID: 40224 Summary: Replace use of location.href with POST logout form Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The self-check module should use use POST for logouts instead of GET. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #486 from Pedro Amorim <pedro.amorim(a)openfifth.co.uk> --- Thank you David. My preliminary testing notes of this patchset (some/all of it confirm bugs you've already outline): - Staff: Hold group modal (when clicking the "(part of a hold group link)") contains out of date UI elements styling - Staff: Hold group modal 'x' and 'close' button don't work. - Staff: Created a hold group searching 'music' and picking 1st and 3rd records. After checking in one item of a hold group and confirming, the item became in transit, the other hold was not deleted (I would expect it to be deleted as per the test plan) - Staff: After the above, when visiting the holds queue page, I get a 500 error with the following entry on the logs: # Not an ARRAY reference at /kohadevbox/koha/circ/view_holdsqueue.pl line 58. - OPAC: Using koha:koha user in ktd, when creating a hold group from the OPAC, following the "Gairm" and "Clean code" example, I get the following error message: # One or more holds were not placed due to following errors: You have exceeded the number of concurrent holds for this record But if I place both holds without ticking the 'treat as hold group' checkbox, both holds are correctly placed. I was unable to follow the rest of the OPAC test plan. - Staff: As above, when doing the same exercise on Staff UI, only 'Clean code' hold goes through, 'Gairm' hold is never created. No error message shown. ----------------------- As stated above by Andrew Fuerste-Henry, we have a project to develop this functionality into Koha, some of the requirements overlap with what we already have here, but others differ, namely: - 'Hold groups' are referred to as 'HyperHolds'. This is but a naming divergence but possibly worth considering adopting as the naming of 'hold groups' already exist in Koha as stated by https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516#c275 - Only Staff members are able to create hold groups - This may be addressed by updating the DisplayAddHoldGroups sys pref to 'OPAC', 'Staff', 'OPAC and Staff', 'Disabled' - The creation of a hold group must be possible from the list of existing holds in a patron record page - I believe the idea here is a patron may place holds on multiple similar biblios without necessarily creating a 'group hold' themselves. Staff members are then able to group said existing holds together. >From my understanding this is not possible with the current implementation. The current implementation only considers the creation of a group hold directly from the search results. - Holds remain counted separately for circ rule limits - This could possibly be addressed by a new 'Default hold groups policy' where one would be able to set 'A hold group is considered a single hold for circulation rules hold limits purposes'. If 'Yes', hold groups are treated as single holds for circ rules limit purposes, otherwise hold groups are ignored and each individual hold is considered for circ rules limit purposes. - Patron record page, 'Holds' tab, instead of having the '(part of a hold group)' link next to the hold title, have a new 'hold group' column that displays the hold group id, which can be sorted ASC or DESC. - The hold group (hold_groups table) also contains expiration date, future hold date, pickup location, suspension and changes made to the hold group reflect to the holds contained in it - REST API endpoints for hold groups CRUD is required All of these (and others) I intend to do in follow-up bugs, but keeping within the community spirit, it would most definitely be more productive to first help move this patchset along, especially given the amount of interest and time already invested here given that this is, at the very least, the base of the functionality that we now require for the project. I'm in contact with David through DMs in MatterMost and want to help move this forward. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #485 from David Cook <dcook(a)prosentient.com.au> --- I've rebased the patches, fixed some obvious typos and bugs, and in "My upstream Koha test plan" I make a note of some things that are broken in the rebased version. Overall, the test plans seems to be working (although I think there are also some subtle bugs with hold limits from circ rules). As noted in the test plan, I have additional code that I run locally, so I still have work to do... -- In theory, locally (NOT with the attached above patches), I should be able to do the following with 15516+15565: OPAC: 15565 - Detail page: can place multiple item holds - Results page: can place multiple item holds for multiple records 15516 - Detail page: can place "group hold" using multiple items from 1 bib - Result page: you can place "treat as hold group" group holds across multiple bibs at bib-level or item-level - User page: See "(part of a hold group)", clicking text shows list of barcodes or bib numbers (if bib-level hold) with links to bib records Staff Interface: 15565 - Detail page: can place multiple item holds - Results page: you can't place multiple item holds across different bibs 15516 - Detail page: you can tick multiple specific items and click "Treat as hold group" - Results page: you can place "next available" bib-level group holds across multiple bibs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #484 from David Cook <dcook(a)prosentient.com.au> --- My upstream Koha test plan: __Setup__ 0. koha-upgrade-schema kohadev 1. koha-plack --restart kohadev 2. prove t/db_dependent/Koha/Holds.t t/db_dependent/Reserves/HoldGroup.t 3. Enable "DisplayAddHoldGroups" system preference __OPAC results__ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search… 2. Checkbox results "Gairm" and "Clean code" 3. Click "Place hold" at the top of the search results 4. Checkbox "Treat as hold group (next available item fulfills all holds)" 5. Click "Confirm hold" 6. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 7. Click "Holds" 8. Confirm the two holds appear with the text "part of a hold group", and when you click on that text it shows you both hold group titles 9. Note the "Holds" tab shows 1 hold signifying the 2 holds in the hold group count as 1 hold total NOTE: Currently, within the table it says "Holds (2 total)" as there are 2 hold rows... 10. In the staff interface, check in "39999000001310" 11. Click "Confirm hold (Y)" 12. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 13. Note only 1 hold appears, and when you click on "part of a hold group" it only shows 1 hold title FIXME: The modal close buttons are currently broken FIXME: The modal also doesn't look quite right... 12. In the OPAC, go to http://localhost:8080/cgi-bin/koha/opac-user.pl 13. Note that only 1 hold appears now 14. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 15. Cancel the hold __Staff interface results__ 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2. Checkbox results "Gairm" and "Clean code" 3. Click "Place hold" at the top of the search results 4. Search for patron "koha" and choose the one with card 42 5. Check box "Treat as hold group" 6. Choose "Centerville" as "Pickup location" NOTE: Trying to choose "Pickup at" doesn't seem to work. You have to specify individual "Pickup location" 7. Click "Place holds" 8. Click on "part of a hold group" on the each hold and note the modal with "Hold group" appears showing the 2 titles FIXME: The modal close buttons are currently broken FIXME: The modal also doesn't look quite right... 9. Check in "39999000001310" 10. Click "Confirm hold (Y)" 11. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 12. Cancel the hold __OPAC detail__ TODO: Now that bug 15565 is pushed we can revisit this (using syspref DisplayMultiItemHolds) NOTE: I have local code for this that I'll upstream... __Staff interface detail__ TODO: Now that bug 15565 is pushed we can revisit this (using syspref DisplayMultiItemHolds) NOTE: I have local code for this that I'll upstream... __Staff interface (OTHER)__ 1. Go to http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=CPL&… FIXME: This returns a 500 error NOTE: I have this working locally... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0