- Koha-bugs - lists.koha-community.org

[Bug 8137] Checkout limit for all libraries
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '24

20 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #136 from Thibaud Guillot (thibaud_g) <thibaud.guillot(a)biblibre.com> --- (In reply to Brendan Lawlor from comment #132) > Thanks for working on this Thibaud! A global checkout limit is important for > our consortium. > > I am happy to test this again when this error is resolved. > > The patch applies, but after running updatedatabase and dbic I get an error > when running restart_all: > > Starting Z39.50/SRU daemon for kohadev:"my" variable $self masks earlier > declaration in same scope at /kohadevbox/koha/Koha/CirculationRules.pm line > 324. > "my" variable $params masks earlier declaration in same scope at > /kohadevbox/koha/Koha/CirculationRules.pm line 324. > "state" variable @_ masks earlier declaration in same scope at > /kohadevbox/koha/Koha/CirculationRules.pm line 324. > > Also the QA script complains on a few things: > > FAIL Koha/CirculationRules.pm > FAIL pod coverage > POD coverage was greater before, try perl > -MPod::Coverage=PackageName -e666 > FAIL valid > "my" variable $self masks earlier declaration in same scope > "my" variable $params masks earlier declaration in same scope > "state" variable @_ masks earlier declaration in same scope > "my" variable $rule_name masks earlier declaration in same > scope > "my" variable $categorycode masks earlier declaration in > same scope > "my" variable $itemtype masks earlier declaration in same > scope > "my" variable $branchcode masks earlier declaration in same > scope > "my" variable $rule masks earlier declaration in same scope > "my" variable $self masks earlier declaration in same scope > "my" variable $params masks earlier declaration in same scope > "state" variable @_ masks earlier declaration in same scope > "my" variable $categorycode masks earlier declaration in > same scope > "my" variable $itemtype masks earlier declaration in same > scope > "my" variable $branchcode masks earlier declaration in same > scope > "my" variable $has_priority masks earlier declaration in > same scope > "my" variable $self masks earlier declaration in same scope > "my" variable $params masks earlier declaration in same scope > "state" variable @_ masks earlier declaration in same scope > "my" variable $branchcode masks earlier declaration in same > scope > "my" variable $categorycode masks earlier declaration in > same scope > "my" variable $itemtype masks earlier declaration in same > scope > "my" variable $rule_name masks earlier declaration in same > scope > "my" variable $has_priority masks earlier declaration in > same scope > "my" variable $rule masks earlier declaration in same scope > "my" variable $memory_cache masks earlier declaration in > same scope > syntax error > Can't use global @_ in "my" > Global symbol "$params" requires explicit package name (did > you forget to declare "my $params"?) > syntax error > Can't use global @_ in "my" > syntax error > Can't use global @_ in "my" > syntax error > Can't use global @_ in "my" > syntax error > /kohadevbox/koha/Koha/CirculationRules.pm has too many > errors. > Compilation failed in require > > WARN Koha/Schema/Result/CirculationRule.pm > WARN tidiness > The file is less tidy than before (bad/messy lines before: > 41, now: 43) > > FAIL Koha/Template/Plugin/CirculationRules.pm > FAIL pod coverage > POD coverage was greater before, try perl > -MPod::Coverage=PackageName -e666 > FAIL valid > "my" variable $self masks earlier declaration in same scope > "my" variable $params masks earlier declaration in same scope > ... > > FAIL admin/smart-rules.pl > WARN tidiness > The file is less tidy than before (bad/messy lines before: > 137, now: 154) > FAIL valid > "my" variable $self masks earlier declaration in same scope > "my" variable $params masks earlier declaration in same scope > "state" variable @_ masks earlier declaration in same scope > ... > > FAIL installer/data/mysql/atomicupdate/Bug_8137-add-column-has_priority.pl > FAIL file permissions > File must have the exec flag > > FAIL installer/data/mysql/kohastructure.sql > FAIL tinyint_has_boolean_flag > The new column circulation_rules.has_priority is using > TINYINT(1) as type but is not defined as boolean in the schema file > (Koha/Schema/Result/CirculationRule.pm), see the SQL12 coding guideline > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt > FAIL forbidden patterns > forbidden pattern: tab char (line 1835) > forbidden pattern: tab char (line 1837) > FAIL spelling > librairies ==> libraries > librairies ==> libraries Hello Brendan and thanks for your feedback, I miss some bracket :/ during the last rebase. It's fixed ! And I also add a follow up for QA fixes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit for all libraries
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '24

20 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #135 from Thibaud Guillot (thibaud_g) <thibaud.guillot(a)biblibre.com> --- Created attachment 175838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175838&action=e… Bug 8137: (follow-up) remove forbidden pattern and fix atomic file permission -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit for all libraries
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '24

20 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot (thibaud_g) <thibaud.guillot(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173608|0 |1 is obsolete| | --- Comment #134 from Thibaud Guillot (thibaud_g) <thibaud.guillot(a)biblibre.com> --- Created attachment 175837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175837&action=e… Bug 8137: Add 'global checkout limits' table The aim here is to avoid the accumulation of checkouts possibilities through the rules of the various branches, in order to have a global quota. Test plan: 1) Apply this patch 2) Run updatedatabase script and rebuild schema, restart_all.. 3) On circulation rules page you will find a new table "Global checkout limits". 4) If you enter values, they will overwrite the existing values, creating limits for all branches combined. 5) Test it by set a "current checkouts allowed" to 2 on "standard rules section" and set a "global" maxissueqty to 1. Normally 1 is the new limit for now. 6) You can also add a "current checkouts allowed" on other branches and see that you can't accumulate checkouts (you can also delete "global" values and see that if you have 3 on a branch and 2 on other, you can perform 5 checkouts in total. 7) Note that on specific branch circulation rules page the table cannot be modified, but just shown as a reminder. If main matrix is empty on specific branch the table is hidden by default (cause if none values it's referred to standard rules). Sponsored-by: BibLibre Signed-off-by: Lisette Scheer <lisette(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit for all libraries
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '24

20 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot (thibaud_g) <thibaud.guillot(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38741] New: define a secondary sort order search results where primary sort field matches for several results
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '24

20 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38741 Bug ID: 38741 Summary: define a secondary sort order search results where primary sort field matches for several results Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: jake.bateman(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org When several search results are returned whose relevance and defaultSortOrder field match (a series with many volumes with the same publication date, in my case), it would be desirable to have these results ordered by some deliberately chosen field, or by a sensible default (title alphanumeric desc would I think would be correct in all cases, potentially negating the need for an additional syspref). In my testing (with Elasticsearch), I believe the current secondary sort order to be [biblionumber asc, plus some randomness from a race condition introduced by the multiple concurrent processing threads used by the Elasticsearch reindex task, if multithreading was used]. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 30503] New: Ability to include graphic in labels
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '24

20 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30503 Bug ID: 30503 Summary: Ability to include graphic in labels Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: egpetridis(a)yahoo.com QA Contact: testopia(a)bugs.koha-community.org I wonder if koha could include a graphic/image to its labels -even better in overlay form- so that a decent ex-libris label could be produced. -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 38752] New: BibTeX export include 245b
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '24

20 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38752 Bug ID: 38752 Summary: BibTeX export include 245b Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)hypernova.fi QA Contact: testopia(a)bugs.koha-community.org C4/Record.pm marc2bibtext now has: title => $record->subfield("245", "a") || "", We would also like to include 245b subtitle here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 38756] New: Fix "See highlighted items below" link without using an onclick attribute
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38756 Bug ID: 38756 Summary: Fix "See highlighted items below" link without using an onclick attribute Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: emily.lamancusa(a)montgomerycountymd.gov QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 35987 The overdues alert on patron accounts contains a "See highlighted items below" link that jumps to the Checkouts table and shows checkouts if they are hidden. Currently, the link uses an "onclick" attribute to show hidden checkouts, which is against coding guideline JS9 (https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_o…) This should be revised. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 [Bug 35987] See highlighted items below link broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #475 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 162079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162079 Bug 15516: Allow to reserve first available item from a group of titles Review of attachment 162079: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: circ/view_holdsqueue.pl @@ +63,5 @@ > + biblionumber => $item->{biblionumber} > + }, > + { order_by => 'reservedate' } > + )->next; > + $item->{hold_group_id} = $related_hold ? $related_hold->hold_group_id : undef; Ah, the lack of this block is why view_holdsqueue.tt doesn't work anymore... This is problematic anyways. I wonder if the tmp_holdsqueue table should store the reserve_id, although I don't quite understand the point of the tmp_holdsqueue table... ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt @@ +197,4 @@ > [% ELSE %] > <strong><a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% itemsloo.itemnumber | uri %]&biblionumber=[% itemsloo.biblionumber | uri %]#item[% itemsloo.itemnumber | uri %]">[% itemsloo.barcode | uri %]</a></strong> <em>or any available</em> > [% END %] > + [% IF itemsloo.hold_group_id %] This doesn't work because hold_group_id doesn't appear in the tmp_holdsqueue table. With this patch, the Holds Queue will throw a 500 error if it has any content to show. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31284] New: Add a calendar log
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31284 Bug ID: 31284 Summary: Add a calendar log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Changes to the calendar can affect various things in Koha, including due dates, fine calculation and sending of overdue notices. Sometimes a strange behavior can only be explained by holidays having been added or removed. In order to "debug" these issues, it would be great if changes to the calendar were logged. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4