- Koha-bugs - lists.koha-community.org

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '26

14 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #959 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- (In reply to Jonathan Druart from comment #958) > (In reply to Chloé Zermatten from comment #955) > > 2: logged_in_user is not available to circulation triggers as it stands. I > > could make it available, but it also is a lot more data than what > > circulation triggers really needs. That said we do need to move from > > consulting the logged in library to looking for the logged in user’s home > > library instead - and that much is fixed (see commit message). > > Indeed, I thought we had it widely available. > > > 5: The comment between those two lines reads “It may still be present in > > DBs that pre-date the atomic update.” I don’t know if you’ve seen it (won’t > > come up if grepping I don't think?). Does that answer it? I can ask Martin > > about it otherwise. > > It does not make sense to me. If we run the test on this version of the > code, the permission shouldn't be in the DB. > Ha, btw, the db_rev is not idempotent. > > > 10: best practice: I don’t think so - but I do think it’s a step in that > > direction (the direction of travel so far had been to remove duplicate code, > > prevent redundant data (re)loads, remove duplicated logic, etc). Further > > refactoring into more specialised components will be beneficial. 39756 (long > > overdue cron) can certainly take that refactoring further. > > I don't understand why we have most of those functions in "store". They > don't touch the store state. They could certainly be moved to a plain JS > module, that could be easily unit-tested without Pinia/Vue at all. Note that > I am not requiring unit tests, but only flagging what seems to be a > problematic pattern. OTOH that does not seem to be a trivial refactoring... Re-db_rev: noted - I can look at that later today, but more likely tomorrow. Re-extracting methods that do not touch store state out of store: agreed on the plain JS module option, especially from a future testability standpoint. I think the best way to figure out exactly how non-trivial this is is for me to actually have a crack at it, which I can spend some time on tomorrow. I can either add it in as a further commit on here or raise it as follow up bug (which would be a 39756 dependency) - do let me know if you have a preference! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7340] Only send HOLD_PLACED if item is available and hold was patron initiated
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '26

14 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7340 Koha collecto <koha(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha(a)collecto.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7340] Only send HOLD_PLACED if item is available and hold was patron initiated
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '26

14 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7340 Koha collecto <koha(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha(a)collecto.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43158] New: Add clear button (x) to search input fields
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '26

14 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43158 Bug ID: 43158 Summary: Add clear button (x) to search input fields Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Add a clear/reset button (x icon) on the search input fields that appears when text has been typed, allowing users to quickly clear the search box without manually selecting and deleting the text. Start with the OPAC search input, then extend to the staff interface. This is a common UX pattern in modern web applications (browsers natively support it for type=search inputs, but Koha uses type=text). Implementation options: - Use HTML5 type=search which provides a native clear button in most browsers - Or add a positioned x icon via CSS/JS that clears the input on click The native type=search approach is simpler and more accessible. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 42925] New: Replace the 'clear' button with an icon inside the search box (global search for tables)
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '26

14 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42925 Bug ID: 42925 Summary: Replace the 'clear' button with an icon inside the search box (global search for tables) Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- On Chrome there is a builtin 'x' in the search box. The "Clear filter" button is then not needed. However it does not exist for Firefox. We could disable the builtin feature in Chrome add our own, so all browsers have it. Then the "Clear filter" button will no longer be needed. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '26

14 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #958 from Jonathan Druart <jonathan.druart(a)gmail.com> --- (In reply to Chloé Zermatten from comment #955) > 2: logged_in_user is not available to circulation triggers as it stands. I > could make it available, but it also is a lot more data than what > circulation triggers really needs. That said we do need to move from > consulting the logged in library to looking for the logged in user’s home > library instead - and that much is fixed (see commit message). Indeed, I thought we had it widely available. > 5: The comment between those two lines reads “It may still be present in > DBs that pre-date the atomic update.” I don’t know if you’ve seen it (won’t > come up if grepping I don't think?). Does that answer it? I can ask Martin > about it otherwise. It does not make sense to me. If we run the test on this version of the code, the permission shouldn't be in the DB. Ha, btw, the db_rev is not idempotent. > 10: best practice: I don’t think so - but I do think it’s a step in that > direction (the direction of travel so far had been to remove duplicate code, > prevent redundant data (re)loads, remove duplicated logic, etc). Further > refactoring into more specialised components will be beneficial. 39756 (long > overdue cron) can certainly take that refactoring further. I don't understand why we have most of those functions in "store". They don't touch the store state. They could certainly be moved to a plain JS module, that could be easily unit-tested without Pinia/Vue at all. Note that I am not requiring unit tests, but only flagging what seems to be a problematic pattern. OTOH that does not seem to be a trivial refactoring... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '26

14 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #450 from Jake Deery <jake.deery(a)openfifth.co.uk> --- Created attachment 205722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205722&action=e… Bug 14962: DBIC - DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '26

14 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #449 from Jake Deery <jake.deery(a)openfifth.co.uk> --- Created attachment 205721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205721&action=e… Bug 14962: atomicupdate - DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '26

14 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #448 from Jake Deery <jake.deery(a)openfifth.co.uk> --- Created attachment 205720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205720&action=e… Bug 14962: On Display Cypress e2e tests This patch contains the front-end tests for the On Display module. If you'd like to verify the Perl methods, see the perl test harness patch. You can also use the test plan below to test the entire patchset works as expected. TO TEST (AUTOMATED E2E): APPLY PATCHSET a) cd $PROJECTS_DIR/koha b) DB_HOSTNAME=localhost npx yarn cypress open *) you may need to run `corepack enable` if you get "command not found" c) click E2E testing d) click start E2E testing in Electron e) under Display, click Main.ts *) verify it runs through fully with green f) return to last page, under Display, click Displays_spec.ts *) verify it runs through fully with green SIGN OFF TO TEST (MANUALLY): APPLY PATCHSET a) go to /cgi-bin/koha/display/display-home.pl *) notice module is disabled b) go to /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=UseDisplayModule *) set UseDisplayModule syspref to "Use" c) repeat step a *) notice module is now enabled d) click "New display" e) Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> Signed-off-by: Emily Lamancusa <emily.lamancusa(a)montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '26

14 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #447 from Jake Deery <jake.deery(a)openfifth.co.uk> --- Created attachment 205719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205719&action=e… Bug 14962: On Display perl tests This bug provides the test harness for Bug 14962's new perl methods. The front-end tests are contained within the Cypress tests patch, and you should review the commit message for that patch for end-user test steps. TO TEST: APPLY PATCHSET a) run qa -v 2 --more-tests *) verify everything passes Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> Signed-off-by: Emily Lamancusa <emily.lamancusa(a)montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0