- Koha-bugs - lists.koha-community.org

[Bug 38241] New: When AccountAutoReconcile is enabled and a patron has a credit 'Save and pay' gives an error when adding invoice
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '24

23 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38241 Bug ID: 38241 Summary: When AccountAutoReconcile is enabled and a patron has a credit 'Save and pay' gives an error when adding invoice Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: 1 - Add a manual credit to a patron 2 - Create a manual invoice for any amount that is less than the account credit. 3 - Click "Save and pay" 4 - On the payment screen, click "Confirm" 5 - You're redirected to the "Make a payment screen, along with the "You must pay a value..." error message. 6 - Check the Transactions, and you will see that the fine has no amount outstanding, but there is no payment -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 38238] New: Amperstamp is not escaped in RSS feed generation
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '24

23 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38238 Bug ID: 38238 Summary: Amperstamp is not escaped in RSS feed generation Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: baptiste.wojtkowski(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org When generating the RSS feed, opac-opensearch.tt escapes amperstamps in query_cgi but not limits_cgi Steps to reproduce : 1 - Go to advanced search in opac 2 - Make a research only on a selected item type (books for example) 3 - Click on the RSS button => the generated rss is invalid with amperstamp not escaped (firefox will fail at displaying it) -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 32010] New: selenium/authentication_2fa.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '24

23 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010 Bug ID: 32010 Summary: selenium/authentication_2fa.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 30588 Blocks: 25551 Since bug 30588 t/db_dependent/selenium/authentication_2fa.t is failing randomly. Well, it seems that it fails consistently on jenkins. 17:28:48 koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} 17:28:48 koha_1 | /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try 17:28:48 koha_1 | (eval 541):1 in Selenium::Remote::Driver::__ANON__ 17:30:50 koha_1 | (eval 543):2 in Selenium::Remote::Driver::__ANON__ 17:30:50 koha_1 | /usr/share/perl5/Selenium/Remote/Driver.pm:654 in Selenium::Remote::Driver::_execute_command 17:30:50 koha_1 | t/db_dependent/selenium/authentication_2fa.t:282 in Selenium::Remote::Driver::get_alert_text 17:30:50 koha_1 | /usr/share/perl/5.32/Test/Builder.pm:334 in main::__ANON__ 17:30:50 koha_1 | /usr/share/perl/5.32/Test/Builder.pm:334 in (eval) 17:30:50 koha_1 | /usr/share/perl/5.32/Test/More.pm:809 in Test::Builder::subtest 17:30:50 koha_1 | t/db_dependent/selenium/authentication_2fa.t:291 in Test::More::subtest 17:30:50 koha_1 | 17:30:50 selenium_1 | 1666711728262 Marionette INFO Stopped listening on port 35969 17:30:50 selenium_1 | JavaScript error: resource://gre/modules/Prompter.jsm, line 1253: NS_ERROR_NOT_AVAILABLE: prompt aborted by user 17:30:50 selenium_1 | JavaScript error: resource:///modules/Interactions.jsm, line 230: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIUserIdleService.removeIdleObserver] 17:30:50 koha_1 | # Looks like you planned 7 tests but ran 4. 17:30:50 koha_1 | 17:30:50 koha_1 | # Failed test 'Enforce 2FA setup on first login' 17:30:50 koha_1 | # at t/db_dependent/selenium/authentication_2fa.t line 291. 17:30:50 koha_1 | Error while executing command: no such alert at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. 17:30:50 koha_1 | at /usr/share/perl5/Selenium/Remote/Driver.pm line 356. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 [Bug 30588] Add the option to require 2FA setup on first staff login -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 14007] Item types for items hidden by OpacHiddenItems turn up in facet results
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '24

23 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 --- Comment #27 from David Cook <dcook(a)prosentient.com.au> --- Yeah... this one might not be fixable. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14007] Item types for items hidden by OpacHiddenItems turn up in facet results
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '24

23 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 --- Comment #26 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #25) > I'm going to take this one over. I've got a library who wants this fixed, > and I've got an idea on how to do it, so planning to do this soon. Except that I totally misunderstood the problem... Sure, if your OpacHiddenItem rule is an itype rule, you can filter it out of the facets. But if your OpacHiddenItem rule is a withdrawn rule, it's not clear what facet value belongs to a hidden item. Yep. I get it now. Bit of an oversight there... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11583] Add WYSIWYG editor for HTML notices/letters
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '24

23 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 --- Comment #14 from David Cook <dcook(a)prosentient.com.au> --- I tried out my ideas of extracting the problematic tokens and replacing with a safe token, letting TinyMCE init, and then replacing the safe tokens with the problematic tokens, but there doesn't seem to be a simple supported way of doing that without re-processing the content. -- The best bet might be to have the separate tabs. Say a CodeMirror on one tab, and a TinyMCE on another tab, and keep them synchronized, and use "protect" to stop TinyMCE from interfering with Template::Toolkit and <<>> notice syntax. That said... that's still going to be super error-prone, as TinyMCE is a pretty blunt instrument, which loves to mangle content. -- I vaguely recall someone wanting to support Mustache syntax instead of Template::Toolkit in the notices. But.. I think TinyMCE's messing with formatting would still be problematic. -- I don't know. The more I look at this, the more impossible it seems. We could do nicer previews, but I don't know about using a WYSIWYG editor... at least not with the complexity of notice templates we support. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11583] Add WYSIWYG editor for HTML notices/letters
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '24

23 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 --- Comment #13 from David Cook <dcook(a)prosentient.com.au> --- Actually, at Kohacon2024, maybe what we discussed was just improved preview options... those would be much more doable. -- With the WYSIWYG... perhaps we could do a plugin that lets you insert template syntax into the notice without it getting entity escaped. That might not be a terrible workaround... But we'd also need some code to prevent entity escaping at init/load time, which would be more difficult. (What we could do is pre-process, extract our notice syntax and replace with a safe magical tokens like a random custom element like <24t0824ht> or {{24t0824ht}}, init/load TinyMCE, and then replace those safe tokens with our notice syntax extractions programmatically. It would be hacky, but it could probably work.) The WYWISYG would make adding HTML more user-friendly but adding Koha notice syntax more difficult. -- But in any case... this would take a lot of experimenting and even then a TinyMCE upgrade could break it. More thinking to do here... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11583] Add WYSIWYG editor for HTML notices/letters
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '24

23 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion --- Comment #12 from David Cook <dcook(a)prosentient.com.au> --- I'm not a TinyMCE expert, so my guess is that there is code that could be written to make this work, but I'm guessing it would be a fair bit of code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11583] Add WYSIWYG editor for HTML notices/letters
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '24

23 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 --- Comment #11 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #9) > After a bit of reading, it looks like we could use TinyMCE's "protect" > configuration option to allow both the TT syntax and the original <<>> > syntax to be preserved (and not HTML entity encoded). Ok, the "protect" means they're not handled by the TinyMCE at all, so they don't appear in the editor either. We could workaround that by providing both a source view and a HTML view, so that you could add your notice syntax and then sort of "preview" it, or add your HTML and then view what that's like in the source... Although technically the HTML view would still not be the same as a "rendered" view. -- TinyMCE also meddles heavily with pre-existing whitespace which can be important with Template::Toolkit in more complex notices. Also, you could enter <<whatever.whatever>> or [% stuff => stuff %] into the editor still and they would appear with the escaped HTML. That's not good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11583] Add WYSIWYG editor for HTML notices/letters
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '24

23 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 --- Comment #10 from David Cook <dcook(a)prosentient.com.au> --- Since TinyMCE already uses an iframe for the WYSIWYG, we shouldn't need to do anything extra with iframes or shadow DOM... We could also use on of TinyMCE's CSS configuration options to include NoticeCSS... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0