- Koha-bugs - lists.koha-community.org

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162047|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162094&action=e… Bug 6796: Fix saving of libraries and tests Sponsored-by: Catalyst IT Sponsored-by: Auckland University of Technology Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162046|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162093&action=e… Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Catalyst IT Sponsored-by: Auckland University of Technology Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162045|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162092&action=e… Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursInCirculation' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursInCirculation. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursInCirculation to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursInCirculation to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162044|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162091&action=e… Bug 6796: ConsiderLibraryHoursInCirculation system preference Sponsored-by: Catalyst IT Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162043|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162090&action=e… Bug 6796: Add library_hours table and set opening hours for library Sponsored-by: Catalyst IT Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #106 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- A restless night later and I did a complete about turn.. I came up with a way to defensively code around this instead to protect from bad data ended up in the database somehow. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #468 from David Cook <dcook(a)prosentient.com.au> --- My test plan: 0a) koha-upgrade-schema kohadev 0b) koha-plack --restart kohadev __OPAC results__ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search… 2. Checkbox results 1 and 2 3. Click "Place hold" at the top of the search results 4. Checkbox "Treat as hold group (next available item fulfills all holds)" 5. Click "Confirm hold" 6. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 7. Click "Holds" 8. Confirm the two holds appear with the text "part of a hold group", and when you click on that text it shows you both hold group titles 9. Note the "Holds" tab shows 1 hold signifying the 2 holds in the hold group count as 1 hold total 10. In the staff interface, check in "39999000001310" 11. Click "Confirm hold (Y)" 12. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 13. Note only 1 hold appears, and when you click on "part of a hold group" it only shows 1 hold title 12. In the OPAC, go to http://localhost:8080/cgi-bin/koha/opac-user.pl 13. Note that only 1 hold appears now 14. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 15. Cancel the hold __Staff interface results__ 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2. Checkbox results 1 and 2 3. Click "Place hold" at the top of the search results 4. Search for patron "koha" 5. Checkibox "Treat as hold group" 6. Choose "Centerville" as "Pickup at" 7. Click "Place holds" 8. Click on "part of a hold group" on the each hold and note the modal with "Hold group" appears showing the 2 titles 9. Check in "39999000001310" 10. Click "Confirm hold (Y)" 11. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 12. Cancel the hold __OPAC detail__ NOTE: This is irrelevant without https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 so 15565 can focus on implementing it. __Staff interface detail__ NOTE: This is irrelevant without https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 so 15565 can focus on implementing it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #467 from David Cook <dcook(a)prosentient.com.au> --- QA tool seems mostly happy. I think it just has issues with Koha schema files which are irrelevant and sysprefs.sql which isn't related to this change. -- OK C4/Reserves.pm OK Koha/Hold.pm OK Koha/HoldGroup.pm OK Koha/HoldGroups.pm OK Koha/Holds.pm FAIL Koha/Schema/Result/HoldGroup.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 15) WARN Koha/Schema/Result/OldReserve.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 136, now: 152) WARN Koha/Schema/Result/Reserve.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 161, now: 177) OK circ/circulation.pl OK circ/view_holdsqueue.pl OK installer/data/mysql/atomicupdate/bug_15516_-_hold_group_table.pl OK installer/data/mysql/kohastructure.sql FAIL installer/data/mysql/mandatory/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs hidelostitems is bad placed (see bug 10610) OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js OK koha-tmpl/intranet-tmpl/prog/js/holds.js OK koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt OK koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt OK koha-tmpl/opac-tmpl/bootstrap/js/holds.js OK members/moremember.pl OK opac/opac-reserve.pl OK opac/opac-user.pl OK reserve/hold-group.pl OK reserve/placerequest.pl OK reserve/request.pl OK svc/holds OK t/db_dependent/Koha/Holds.t OK t/db_dependent/Reserves/HoldGroup.t Processing additional checks OK! Running tests (2) * Proving /kohadevbox/koha/t/db_dependent/Reserves/HoldGroup.t OK! * Proving /kohadevbox/koha/t/db_dependent/Koha/Holds.t OK! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #466 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 162084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162084&action=e… Bug 15516: Add 'DisplayAddHoldGroups' system preference to toggle ability to add titles to hold groups These patches add the ability to create hold groups across multiple bibs in the staff interface or OPAC. These hold groups are fulfilled by the first item checked in across the hold group. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #465 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 162083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162083&action=e… Bug 15516: (follow-up) Only show hold groups for multi hold in staff interface -- You are receiving this mail because: You are watching all bug changes.

1 0