- Koha-bugs - lists.koha-community.org

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '24

12 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #105 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Coming back to comment #88 > and it would be great to have a fallback to default for opening hours so you could set at the global level and override at the branch level.. like many of our other options of this style. I think this is the resolution we need for tests.. if we allow library_id to be nullable in library_hours and add a row for each day with default opening hours to fall back to, then handling this in code should mean we can get tests passing more easily. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '24

12 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '24

12 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '24

12 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #104 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I've fixed a whole bunch of little issues to get this vaguely working now, but as I run the test suit against it I see there are more issues hidden. I've fixed some array indexing issues where your code worked in opposition to how Koha's calendar indexes days of the week already.. but Circulation tests still fail. This is because, as far as I can tell, your code expects every branch to always have opening hours set.. i.e. there MUST be rows for days 0 to 6 for every branch, even if those rows have hours of null-null. I've fixed the database update to handle this, however the failing tests expose the lack of treatment for this in t/lib/TestBuilder. We'll need that resolving before this can work it's way through QA. I'm not sure whether we should be adding this handling to TestBuilder (i.e. to always ensure there's 7 rows per branch for any time a branch is added in testing), or whether really we should not be making this assumption in the first place and instead we should be allowing for missing rows in the library_hours table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '24

12 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #103 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162056&action=e… Bug 6796: day_of_week representation fix The code here was floored, DateTime returns a 1-7 indexed array with the first day being Monday, Koha expects an 0-6 indexed array with the first day being Sunday. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '24

12 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #102 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162055&action=e… Bug 6796: Merge and correct database update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '24

12 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #101 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162054&action=e… Bug 6796: Take CalenderFirstDayOfWeek and TimeFormat into account This patch adds accounting for the `CalendarFirstDayOfWeek` and `TimeFormat` preferences in the libraries management pages. We respect CalendarFirstDayOfWeek for both input and display, but we only respect TimeFormat for input at this time. We need a new template helper and js helper for formatting just time in the appropriate format, currently we only have such formatters for full datetimes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '24

12 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161988|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162053&action=e… Bug 6796: Fix display of libraries table -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '24

12 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161987|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162052&action=e… Bug 6796: Fix api specifications and embed hours in librarly management -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '24

12 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161986|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162051&action=e… Bug 6796: (follow-up) Displaying library hours This patch shows the set library hours on a library's view page. Still to be done: - show on the Libraries summary page - write tests - consider time format settings - fix translateability of day names in Libraries summary page -- You are receiving this mail because: You are watching all bug changes.

1 0