- Koha-bugs - lists.koha-community.org

[Bug 17228] New: Make two versions of SIPconfig.xml identical
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '23

23 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Bug ID: 17228 Summary: Make two versions of SIPconfig.xml identical Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: magnus(a)libriotech.no Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net We have two versions of SIPconfig.xml: etc/SIPconfig.xml debian/templates/SIPconfig.xml The former has been updated with some changes to the possible configuration of SIP2 servers, e.g. by bug 15006. The latter has not been updated with the same information. Since debian/templates/SIPconfig.xml contains no special placeholders or variables, this bug proposes to simply copy etc/SIPconfig.xml to debian/templates/SIPconfig.xml, so that admins using the packages will see an up-to-date SIP2 config example when they have enabled SIP2 for a site. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 35132] New: Cookie consent modal is always visible in the ERM module
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '23

23 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35132 Bug ID: 35132 Summary: Cookie consent modal is always visible in the ERM module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: matt.blenkinsop(a)ptfs-europe.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, matt.blenkinsop(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com To reproduce: 1) Enable syspref "CookieConsent" 2) Delete any existing cookie for Cookie consent in your browser 3) Refresh the page 4) The cookie consent bar should be visible at the bottom of the screen 5) Navigate to the ERM module 6) The consent bar will still be visible but so will the modal - this should not be the case -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #190 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- (In reply to Andrii Nugged from comment #187) > btw, that atomic update quoting is very inconsistent: It's just between 1st and 3rd case. The 2nd uses interpolation so needs the double-q IIUC Is there even a recommendation for a default choice for the others? The examples at https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomi… use q{ so let's use that. updatedatabase tested. ---- > I did the rebase. But which status we should put for the ticket? Thanks for the rebase :) It was passed QA before. So passed QA, unless the rebase showed that other changes could interfere with this and require retesting. **How was it?** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #189 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 157624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157624&action=e… Bug 15504: (QA follow-up): more consistent quotes in atomicupdate -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #188 from Andrii Nugged <nugged(a)gmail.com> --- btw, that atomic update quoting is very inconsistent: my ($tracklastactivity) = $dbh->selectrow_array( q| SELECT value FROM systempreferences WHERE variable='TrackLastPatronActivity'; | ); vs $dbh->do( qq{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('TrackLastPatronActivityTriggers',?,NULL,'If set, the field borrowers.lastseen will be updated every time a patron performs a selected action','multiple') }, undef, $triggers, ); vs $dbh->do( q{ DELETE FROM systempreferences WHERE variable='TrackLastPatronActivity' } ); why so? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #187 from Andrii Nugged <nugged(a)gmail.com> --- I did the rebase. But which status we should put for the ticket? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #186 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157620&action=e… Bug 15504: (QA follow-up) Final changes [1] Comment in Patron->is_active sharpened. [2] Patron->update_lastseen return if $cached && $cached eq $now->ymd; Should be return $self if $cached && $cached eq $now->ymd; Consistent return value. [3] Typo if there are not TrackLastPatronActivityTriggers enabled [4] Typo TrackLastPatronActivityTriggers must be contain [5] Typo patron is does .. option => performs an action [6] Tidy on dbrev to fix The file is less tidy than before (bad/messy lines before: 0, now: 4) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #185 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157619&action=e… Bug 15504: (QA follow-up) Fix dbrev Resolve: ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Unknown column 'check_out' in 'field list' at /usr/share/koha/C4/Installer.pm line 741 Test plan: Remove new pref from db. Run dbrev again. Check results. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #184 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157618&action=e… Bug 15504: Remove PatronLastActivity preference This patch removes the older PatronLastActivity preference opting to replace it by the new PatronLastActivityTriggers preference. The feature can now be disabled by simply not selecting any triggers Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #183 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157617&action=e… Bug 15504: (follow-up) Clarify --last_seen option in delete_patrons This patch adds clarifications to the last_seen option in delete_patrons to clarify that TrackLastPatronActivity and TrackLastPatronActivityTriggers system preferences act as a couplet. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0