- Koha-bugs - lists.koha-community.org

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #182 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157616&action=e… Bug 15504: (follow-up) Update terminology on cleanborrowers This patch updates the terminology on the cleanborrowers form to reflect that 'activity' and not just 'connectivity' is tracked by TrackLastPatronActivity. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #181 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157615&action=e… Bug 15504: (QA follow-up) Terminology This just updates 'Login to OPAC' to 'Login'.. we should squash this Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #180 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157614&action=e… Bug 15504: (follow-up) Rename cache key I agree, it's better to use borrowernumber for the cache key and I also take the oportunity to rename it to more clearly reflect the function (it's no longer 'login' only, it's now 'activity') Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #179 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157613&action=e… Bug 15504: (follow-up) Respect existing TrackLastPatronActivity This patch updates the database update to set 'check_out,connection,login' as the activity triggers should we find at upgrade time that TrackLastPatronActivity is set to true. This retains the existing functionality. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #178 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157612&action=e… Bug 15504: (follow-up) Fix is_active test Bug 33245 introduced a new is_active patron method and the corresponding tests included calls to the method we depreacte in this patchset Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #177 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157611&action=e… Bug 15504: (follow-up) Tidy 'lastseen' section of unit test Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #176 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157610&action=e… Bug 15504: (follow-up) Add Triggers mock to unit tests Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #175 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157609&action=e… Bug 15504: (follow-up) Use borrowernumber in Koha::Patrons->find Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #174 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157608&action=e… Bug 15504: (follow-up) Migrate to one clear method We were using a series of similarly named methods spread in distinct places around the codebase. This combines the logic of C4::Auth::track_login_daily and Koha::Patron->track_login into a new Koha::Patron->update_lastseen method. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #173 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157607&action=e… Bug 15504: (follow-up) Unit tests This patch removes, moves and updates the existing unit tests for track_login_daily and track_login to all sit under Koha::Patron and update_lastseen. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0