- Koha-bugs - lists.koha-community.org

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '26

27 Aug '26

1 0

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '26

27 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43391 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43299] New: Add class to shelving location column in staff interface in order to allow styling
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '26

27 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43299 Bug ID: 43299 Summary: Add class to shelving location column in staff interface in order to allow styling Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- Libraries sometimes wish to draw special attention to specific shelving locations within the holdings table on a bib record -- like when an item is at the CART location after being returned. A class around the value would make it easy to style with CSS. The class would want to include the code for the shelving location ("loc-cart" or "loc-fic"). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22

[Bug 38953] New: borrower_message_preferences.borrowernumber should not be DEFAULT NULL
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '26

27 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38953 Bug ID: 38953 Summary: borrower_message_preferences.borrowernumber should not be DEFAULT NULL Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)koha-suomi.fi QA Contact: testopia(a)bugs.koha-community.org borrowernumber in borrower_message_preferences is DEFAULT NULL in kohastructure.sql, despite ON DELETE CASCADE in the foreign key. Also borrower message preferences without a borrowernumber don't make any sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 6892] If a URL has been entered without http://, it isn't correctly linked
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '26

27 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 --- Comment #22 from Jan Kissig <bibliothek(a)th-wildau.de> --- (In reply to Paul Derscheid from comment #18) > Hi Jan, thanks for picking this one up. > > The OPAC follow-up is good and does what it says: with TrackClicks on, > uri=bugs.koha-community.org becomes > uri=http%3A%2F%2Fbugs.koha-community.org, and with tracking off the Online > resources block comes out identical to before. Hoisting the > AddMissingProtocol call into a variable so all three branches share it also > looks right to me. > > The first patch is a problem, though. It comes down to: in the "otherwise" > branch it drops the <a> instead of leaving it alone. > > For example: a record with 856 ind1=0 $u mailto:someone@example.com. On main > that link works. With the patch it renders as plaintext, because "mailto" > doesn't start with "http" and ind1 isn't 4. Same for telnet://locis.loc.gov > (ind1=2) and ftp://ftp.gnu.org/gnu/ (ind1=1). The protocols from the > indicator list in comment #2. And that applies to any other $u subfield too, > e.g. 505 $u mailto:someone@example.com. Katrin suggested in comment #4 to > add http:// for ind1=4 and leave the content alone otherwise. Leaving it > alone fixes the reported case w/o breaking the others. > > Another thing is that the check reads tab0X.{tag,tag_ind} and MARCdetail.pl > only fills those in the standard display path. Two settings break it: > 1. hide_marc=on: the tag holds the fields label instead of 856, so a > protocol-less 856 ind1=4 gets no link. > 2. LabelMARCView=economical: repeated fields get tag = '', so only the first > 856 in a run of 856s gets the http:// prefix, the rest lose their links. > > On comment #6: since this seems to have stalled this bug, both patches are > display only, so no modification of stored data. Thanks Paul for your findings. I rewrote the patch for MARCdetail.tt based on your remarks and followed the approach from xsl template 'AddMissingProtocol' used in detail.tt. The other patch is unchanged. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6892] If a URL has been entered without http://, it isn't correctly linked
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '26

27 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 --- Comment #21 from Jan Kissig <bibliothek(a)th-wildau.de> --- Created attachment 204256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204256&action=e… Bug 6892: Fix links on MARCdetail.tt when protocol is missing This patch will check for URLs in MARC21 data by following the approach from details xsl template AddMissingProtocol: - when a protocol prefix is given (URI starts with "^[A-Za-z]:") the URL then gets wrapped in an html <a> element - when no protocol prefix is given it gets added based on indicator 1 of that subfield: - ind1=0 prefixed with mailto: - ind1=1 prefixed with ftp:// - ind1=2 prefixed with telnet:// - ind1=3 prefixed with tel: - ind1=4 prefixed with http:// - ind1=7 ommitted When prefix is added, the URL then gets wrapped in an html <a> element This will apply to all subfields flagged as 'is url' in MARC framework. This also fixes a small bug: the subfield code (f.e. 'u') was displayed even when sys pref hide_marc is set to Don't show Test plan: a) import demo record from listed attachments via More -> Cataloging -> Stage MARC records for import This record 1. 856 4 _u example.com 2. 856 4 _u https://example.com 3. 856 _u https://example.com 4. 856 _u example.com 5. 856 0 _u mailto:someone@example.com 6. 856 0 _u someone(a)example.com 7. 856 _u mailto:someone@example.com 8. 856 _u someone(a)example.com 9. 856 2 _u locis.loc.gov 10. 856 2 _u telnet://locis.loc.gov 11. 856 _u telnet://locis.loc.gov 12. 856 _u locis.loc.gov 13. 856 1 _u ftp.gnu.org/gnu/ 14. 856 1 _u ftp://ftp.gnu.org/gnu/ 15. 856 _u ftp://ftp.gnu.org/gnu/ 16. 856 _u ftp.gnu.org/gnu/ 17. 856 3 _u 123456789 18. 856 3 _u tel:123456789 19. 856 _u tel:123456789 20. 856 _u 123456789 21. 505 4 _u http://ftp.gnu.org/gnu/ b) open the records MARC view (MARCdetail.pl) and take a look at the links in tab 5 and 8 - check all URLs are links. - check that all URLs missing a protocol prefix (http:, ftp:, mailto:, etc) link to the ktd instance like http://KTDINSTANCE/cgi-bin/koha/catalogue/wrong_url_here - check all URLs having a protocol prefix as they will link correctly. c) apply patch and reload MARCdetail.pl (maybe a restart_all is required) - check that URLS without a protol prefix get a prefix added when an apporiate indicator is given (f.e. 1, 6, 9, 13, 17) - check that only URLs with a protocol prefix are now linked. d) when syspref hide_marc=Don't show only URLs with protocol get linked. e) with syspref LabelMARCView=Do only URLs with protocol get linked. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6892] If a URL has been entered without http://, it isn't correctly linked
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '26

27 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 --- Comment #20 from Jan Kissig <bibliothek(a)th-wildau.de> --- Created attachment 204255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204255&action=e… Bug 6892: (follow-up) Fix urls in OPAC when TrackClicks is enabled This patch fixes outgoing links from 856$u when system preference 'TrackClicks' is set and the URL is lacking the protocol prefix. Test plan: a) set system pref TrackClicks to 'Track' or 'Track anonymously' b) edit a record (f.e. 262) and set the following 856 fields (the record from 1st patch is sufficient though): 1. 856 ind1=4 $u = example.com 2. 856 $u = example.com 3. 856 $u = https://example.com b) save and search for that record in OPAC. c) on search results list (opac-search.pl) please check the links on that record: 1. links to http://main.localhost/cgi-bin/koha/tracklinks.pl?uri=example.com&biblionumb… and does not work 2. links to http://main.localhost/cgi-bin/koha/tracklinks.pl?uri=example.com&biblionumb… and does not work 3. links to http://main.localhost/cgi-bin/koha/tracklinks.pl?uri=https://example.com&bi… and works d) click on the record to get to the detail page (opac-detail.pl) and check the links again (Online resources). They should be the same as in step c) e) apply patch, call restart_all and redo step b) until d) verifying that 1. is now prefixed with http:// and links to http://main.localhost/cgi-bin/koha/tracklinks.pl?uri=http://example.com&bib… (works now) 2. is now prefixed with http:// and links to http://main.localhost/cgi-bin/koha/tracklinks.pl?uri=http://example.com&bib… (works now) 3. still links to http://main.localhost/cgi-bin/koha/tracklinks.pl?uri=https://example.com&bi… Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6892] If a URL has been entered without http://, it isn't correctly linked
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '26

27 Aug '26

1 0

[Bug 6892] If a URL has been entered without http://, it isn't correctly linked
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '26

27 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 Jan Kissig <bibliothek(a)th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6892] If a URL has been entered without http://, it isn't correctly linked
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '26

27 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 --- Comment #19 from Jan Kissig <bibliothek(a)th-wildau.de> --- Created attachment 204254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204254&action=e… Demo record with a variety of $u subfields -- You are receiving this mail because: You are watching all bug changes.

1 0