- Koha-bugs - lists.koha-community.org

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '23

14 Jun '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Matt Blenkinsop <matt.blenkinsop(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 [Bug 33997] Borrowers.updated_on should not be updated by track_login -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '23

14 Jun '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #40 from Matt Blenkinsop <matt.blenkinsop(a)ptfs-europe.com> --- Notes on testing - The intent of track_login_daily is to log a patron action/activity once per day and cache this activity. This means that the lastseen field is only updated once per day rather than every time an action is performed. This makes sense in operation but makes testing this patch more complicated. We want to test multiple methods of updating the lastseen field. If we don’t clear that cache before each method then the patch will work as intended but the test plan will fail as only one update will be performed. The test plan therefore includes a “restart_all” step at various points before an activity is performed - this step uses “restart_all” in KTD to clear the cache and must not be skipped otherwise the test plan will fail. Furthermore, the “Login to OPAC” action, called in checkauth is triggered very often throughout Koha through various route guards etc. The test plan begins by testing this activity first and then de-selecting this option. If this option is left selected, then it will trigger before the other actions (check in, check out etc) can be triggered and the test plan will fail due to the login action already being cached again. Test plan: 1. Apply patch 2. reset_all 3. Navigate to Administration and search for “TrackLastPatronActivity” 4. Observe that there are two system preferences - “TrackLastPatronActivity” and “TrackLastPatronActivityTriggers” 5. Change TrackLastPatronActivity to “Do” and save 6. Choose a patron to use as a test subject 7. In the database, observe that the “lastseen” property for that patron is still NULL 8. In TrackLastPatronActivityTriggers, select “Login to OPAC” and save 9. In the OPAC, log in as your selected patron 10. In the database, observe that the “lastseen” property for that patron has been updated 11. In TrackLastPatronActivityTriggers, unselect “Login to OPAC” and instead select “Checking out an item” and save 12. restart_all 13. Check out an item to your selected patron 14. In the database, observe that the “lastseen” property for that patron has been updated 15. In TrackLastPatronActivityTriggers, select “Renewing an item” and save 16. restart_all 17. In either the OPAC or the staff client - renew the item that you have just checked out to that patron 18. In the database, observe that the “lastseen” property for that patron has been updated 19. In TrackLastPatronActivityTriggers, select “Returning an item” and save 20. restart_all 21. Return the item that you have checked out to the patron 22. In the database, observe that the “lastseen” property for that patron has been updated 23. In TrackLastPatronActivityTriggers, select “Connection to Koha via SIP or ILSDI” and save 24. In system preferences, search for “ILS-DI” and enable this preference 25. restart_all 26. In the browser, navigate to http://DOMAIN/cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=USE…, swapping out DOMAIN, USERNAME and PASSWORD to match your koha instance and patron details 27. In the database, observe that the “lastseen” property for that patron has been updated 28. Run “prove -v t/db_dependent/Auth.t” 29. Observe that all tests pass 30. Sign off! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '23

14 Jun '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Matt Blenkinsop <matt.blenkinsop(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #39 from Matt Blenkinsop <matt.blenkinsop(a)ptfs-europe.com> --- This bug hasn’t been active for a while but we recently had a support ticket from a customer that seemed to fit into this discussion. By comparing that with the discussion on this bug I’ve prepared a patch that will hopefully satisfy the requirement of both. There are now two sysprefs - “TrackLastPatronActivity” and “TrackLastPatronActivityTriggers”. The second of these offers a list of the following: - login: "Login to OPAC" - connection: "Connection to Koha via SIP or ILSDI" - check_out: "Checking out an item" - renewal: "Renewing an item" - check_in: "Returning an item" When TrackLastPatronActivity is enabled and one or more of these triggers is selected, borrowers.lastseen will update when that trigger happens. This will only happen once per day as per the current method. If this structure/concept is approved then expanding it with further options should be fairly simple if required. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '23

14 Jun '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #38 from Matt Blenkinsop <matt.blenkinsop(a)ptfs-europe.com> --- Created attachment 152336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152336&action=e… Bug 15504: Add unit test prove -v t/db_dependent/Auth.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '23

14 Jun '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #37 from Matt Blenkinsop <matt.blenkinsop(a)ptfs-europe.com> --- Created attachment 152335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152335&action=e… Bug 15504: Remove update_lastseen method This patch removes update_lastseen which has been replaced by a call to track_login_daily -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '23

14 Jun '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #36 from Matt Blenkinsop <matt.blenkinsop(a)ptfs-europe.com> --- Created attachment 152334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152334&action=e… Bug 15504: Add triggers to instances of track_login_daily This patch adds a trigger to every instance of track_login_daily -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '23

14 Jun '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #35 from Matt Blenkinsop <matt.blenkinsop(a)ptfs-europe.com> --- Created attachment 152333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152333&action=e… Bug 15504: Update track_login_daily to accept triggers This patch adds triggers to track_login_daily so that it only tracks activity when that trigger is active -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '23

14 Jun '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #34 from Matt Blenkinsop <matt.blenkinsop(a)ptfs-europe.com> --- Created attachment 152332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152332&action=e… Bug 15504: Add new syspref TrackLastPatronActivityTriggers This patch adds a new syspref TrackLastPatronActivityTriggers to determine which actions should update borrowers.lastseen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '23

14 Jun '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Matt Blenkinsop <matt.blenkinsop(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 30928] New: Add interface to statistics table
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '23

14 Jun '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Bug ID: 30928 Summary: Add interface to statistics table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: hebah(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Many libraries are interested in seeing stats on the interfaces where transactions took place (staff intranet vs sip checkout, for example). Currently the only way to find that information is via action_logs, which means that data drops off eventually. It would be nice to have this information as part of statistics for ease of reporting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 51