- Koha-bugs - lists.koha-community.org

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com QA Contact| |kyle(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 33715] New: Unable to find default code
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33715 Bug ID: 33715 Summary: Unable to find default code Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: kohasupport(a)nlj.gov.jm QA Contact: testopia(a)bugs.koha-community.org Good day, I am trying to modify the current default css in the OPAC, however, the code is no where to be found in any of the css related fields. (opacuserCSS, OpacUserJS, etc). This is a new instance so no code is available in the Tool>News either. Thanks for your help. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #124 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 151026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151026&action=e… Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Laura Escamilla <laura.escamilla(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #112 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Working on fixes and will PQA with follow-ups. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #111 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 150256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150256 Bug 12532: Send email to guarantee and guarantor Review of attachment 150256: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=125…) ----------------------------------------------------------------- ::: Koha/Email.pm @@ +118,5 @@ > $args->{to} = $params->{to}; > } > > + my @emails = split(',', $args->{to}); > + foreach my $email (@emails) { This isn't required.. Email::Address handles formatted lists of addresses already. See: https://metacpan.org/pod/Email::Address#parse -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 [Bug 33223] Koha::Patron->notice_email_address isn't consistently used -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #110 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 150256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150256 Bug 12532: Send email to guarantee and guarantor Review of attachment 150256: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=125…) ----------------------------------------------------------------- I love where this is going... but I think it needs a few more little fixes to get it through. Happy to help work those in. ::: C4/Letters.pm @@ +1471,5 @@ > || $message->{to_address} ne $email->email->header('To'); > > + _update_message_from_address($message->{'message_id'},$email->email->header('From') ) > + if !$message->{from_address} > + || $message->{from_address} ne $email->email->header('From'); Not sure how this relates to the core bug here.. and I don't see any updated tests to show what this does either? ::: Koha/Email.pm @@ +118,4 @@ > $args->{to} = $params->{to}; > } > > + my @emails = split(',', $args->{to}); Interesting.. I thought we already supported multiple comma delimited to addresses.. this feels bad enough that we should have it on it's own bug really... but I'm happy to let that slide to get it in. ::: Koha/Patron.pm @@ +1439,5 @@ > + $address .= $guarantor_address if $guarantor_address; > + } > + } > + } > + return $address; I'd like to see this rebased against bug 33223 given it makes the use of notice_email_address more consistent generally. ::: installer/data/mysql/mandatory/sysprefs.sql @@ +597,4 @@ > ('RecallsMaxPickUpDelay','7',NULL,'Define the maximum time a recall can be awaiting pickup','Integer'), > ('RecordLocalUseOnReturn','0',NULL,'If ON, statistically record returns of unissued items as local use, instead of return','YesNo'), > ('Reference_NFL_Statuses','1|2',NULL,'Contains not for loan statuses considered as available for reference','Free'), > +('RedirectGuaranteeEmail', '0', NULL, 'Enable the ability to redirect guarantee email messages to guarantor.', 'YesNo'), Redirect seems like the wrong term here.. we're cc'ing in effect in the end.. so perhaps it should be renamed 'Copy' -- You are receiving this mail because: You are watching all bug changes.

1 0