- Koha-bugs - lists.koha-community.org

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #129 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 151088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151088&action=e… Bug 8179: Remove leftover/not used embed definitions Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #128 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 151087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151087&action=e… Bug 8179: Remove commented code Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #127 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 151086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151086&action=e… Bug 8179: Make partial receive work correctly Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29431] New: Hold queue does not consider expiration date
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29431 Bug ID: 29431 Summary: Hold queue does not consider expiration date Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: bwsdonna(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The holds queue does not take a hold expiration date into consideration. If a hold has an expiration date, the title will show on the queue as needed to be pulled, and when staff check it in, the hold is expired. For libraries that do not auto expire waiting holds, this is a problem. If a hold has an expiration date prior to the current date, it should not show as needing to be pulled, or have some sort of indicator the expiration date of the hold is passed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #119 from Blou <philippe.blouin(a)inlibro.com> --- Hello Martin, Thanks for the feedbacks AND the corrections. Now, as to your latest inquiry, I'm not the one who will answer it. But I'll give perspective. This has been coded about 10 years ago. A request from one of our clients that made a lot of sense to us. Then and now (frankly, sending email to guarantor is a VERY obvious requirement in the public libraries real world). But it was coded in a very different Koha, and the patches have tried to follow up in the last decade through a good dozen of our team members. The sponsor's money have long dried up, but the ticket is opened and we maintain it with the blind faith one day we won't have to rebase it for our own deliveries (were I to stop putting it on our pile one year and 20 libraries would notice me). So I don't know WHY things are like what they are. And I'm certain our current dev is not aware either. He'll modify what's asked to push it through, with no recoding/reachitecturing considered. I'm sorry nobody at inLibro can answer the questions you asked. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Hammat wele <hammat.wele(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele(a)inlibro.com --- Comment #50 from Hammat wele <hammat.wele(a)inlibro.com> --- I rebased the patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Hammat wele <hammat.wele(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148824|0 |1 is obsolete| | --- Comment #49 from Hammat wele <hammat.wele(a)inlibro.com> --- Created attachment 151079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151079&action=e… Bug 11300: Add a new authority linker which searches for authority links on a Z39.50 server. This patch adds a Z39.50 Linker which searches for authority links on a remote server. If a matching authority is found, it's imported in the local database for linking with the current biblio record. If no matching authority was found on the remote server, the Linker falls back to a local authority search. Configuration : * The option "Z39.50 Server" is added to the LinkerModule preference. You must choose this to use the new Linker. * The preference LinkerZ3950Server is required and specifies which server to use for linking. It must contain the "name" of the server, as defined in the z3950servers table. * You can set the "local_first" option in the LinkerOptions preference to force the Linker to search for authorities in the local database first. If no local authority match was found, the Linker falls back to a remote Z39.50 search. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 32929] New: ERM - 'Submit' button untranslatable
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32929 Bug ID: 32929 Summary: ERM - 'Submit' button untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Hopefully, this is a "me" problem, but for some reason, I can't get the "Submit" button in the ERM module to translate. To get to the button: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> "Submit" button is at the bottom of the form I found this string in the xx-XX-messages-js.po file (example in fr-CA, but I also tried in es-ES and de-DE) #: koha-tmpl/intranet-tmpl/prog/js/vue/dist/main.js:2 msgid "Submit" msgstr "Valider" I did ./translate install xx-XX but the button stays in English -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 33118] New: Bug 30472 provoke a DBI Exception when upgrading from 22.05.x to 22.11.02-1
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33118 Bug ID: 33118 Summary: Bug 30472 provoke a DBI Exception when upgrading from 22.05.x to 22.11.02-1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: pablo.bianchi(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Rising the comment 8 from bug 30472 to a new bug: Upgrading to 22.11.02-1 from an updated 22.05 on a Debian 11 crash with this error: Upgrade to 22.06.00.048 [18:33:27]: Bug 30472 - borrower_relationships.guarantor_id NOT NULL ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'guarantor_id': used in a foreign key constraint 'r_guarantor' at /usr/share/koha/lib/C4/Installer.pm line 739 Maybe is the same issue as on bug 32399?. One of the people who sent me a PM suggest a workaround: changing the DEFAULT to NOT on "`guarantor_id` int DEFAULT NULL,". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #126 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #125) > 1. > - b_sel => ( $budget->{budget_id} == $order->budget_id ) ? 1 : 0, > + # b_sel => ( $budget->{budget_id} == $order->budget_id ) ? 1 : 0, > > Then remove ;) Agreed. > 2. > + creator: > + type: > + - object > + - "null" > + description: Patron that created the order > > We could tell here we expect an object representing a patron It doesn't work. You cannot put a $ref and 'null', unfortunately. OpenAPI v3 might make it possible. > 3. > + - items.home_branch > + - items.holding_branch > + - items.itemtype > > Shouldn't they use the "fixed names"? home_library, item_type? That's a leftover, not even used and prior to the +strings addition. Will remove. > 4. https://snipboard.io/SvHwAn.jpg > The "Change currency" checkbox is not aligned properly > And it's actually not working: > * edit > * Set actual cost, check "change currency", select a currency, save > * edit again > => Values are not saved, you are actually breaking bug 25655. > Also I have seen "NaN" generated in actual cost but not sure when/how. > > And finally, values are not saved in the DB (invoice_currency, > invoice_unitprice). Will check. The most recent iteration got them flawed. > 5. Partial receive does not seem to work > I ordered 3, received 1, receiving again: > "Receiving 0 out of 2" => OK > Click edit > => There are 3 items in the items table Noted, it's a problem with how the post form is built (the items_to_receive array arrives empty to finishreceive.pl). Working on it > 6. "Date received:" does not have flatpickr applied > > 7. Fund is not marked "required" like before > > 8. We lost the "show active" checkbox next to the fund list > > 9. There are missing spaces after numbers "Retail price: 0.00(adjusted for > USD, tax exclusive)" > > 10. > + <th></th> > > Do we want that? > > 11. JS code in parcel.tt use 2 spaces indentation instead of 4 > > 12. I noticed 2 parallel request to parcel.pl?invoiceid=1 at the end of the > process, and one of them is aborted. This is what is in the console: > https://snipboard.io/IKwoVP.jpg > > 13. comment 111 and comment 112 still need an answer. > I don't understand how dataTables.select.min.js, select.dataTables.min.css > is useful here. Is that the row.select() and row.deselect() statements in > parcel.tt? If so, what are they doing? I removed them and didn't see any > issues. > > 14. There are several parts of the JS code in orderreceive.tt that are > commented, if we don't need them we should remove them. > > 15. I think we should widen the modal. The item form is not displayed nicely > https://snipboard.io/VIKAgY.jpg > > 16: not sure it's a blocker: When you select some orders, the table on the > order receive page has "Showing 1 to 1 of 1 entries (filtered from 3 total > entries)" > But there is no way to display them all. I understand why and what it > implies, just noting. > > 17. Another "just noting": the code (introduced by bug 20212 I think) > related to biblio.suggestions.suggester is bad and should have been > simplified before we did all this. I submitted a patch yesterday to remove > GetSuggestionInfoFromBiblionumber, it's on bug 28844. -- You are receiving this mail because: You are watching all bug changes.

1 0