- Koha-bugs - lists.koha-community.org

[Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...)
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33659 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33659 [Bug 33659] Using TT in CSV profiles is undocumented -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29942] New: Spurious commit in mysql session storage
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29942 Bug ID: 29942 Summary: Spurious commit in mysql session storage Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.jonsson(a)kreablo.se QA Contact: testopia(a)bugs.koha-community.org The DBI storage driver for CGI::Session commits any on-going transactions in its destructor subroutine. Consequently if SessionStorage is set to mysql, instantiating a session and assigning it to a local variable inside a transaction will unexpectedly cause the transaction to be committed as illustrated by the below script. I have reported this issue upstream and created pull requests but it is unclear if anyone is maintaining CGI::Session. https://rt.cpan.org/Ticket/Display.html?id=140855 https://github.com/cromedome/cgi-session/pull/5 We should maybe consider maintaining our own fork of CGI::Session. #!/usr/bin/perl -w use DBI; use C4::Auth; use Koha::Database; use strict; my $dbh = C4::Context->dbh; my $schema = Koha::Database->schema; print "SessionStorage: '" . C4::Context->preference('SessionStorage') . "'\n"; sub test { my $session = C4::Auth::get_session(""); } $dbh->do("CREATE TABLE IF NOT EXISTS `tmp_test_cgi_session` (foo TINYTEXT)"); eval { $schema->txn_do(sub { my $sth = $dbh->prepare("INSERT INTO `tmp_test_cgi_session` VALUES ('foo')"); $sth->execute(); test(); die "error"; }); }; if ($@) { print $@, "\n"; } my $sth = $dbh->prepare("SELECT * FROM `tmp_test_cgi_session`;"); $sth->execute(); # The INSERT of the foo row should have been rolled back, but isn't when # SessionStorage is 'mysql'. while (my $row = $sth->fetchrow_arrayref) { print $row->[0], "\n"; } $dbh->do("DROP TABLE `tmp_test_cgi_session`"); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 15428] Different timeout preference for OPAC and staff interface
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- But how do we know if it's an OPAC or a staff side cookie? Maybe naming the cookies differently and by that allowing to really have separate sessions independent of setup would be better. One reason to use ports is to block access to the staff interface in a firewall. It's a valid configuration option. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 32991] New: Improve our Dialog component and remove routes for deletion
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Bug ID: 32991 Summary: Improve our Dialog component and remove routes for deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com Agustin suggested some nice improvements on bug 32607 that would be great to have in a separate bug. We should embed the changes here, and eventually remove the specific routes (and components) we have to delete object. -- You are receiving this mail because: You are watching all bug changes.

1 122

[Bug 15428] Different timeout preference for OPAC and staff interface
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #17 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Katrin Fischer from comment #16) > (In reply to David Cook from comment #15) > > (In reply to Katrin Fischer from comment #14) > > > Not only for our use case - currently it's not possible to set different > > > timeouts even if you are using different sub domains which divides the > > > sessions. > > > > I'm not 100% sure I understand what you're saying. > > > > Different subdomains have different cookies, but in Koha there is only the > > "timeout" syspref. Is that what you mean? > > Yes. So if we added a new "opac_timeout" syspref and hooked it into the Auth system, we'd be able to have separate timeouts for OPAC and staff interface, but only for systems that have separate cookies for the OPAC and staff interface. I figure it's probably worth moving forward on that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 02 May '23

02 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #108 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jonathan Druart from comment #95) > (In reply to Martin Renvoize from comment #94) > > RM note.. the QA tool threw two issues.. POD coverage which is a false > > positive here I believe and a permissions issue.. but the permissions all > > look correct to me.. not sure what's going on there. > > FAIL t/db_dependent/Koha/AdditionalField.pm > FAIL file permissions > File must not have the exec flag > > Well, this is valid: > -rwxr-xr-x 1 jonathan jonathan 2506 mai 2 11:51 > t/db_dependent/Koha/AdditionalField.pm > > Actually I guess it should be renamed to .t Small rebase (conflicts in the USE statements, not hard), fixed the test, unit and QA tests pass now. Also did some tests in the GUI. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 02 May '23

02 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #107 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 150548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150548&action=e… Bug 11844: (QA follow-up) Fix unit test file ending t/db_dependent/Koha/AdditionalField.pm -> t/db_dependent/Koha/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 02 May '23

02 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149692|0 |1 is obsolete| | --- Comment #106 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 150547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150547&action=e… Bug 11844: Add tests for marcfield_mode Signed-off-by: Michaela Sieber <michaela.sieber(a)kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 02 May '23

02 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149691|0 |1 is obsolete| | --- Comment #105 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 150546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150546&action=e… Bug 11844: Add tests for TransferOrder Signed-off-by: Michaela Sieber <michaela.sieber(a)kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 02 May '23

02 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149690|0 |1 is obsolete| | --- Comment #104 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 150545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150545&action=e… Bug 11844: Add tests for Koha::AdditionalField Signed-off-by: Michaela Sieber <michaela.sieber(a)kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0