- Koha-bugs - lists.koha-community.org

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 01 May '23

01 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #34 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 150448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150448&action=e… Bug 6796: Fix saving of libraries and tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 01 May '23

01 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #33 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 150447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150447&action=e… Bug 6796: Fix atomic updates -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 01 May '23

01 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #32 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 150446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150446&action=e… Bug 6796: Updated schema files -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 01 May '23

01 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146991|0 |1 is obsolete| | --- Comment #31 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 150445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150445&action=e… Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 01 May '23

01 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146990|0 |1 is obsolete| | --- Comment #30 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 150444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150444&action=e… Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 01 May '23

01 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146989|0 |1 is obsolete| | --- Comment #29 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 150443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150443&action=e… Bug 6796: ConsiderLibraryHoursWhenIssuing system preference -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 01 May '23

01 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146988|0 |1 is obsolete| | Attachment #146992|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 150442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150442&action=e… Bug 6796: Add branch_hours table and set opening hours for library -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 01 May '23

01 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15428] Different timeout preference for OPAC and staff interface
by bugzilla-daemon＠bugs.koha-community.org 01 May '23

01 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #13 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Katrin Fischer from comment #12) > You are right that different subdomains will create separate sessions, but I > think the 99% is wrong. Koha used ports for a long time in its default setup > and there are still reasons why you would want to do so. We do, with > packages, use ports, for the installations we support. > > And it doesn't solve the problem here... different sessions, one timeout. > How could you attach a different timeout to each? For your case, I think you'd need different cookie names for OPAC and Staff. Mostly would involve refactoring... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 01 May '23

01 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #240 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Katrin Fischer from comment #236) > (In reply to Nick Clemens from comment #235) > > (In reply to Aleisha Amohia from comment #234) > > > There are lots of signoffs on these patches, can this be marked Passed QA? > > > > Hi Aleisha, > > > > It appears I was wrong in comment 187, see comment 222 > > > > It is a question of how the fallback should work, so we either need a DB > > update, or to change the expectation for when a rule is not set > > It sounds like this needs a little bit more work? Attached an atomic update patch, not sure how it affects the bug status. -- You are receiving this mail because: You are watching all bug changes.

1 0