- Koha-bugs - lists.koha-community.org

[Bug 43027] New: Handle undecodable metadata gracefully when merging bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '26

12 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43027 Bug ID: 43027 Summary: Handle undecodable metadata gracefully when merging bibliographic records Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)openfifth.co.uk QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Depends on: 35104 Target Milestone: --- Merging into a reference record calls ModBiblio, which can now throw Koha::Exceptions::Metadata::Invalid (bug 35104) if the merged result cannot be saved. cataloguing/merge.pl did not handle this, so the cataloguer would see a raw exception with no indication of what happened to the merge. This patch catches the exception, aborts the merge (the reference record was not modified, since ModBiblio failed before anything was merged away), and shows a clear message. A recoverable fault fixed during the merge is shown as a warning instead, the same as the cataloguing edit form (bug 43025). Depends on bug 35104. Test plan: 1. Apply this patch on top of bug 35104. 2. Merge two normal bibliographic records as usual. Confirm the merge still completes successfully and the report screen displays as before. 3. Arrange for the merge result to be unrecoverable (e.g. temporarily force Koha::Biblio::Metadata::store to throw Koha::Exceptions::Metadata::Invalid for this merge). Attempt the merge. Confirm a clear error is shown, the reference record is unchanged, and no partial merge occurred (the other record(s) were not deleted/merged away). 4. Arrange for the merge result to require automatic repair (a recoverable fault). Confirm the merge completes and the report screen shows a warning describing what was fixed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 43029] New: Guard maintenance scripts against biblios with corrupt metadata
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '26

12 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43029 Bug ID: 43029 Summary: Guard maintenance scripts against biblios with corrupt metadata Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)openfifth.co.uk QA Contact: testopia(a)bugs.koha-community.org Depends on: 35104 Target Milestone: --- Bug 35104 makes Koha::Biblio::Metadata->record()/store() throw Koha::Exceptions::Metadata::Invalid for a record whose MARCXML cannot be decoded. misc/maintenance/sanitize_records.pl and misc/maintenance/touch_all_biblios.pl both read a biblio's metadata record and unconditionally re-save it across every biblio in the database, so a single already-corrupt record (which could exist from before bug 35104, or from a source outside Koha's own validation) would abort the whole run. This patch wraps the read (and, for touch_all_biblios.pl, the resulting ModBiblio) so one such biblio is skipped and reported rather than aborting the whole maintenance run. Depends on bug 35104. Test plan: 1. Apply this patch on top of bug 35104. 2. Create a biblio with metadata that is already corrupt, bypassing Koha::Biblio::Metadata's validation (e.g. write invalid MARCXML directly to the biblio_metadata row via the DBIC schema result, not through ->store()), alongside several normal biblios. 3. Run misc/maintenance/sanitize_records.pl --verbose across all biblios. Confirm the corrupt one is skipped with a clear "ERROR: Invalid record" message and the script completes for every other biblio without dying. 4. Run misc/maintenance/touch_all_biblios.pl similarly. Confirm the corrupt record is counted/logged as an error and the other records are still touched successfully. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 43028] New: Isolate one undecodable record from aborting a batch import or revert
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '26

12 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43028 Bug ID: 43028 Summary: Isolate one undecodable record from aborting a batch import or revert Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)openfifth.co.uk QA Contact: testopia(a)bugs.koha-community.org Depends on: 35104 Target Milestone: --- Bug 35104 makes Koha::Biblio::Metadata->store() throw Koha::Exceptions::Metadata::Invalid for MARCXML it cannot save. Batch import (C4::ImportBatch::BatchCommitRecords/_batchCommitItems), batch revert (BatchRevertRecords), the corresponding background jobs, the CLI tools built on them (misc/commit_file.pl, misc/migration_tools/bulkmarcimport.pl), and Koha::Import::Record::get_marc_record all needed updating so one bad record doesn't take the rest of the batch down with it. This patch: - Catches the exception per-record in BatchCommitRecords (which already commits per-record) and per-item in _batchCommitItems, flagging the record/item with an 'error' status and message and counting it via a new $num_errored return value, instead of letting it propagate. - Does the same for BatchRevertRecords, which runs as a single whole-batch transaction: both the marcxml_old decode step and the ModBiblio/ModAuthority call that follows it are isolated, so one record that can't be restored doesn't roll back every other record already reverted in the same batch. - Threads the new error counts through Koha::BackgroundJob::MARCImportCommitBatch/RevertBatch's job report, and counts errored records towards job progress so a batch containing them doesn't get stuck showing as still running. - Reports the new counts in misc/commit_file.pl's CLI summary and logs a warning line for records automatically repaired during bulkmarcimport.pl. - Surfaces each errored row's reason as a tooltip on its "Error" status badge in the manage-marc-import listing. - Makes Koha::Import::Record::get_marc_record reuse Koha::Biblio::Metadata::repair_marcxml (bug 35104) instead of its own weaker strip-and-retry, so staged import records get the same recovery (including empty-datafield handling) as the interactive cataloguing form. Depends on bug 35104. Test plan: 1. Apply this patch on top of bug 35104. 2. Stage a MARC file for import (Tools > Stage MARC records for import) containing at least one deliberately malformed record (e.g. a datafield with no subfields, or invalid control characters that cannot be repaired) alongside normal records. 3. From Manage staged records, commit the batch. Confirm: the bad record is flagged with an 'error' status and a tooltip explaining why; every other record in the batch imports successfully; the job report/CLI summary shows a "Number of records with errors" count. 4. Revert the same batch. Confirm one record whose marcxml_old cannot be restored does not prevent the rest of the batch from reverting, and the job report reflects the error count. 5. Run misc/migration_tools/bulkmarcimport.pl from the CLI against a file containing a record with a recoverable fault (e.g. a non-XML character). Confirm a WARNING line is logged for that record and the import otherwise completes normally. 6. prove t/db_dependent/ImportBatch.t t/db_dependent/Koha/BackgroundJob/MARCImportCommitBatch.t Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 43026] New: Show metadata repair warnings on the biblio detail and MARC detail pages
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '26

12 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43026 Bug ID: 43026 Summary: Show metadata repair warnings on the biblio detail and MARC detail pages Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)openfifth.co.uk QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Depends on: 35104 Target Milestone: --- Bug 35104 records unresolved metadata repair faults (e.g. stripped non-XML characters) in biblio_metadata_errors. Cataloguers reviewing a record via catalogue/detail.pl or catalogue/MARCdetail.pl, rather than opening it for editing, currently have no way to know it was automatically repaired on its last save. This patch lists any unresolved biblio_metadata_errors as a warning banner on both pages. Depends on bug 35104. Test plan: 1. Apply this patch on top of bug 35104. 2. Using a biblio with at least one unresolved metadata error (see bug 35104's test plan for how to create one), open catalogue/detail.pl?biblionumber=X. Confirm the warning banner listing the fault appears. 3. Open catalogue/MARCdetail.pl?biblionumber=X for the same biblio. Confirm the same warning appears there too. 4. Open a biblio with no metadata errors on either page. Confirm no warning banner appears. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 30

[Bug 43777] New: Koha::Biblio::Metadata->record should repair recoverable MARCXML faults on read
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '26

12 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43777 Bug ID: 43777 Summary: Koha::Biblio::Metadata->record should repair recoverable MARCXML faults on read Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)openfifth.co.uk QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Bug 35104 stops MARCXML with non-XML characters or empty datafields from being saved, by repairing it in Koha::Biblio::Metadata->store() and recording what was fixed. Data that was already in the database before that (or that arrived by scripts or direct SQL outside Koha) can still be undecodable, and every place that reads it has to cope. The follow-up bugs for 35104 (43025, 43026, 43027, 43028, 43029, ...) are each re-implementing the same handling: eval { $metadata->record }, catch Koha::Exceptions::Metadata::Invalid, try repair_marcxml, fall back to record_strip_nonxml, then render the per-fault warnings in their own template. record_strip_nonxml also overlaps repair_marcxml, but only handles one of its two faults. Proposal: make the read path repair the same faults as store(). - Koha::Biblio::Metadata->record falls back to repair_marcxml when the stored MARCXML cannot be decoded, and returns the repaired MARC::Record. - The faults that were repaired are reported through object_messages, the same way store() reports them, so callers that want to tell the user can, and callers that do not care simply ignore them. record still returns a single value (no context-sensitive return). - Metadata that cannot be recovered still throws Koha::Exceptions::Metadata::Invalid. - The repair is not written back to the database; store() remains the only place that writes biblio_metadata_errors rows. - record_strip_nonxml is removed and its callers use record. - A shared template include renders the repair messages so the follow-up bugs do not each carry their own copy. Test plan: 1. Apply the patches on top of bug 35104. 2. prove t/db_dependent/Koha/Biblio/Metadata.t 3. Write MARCXML containing a control character (e.g. U+001F) or an empty datafield straight into biblio_metadata.metadata with SQL, then call $biblio->metadata->record and confirm a MARC::Record is returned and object_messages describes the repair. 4. Confirm unrecoverable MARCXML still throws Koha::Exceptions::Metadata::Invalid. 5. prove t/db_dependent/Biblio.t t/db_dependent/OAI/Server.t t/db_dependent/Exporter/Record.t Sponsored-by: OpenFifth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 43781] New: Update syntax for overriding sysprefs from Apache config
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '26

12 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43781 Bug ID: 43781 Summary: Update syntax for overriding sysprefs from Apache config Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- Bug 10325 made it possible to override sysprefs from the Apache config. Today there are two template Apache config files: debian/templates/apache-site-https.conf.in does not contain information about overriding sysprefs. etc/koha-httpd.conf has this: # This syntax allows you to override a system preference # for a given virtual host. Use with caution! # You should add all the system preferences you override # in one or more vhosts to the environment variable # OVERRIDE_SYSPREF_NAMES for your staff intranet vhost # SetEnv OVERRIDE_SYSPREF_PrefName Value and this: # Repeat this virtualhost stanza changing the following environment vars to # create multiple OPAC interfaces with custom css and/or search limits: # SetEnv OPAC_CSS_OVERRIDE mystyle.css # SetEnv OPAC_SEARCH_LIMIT branch:CODE # SetEnv OPAC_LIMIT_OVERRIDE 1 and this: # If you are overriding any system preferences, # list them in this variable so the preference editor # knows that they have been overridden. # SetEnv OVERRIDE_SYSPREF_NAMES "Pref1,Pref2,Pref3" But the syntax for the syspref overrides has been changed, as shown here: https://wiki.koha-community.org/wiki/Override_sysprefs_in_Apache_config -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 41199] New: Advanced Search fields could use more visible label options
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '26

12 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Bug ID: 41199 Summary: Advanced Search fields could use more visible label options Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs(a)lists.koha-community.org Reporter: jake.deery(a)openfifth.co.uk QA Contact: testopia(a)bugs.koha-community.org CC: martin.renvoize(a)openfifth.co.uk, matt.blenkinsop(a)openfifth.co.uk, oleonard(a)myacpl.org The advanced search & search masthead could both do with more visible labels. This aids users in navigating the system, and also helps to provide screen readers with more context about an input field. We should offer a syspref that controls the number of visible labels, so libraries can have greater control over the extent of these labels. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 34421] New: Add option to include a 'Search library groups' dropdown in catalogue-search-box.inc
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '26

12 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34421 Bug ID: 34421 Summary: Add option to include a 'Search library groups' dropdown in catalogue-search-box.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Some libraries would like to be able to search within library groups from the main catalog search. We should add a dropdown that can be toggled on/off via a system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 43780] New: Add staff search groups to IntranetAddMastheadLibraryPulldown
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '26

12 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43780 Bug ID: 43780 Summary: Add staff search groups to IntranetAddMastheadLibraryPulldown Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: hebah(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- Bug 9257 added OPAC search groups to the OPAC masthead, but the staff search groups are only accessible in advanced search. Consortial libraries would especially benefit from the ability to search library groups more easily. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 37645] New: Add ability to batch waive fines
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '26

12 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37645 Bug ID: 37645 Summary: Add ability to batch waive fines Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: enica(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It would be nice if there's an ability in Koha to waive fines/fees in a batch. This is part of a regular workflow for libraries, especially those who regularly purge patron accounts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 78