- Koha-bugs - lists.koha-community.org

[Bug 22279] New: Unify patron name display
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279 Bug ID: 22279 Summary: Unify patron name display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: pasi.kallinen(a)koha-suomi.fi QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- The way patron's name is displayed should be unified into a single place. There's template code in patron-title.inc for it, but it's not used in enough places. Using that would make the patron name display consistent, and if change is needed (eg. for GDPR), it would be easy to change. For example: koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc: <li><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber | uri %]&findborrower=[% holdfor_cardnumber | uri %]">Place hold for [% holdfor_firstname | html %] [% holdfor_surname | html %] ([% holdfor_cardnumber | html %])</a></li> koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc: .append( "<a>" + item.surname + ", " + item.firstname + " (" + item.cardnumber + ") <small>" + item.dateofbirth + " " + item.address + " " + item.city + " " + item.zipcode + " " + item.country + "</small></a>" ) koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc: <td><a href="[% data_url | url %]">[% borrower.surname | html %], [% borrower.firstname | html %]</a></td> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt: <title>Summary for [% patron.firstname | html %] [% patron.surname | html %] ([% patron.cardnumber | html %])</title> koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt: <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% patron.borrowernumber | uri %]">Pay fines for [% patron.firstname | html %] [% patron.surname | html %]</a> &rsaquo; and many, many more. -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 30072] New: Add more holds hooks
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '22

27 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Bug ID: 30072 Summary: Add more holds hooks Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We should add more plugin hooks. At least: - after_hold_fill - after_hold_cancel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 48

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #143 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133988&action=e… Bug 14242: (follow-up) Clear all text input fields Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #142 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133987&action=e… Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #141 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133986&action=e… Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131219|0 |1 is obsolete| | Attachment #131220|0 |1 is obsolete| | Attachment #131221|0 |1 is obsolete| | Attachment #131222|0 |1 is obsolete| | --- Comment #140 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133985&action=e… Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACSuggestionAutoFill" 3. Log into OPAC and go to purchase suggestions page 4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into the ISBN field and click the 'search google books' button, or unfocus the field. 5. Title, Author, Publisher, publication year and Item Type fields should now be filled automatically. 6. Press "clear form" to undo - should restore all fields that the API pull filled to empty Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #187 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133957&action=e… Bug 12446: Fixing QA tool's tests This patch fixes tests that fails by the QA test tool. I removed the debug variable, since it is not used. I also got a few spelling check errors when I ran the QA test tool. I corrected them too. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" on the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. 16) prove t/db_dependent/Patrons.t => All tests should still pass 17) Run the QA test tool. All tests should say OK Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #186 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133956&action=e… Bug 12446: Any patron categories can have guarantors Rebase of previous patches This patch allows adult patrons to have guarantors. It adds the field "Can be guarantee" to patron categories, so it becomes possible for any category type to have a guarantor. NOTE: Attachment "Bug 12446: Adult can now have guarantors" created a sha1 error. I marked it as obsolete and put it's content into a new commit. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" gor the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. 16) prove t/db_dependent/Patrons.t => All tests should still pass Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '22

26 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #185 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 133955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133955&action=e… Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0