- Koha-bugs - lists.koha-community.org

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125387|0 |1 is obsolete| | --- Comment #149 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 128320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128320&action=e… Bug 13952: (follow-up) template filters, moving js to separate file This patch adds filters to the template file and moves the JS into a separate file. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125386|0 |1 is obsolete| | --- Comment #148 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 128319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128319&action=e… Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125385|0 |1 is obsolete| | --- Comment #147 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 128318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128318&action=e… Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125384|0 |1 is obsolete| | --- Comment #146 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 128317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128317&action=e… Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125383|0 |1 is obsolete| | --- Comment #145 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 128316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128316&action=e… Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27673] New: Replace YAML with YAML::XS
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Bug ID: 27673 Summary: Replace YAML with YAML::XS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 26633 >From tht YAML pod: """ This module has been released to CPAN as YAML::Old, and soon YAML.pm will be changed to just be a frontend interface module for all the various Perl YAML implementation modules, including YAML::Old. If you want robust and fast YAML processing using the normal Dump/Load API, please consider switching to YAML::XS. It is by far the best Perl module for YAML at this time. It requires that you have a C compiler, since it is written in C. """ See also https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/35 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 [Bug 26633] Add advanced editor for transfer limits -- You are receiving this mail because: You are watching all bug changes.

1 52

[Bug 9805] Lost items are un-lost if returned, but not if renewed
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion CC| |joy(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29651] New: Add a note field to invoices
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29651 Bug ID: 29651 Summary: Add a note field to invoices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org It would be great if there was a note field for storing additional information for notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 17269] New: Library::CallNumber:: LC does not follow LC standards for Area Subarrangments of cataloged maps
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '21

06 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17269 Bug ID: 17269 Summary: Library::CallNumber::LC does not follow LC standards for Area Subarrangments of cataloged maps Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Library::CallNumber::LC is used to generate cn_sort for Library of Congress callnumbers. According to the LC document "Special Instructions and Tables of Subdivisions for Cartographic Materials", in the section 'Area Subarrangments' The document can be found at http://www.loc.gov/catdir/cpso/class_g.pdf; see page 6: "Regions and political divisions within a city or town may be classified with the use of a colon (:) followed by the number 2 or 3, indicating whether the subdivision is (2) geographic or (3) political and a Cutter number for the subdivision. Examples: G4364 California (map city and town number) .L8:2G7 Los Angeles, Griffith Park (classified as a region) G4114 Michigan (map city and town number) .E4:2M4 East Lansing, Michigan State University (classified as a region) G3804 New York State (map city and town number) .N4:3Q4 New York City, Queens (classified as a political division) " When I use Library::CallNumber::LC::Normalize(), 'G4364 .L8:2G7' and 'G4364 .L8' generate entirely different call numbers: Library::CallNumber::LC->normalize("G4364 .L8:2G7") => G4364 .L00008:00002G00007 Library::CallNumber::LC->normalize("G4364 .L8") => G4364 L8 If I'm reading the Library of Congress instructions instructions correctly, I believe that "G4364 .L8:2G7" should generate as "G4364 L8:2G7", which would sort after "G4364 L8", whereas "G4364 .L00008:00002G00007" sorts before "G4364 L8". I'm also filing a bug with the module maintainer: https://github.com/libraryhackers/library-callnumber-lc/issues/10 -- You are receiving this mail because: You are watching all bug changes.

1 8