- Koha-bugs - lists.koha-community.org

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #158 from Michal Denar <black23(a)gmail.com> --- Created attachment 128329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128329&action=e… Bug 13952: (follow-up) Tests Run: prove -v t/db_dependent/ImportExportFramework.t and confirm all tests pass. I've also added a fix to remove the warns when exporting in ODS format. Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #157 from Michal Denar <black23(a)gmail.com> --- Created attachment 128328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128328&action=e… Bug 13952: (follow-up) template filters, moving js to separate file This patch adds filters to the template file and moves the JS into a separate file. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #156 from Michal Denar <black23(a)gmail.com> --- Created attachment 128327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128327&action=e… Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #155 from Michal Denar <black23(a)gmail.com> --- Created attachment 128326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128326&action=e… Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #154 from Michal Denar <black23(a)gmail.com> --- Created attachment 128325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128325&action=e… Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128316|0 |1 is obsolete| | Attachment #128317|0 |1 is obsolete| | Attachment #128318|0 |1 is obsolete| | Attachment #128319|0 |1 is obsolete| | Attachment #128320|0 |1 is obsolete| | Attachment #128321|0 |1 is obsolete| | Attachment #128322|0 |1 is obsolete| | Attachment #128323|0 |1 is obsolete| | --- Comment #153 from Michal Denar <black23(a)gmail.com> --- Created attachment 128324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128324&action=e… Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125390|0 |1 is obsolete| | --- Comment #152 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 128323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128323&action=e… Bug 13952: (follow-up) fixing indentation and rebasing Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125389|0 |1 is obsolete| | --- Comment #151 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 128322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128322&action=e… Bug 13952: (follow-up) Removing XML options Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '21

07 Dec '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125388|0 |1 is obsolete| | --- Comment #150 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 128321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128321&action=e… Bug 13952: (follow-up) Tests Run: prove -v t/db_dependent/ImportExportFramework.t and confirm all tests pass. I've also added a fix to remove the warns when exporting in ODS format. Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0