- Koha-bugs - lists.koha-community.org

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #45 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Jonathan Druart from comment #44) > Created attachment 125951 [details] [review] > Bug 3142: Handle biblio level item type Something like that? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #44 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 125951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125951&action=e… Bug 3142: Handle biblio level item type -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #43 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Marcel de Rooy from comment #42) > while ( my $item = $items->next ) { > - $norequests = 0 > - if $norequests > - && !$item->withdrawn > - && !$item->itemlost > - && ($item->notforloan < 0 || not $item->notforloan ) > - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan > - && $item->itemnumber; > - > $allow_onshelf_holds = Koha::CirculationRules->get_onshelfholds_policy( > { item => $item, patron => $patron } ) > unless $allow_onshelf_holds; > > Could this loop be done smarter now? We could certainly have get_onshelfholds_policy take a Koha::Items iterator and do things there to avoid the while. > opac/opac-ISBDdetail.pl > - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan > opac/opac-MARCdetail.pl > - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan > opac-detail.pl > - && !$itemtypes->{$itm->{'itype'}}->{notforloan} > Added a follow-up that looks at notforloan but effective is still another > story. Good catch. Isn't it blocker? Looks like a regression :-/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #42 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- while ( my $item = $items->next ) { - $norequests = 0 - if $norequests - && !$item->withdrawn - && !$item->itemlost - && ($item->notforloan < 0 || not $item->notforloan ) - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan - && $item->itemnumber; - $allow_onshelf_holds = Koha::CirculationRules->get_onshelfholds_policy( { item => $item, patron => $patron } ) unless $allow_onshelf_holds; Could this loop be done smarter now? opac/opac-ISBDdetail.pl - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan opac/opac-MARCdetail.pl - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan opac-detail.pl - && !$itemtypes->{$itm->{'itype'}}->{notforloan} Added a follow-up that looks at notforloan but effective is still another story. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 125950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125950&action=e… Bug 3142: (QA follow-up) Include notforloan itemtypes As was done in the code already. Note that we are ignoring effective itemtype now. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 125949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125949&action=e… Bug 3142: (QA follow-up) Cosmetic changes Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125734|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 125948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125948&action=e… Bug 3142: Add note about imprecision of filter_by_for_hold Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125733|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 125947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125947&action=e… Bug 3142: Add test for the circ rule Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125732|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 125946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125946&action=e… Bug 3142: Add tests And fix a bug! Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125730|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 125945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125945&action=e… Bug 3142: Use filter_by_for_holds where holdability is calculated Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0