- Koha-bugs - lists.koha-community.org

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #31 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Marcel de Rooy from comment #27) > (In reply to Jonathan Druart from comment #25) > > (In reply to Marcel de Rooy from comment #23) > > > + my @hold_not_allowed_itypes = Koha::CirculationRules->search( > > > + { > > > + rule_name => 'holdallowed', > > > + branchcode => undef, > > > + categorycode => undef, > > > + rule_value => 'not_allowed', > > > + } > > > + )->get_column('itemtype'); > > > > > > I have my doubts here btw. > > > This is too simple. You are looking at circ rules with exception for various > > > combinations of category, itemtype etc. > > > You cant just do a get_column here. This depends on context. > > > Please clarify and add tests. > > > > Which context? The logged in branch? > > Here we are not in C4::Reserves, we don't want to offer all the complexity > > of CanItemBeReserved. As said previously I am not adding new code of > > functionality (apart for the additional damaged check). > > Ok. If this is a reflection of what we did already, I cant justify to fail > it :) Koha never fails! > Back to SO lol I am feeling your sarcasms, Marcel :) I will be happy to improve anything you think that may be useful. But keep in mind that the point here is only to centralize things. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #30 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 125734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125734&action=e… Bug 3142: Add note about imprecision of filter_by_for_hold -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #29 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 125733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125733&action=e… Bug 3142: Add test for the circ rule -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs(a)lists.koha-commun |m.de.rooy(a)rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #28 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Will QA this one soon. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #25) > (In reply to Marcel de Rooy from comment #23) > > + my @hold_not_allowed_itypes = Koha::CirculationRules->search( > > + { > > + rule_name => 'holdallowed', > > + branchcode => undef, > > + categorycode => undef, > > + rule_value => 'not_allowed', > > + } > > + )->get_column('itemtype'); > > > > I have my doubts here btw. > > This is too simple. You are looking at circ rules with exception for various > > combinations of category, itemtype etc. > > You cant just do a get_column here. This depends on context. > > Please clarify and add tests. > > Which context? The logged in branch? > Here we are not in C4::Reserves, we don't want to offer all the complexity > of CanItemBeReserved. As said previously I am not adding new code of > functionality (apart for the additional damaged check). Ok. If this is a reflection of what we did already, I cant justify to fail it :) Koha never fails! Back to SO -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #26 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 125732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125732&action=e… Bug 3142: Add tests And fix a bug! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #25 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Marcel de Rooy from comment #23) > + my @hold_not_allowed_itypes = Koha::CirculationRules->search( > + { > + rule_name => 'holdallowed', > + branchcode => undef, > + categorycode => undef, > + rule_value => 'not_allowed', > + } > + )->get_column('itemtype'); > > I have my doubts here btw. > This is too simple. You are looking at circ rules with exception for various > combinations of category, itemtype etc. > You cant just do a get_column here. This depends on context. > Please clarify and add tests. Which context? The logged in branch? Here we are not in C4::Reserves, we don't want to offer all the complexity of CanItemBeReserved. As said previously I am not adding new code of functionality (apart for the additional damaged check). Tests are definitely missing, agreed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '21

05 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #24 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Marcel de Rooy from comment #22) > (In reply to Martin Renvoize from comment #21) > > This works well and certainly clarifies the code.. it does need tests still > > though ;) > > If it does, we cant get it further from here? What do you suggest? I didn't get what suggested David in comment 9. The unique ambition of these patches is to reuse an existing method and avoid duplication of code. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0