- Koha-bugs - lists.koha-community.org

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '21

28 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115384|0 |1 is obsolete| | --- Comment #139 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 125386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125386&action=e… Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '21

28 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115383|0 |1 is obsolete| | --- Comment #138 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 125385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125385&action=e… Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '21

28 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115382|0 |1 is obsolete| | --- Comment #137 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 125384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125384&action=e… Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '21

28 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115381|0 |1 is obsolete| | --- Comment #136 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 125383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125383&action=e… Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '21

28 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #132 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Victor Grousset/tuxayo from comment #128) > a. > That's odd, I'm getting the autofill even with OPACSuggestionAutoFill off. > Fixed in latest follow-up > > b. > > press the edit icon next to the field > > Where is the icon actually? Is that the Search Google Books button? A step from an old test plan - yes it is the search button, I've reworded the test plan. > > c. > Maybe an issue > > > d. > Found something else that should be related and easy to reproduce > > e. > When clearing the form, should the ISBN also be cleared? I've added a follow-up to clear the ISBN. > > > f. > I can still reproduce the issue from comment 117 I was not able to reproduce c, d or f. Can you please re-test? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '21

28 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #131 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 125382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125382&action=e… Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '21

28 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116989|0 |1 is obsolete| | --- Comment #130 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 125381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125381&action=e… Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '21

28 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116712|0 |1 is obsolete| | --- Comment #129 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 125380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125380&action=e… Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACSuggestionAutoFill" 3. Log into OPAC and go to purchase suggestions page 4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into the ISBN field and click the 'search google books' button, or unfocus the field. 5. Title, Author, Publisher, publication year and Item Type fields should now be filled automatically. 6. Press "clear form" to undo - should restore all fields that the API pull filled to empty Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '21

28 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 28 Sep '21

28 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #62 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Owen Leonard from comment #60) > I get an error from the opac-sendbasket popup whether or not I'm logged in: > > Could not compile /kohadevbox/koha/opac/opac-sendbasket.pl: syntax error at > /kohadevbox/koha/opac/opac-sendbasket.pl line 122, near "else" > BEGIN not safe after errors--compilation aborted at > /kohadevbox/koha/opac/opac-sendbasket.pl line 137. Have fixed > > The QA tool also raises several warnings. The QA test tools all pass for me - can you please paste the output? -- You are receiving this mail because: You are watching all bug changes.

1 0