- Koha-bugs - lists.koha-community.org

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '26

25 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #743 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204151&action=e… Bug 10190: (QA follow-up): fixes phase four - Display new manage_circ_triggers permission (add to template) - Ensure loading messages are informative to the user Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '26

25 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #742 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204150&action=e… Bug 10190: (follow-up): test: cypress tests update New tests: - regression: mtt cells render as .fallback (bold italics) - bg-success-subtle highlight on completed steps in the add flow - disabled-Delete states: - patron category filter set - item type filter set - default library, if any library has a trigger higher that default's highest - redirect to admin home if not permitted to access the page - in the edit/add stepper form - check row actions are enabled at the 'selectOrAdd' step - check row actions are disabled once add mode is entered - check the action column is always available on the main page Clean up / general updates: - replace the /api/v1/** catch-all intercept with per-endpoint intercepts so @get-rules waits resolve reliably - remove now-redundant cy.wait("@get-rules") calls - drop unused mount / dayjs / dates imports - ensure expected strings match UI where strings have changed Assisted-by: Claude Opus 4.7 (Anthropic) AI used to draft enhancements tests. Changes were reviewed, tweaked, and commited manually and gradually (with a pre-submission commit squash). Tests were run multiple times and adjusted iteratively to match code changes, cover regressions as those were found, and handle vue page load. Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '26

25 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #741 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204149&action=e… Bug 10190 (QA follow-up): UI/UX improvements and fixes - phase three Trigger deletion and rule set reset - warn the user that resetting or deleting a given set will break sets using it as fallback. - indicate which sets will be affected. - display a preview of the post reset state of each affected rule set. - preparation: allow TriggerTable to take a title parameter. - refactor to remove 'has_rules' from the store's rule suffixes list so those match the DB. - DRY: refactor to implement TriggerTable rather than use custom templates. - select context stage handles narrower viewports - prevent crash on missing rule set TriggersTable: refactor: the <a> elements used as buttons are now button elements - this is so they may be marked as disabled. Main page - trigger actions (delete button display) - disable the trigger deletion button. - if the context has been narrowed down ('delete' deletes all explicit rule set per trigger per library). - if the trigger belongs to default library AND one or more libraries have a trigger of a number bigger than the selected one. This is to protect trigger sequentiality from being broken for the relevant libraries. We also include an on hover message to explain the disabled button. Add/ Edit trigger form - clarify letters 'undo' button behaviour: - swap the native vue select X for a fa-undo icon. - display 'undo override and reset to fallback' on hover. - only display the add/edit button at the selectOrAdd step. - restore selected trigger yellow highlight (regression fix). - display any temporarily saved data from prior step in a green 'success' container. - only messages and data pulled from the DB for informative purposes display in blue containers. Other - redirect to correct URL (admin home) if store load fails - mtt fallbacks display as such consistently (bold italics) - is a bugfix. - catch errors on store initialisation - remove whitespace duplicate - ensure that mtt, if set, always display Assisted-by: Claude Opus 4.7 (Anthropic) AI used to help trace back potential bug sources, flag potential regressions, and draft enhancements. Changes were reviewed, tweaked, and commited manually and gradually (with a pre-submission commit squash). Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '26

25 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #740 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204148&action=e… Bug 10190: (QA follow-up): UI/UX bug fixes - phase two Fix: handle exiting modal - prevent data reload when the user exits the modal - as preparation for the above: refactor to use one handler only Fix: new trigger saves with delay defined - Identified an old refactor omission - we were still passing 'i' despite the from now relying on this.triggerNumber Fix: return to correct trigger tab after save or reset Fix: restore delete button and bold italic info - restore display, fixes a regression introduced by the previous UI/UX patch set Fix: order dropdown options by description or name (not code) Fix: circ rule resets - restore reset funtionality (mtt was still occasionally passed as a string, and would then get compared to an array. Ensure this is not the case.) - do not trigger the data refresh if the current ruleset did not get deleted - make sure triggerNumber is defined when navigation is caused by reset - add the notice code in brackets to letter names for display (eg. Overdue notice (ODUE)) Assisted-by: Claude Opus 4.6 (Anthropic) AI used to help trace back potential bug sources and draft fixes. Changes were reviewed, tweaked, and commited manually and gradually (with a pre-submission commit squash) Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '26

25 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #739 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204147&action=e… Bug 10190: (QA follow-up) UI/UX improvements and fixes - Refactor (prepation): Extract form sub-components for better maintainability - Template stucture improvements (eg. consistent fieldset use) - Ensure triggerNumber is always cast to integer from query params - Add/Edit trigger form UI/UX improvements/fixes: - Restore add/edit button functionality on trigger tables in the form - Update Context section title to dynamically change depending on whether editing or displaying - Display trigger context as informational when not in confirmContext mode - Hide required labels and validation on view-only context fields - Always display trigger context at the top of the form - Add renewal/autorenewal summary (renewals allowed, automatic renewal) to circulation rules summary panel - Sort notice letter dropdowns by name rather than code - Update Circulation rules summary title to be more descriptive - Scroll behaviour improvements: - Extract scrollToElementById to store with polling and null guard - Block page scroll when modal is open - Disambiguate duplicate trigger-table element ids (trigger-table-main vs trigger-table-form) to fix unpredictable scroll-to behaviour Assisted-by: Claude Sonnet 4.6 (Anthropic) Experimenting a little here - not quite certain where we draw the line for substantial use so I thought I would add a description in case it's useful, especially since the AI code guidelines are quite fresh: AI was used primarily to help parse longer Vue templates (CirculationTriggersFormAdd.vue) and help isolate elements for extractions as well as highlight template formatting inconsistencies and propose improvements. The refactoring itself was achieved starting from AI-proposed changes which were then thoroughly re-worked manually towards the code changes submitted. I also trialled using it (currently experimenting with this) for minor coding tasks where there is a clear precedent (for example, to add renewal/autorenewal information and do so in a way that follows exactly what we had written). In those cases, each code change made by AI was the outcome of multiple iterations with direct feedback (which it did require a fair amount of) from me to ensure the output matched what I would have written myself. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '26

25 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #738 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204146&action=e… Bug 10190: (follow-up): feat: indicate mtt is required -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '26

25 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #737 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204145&action=e… Bug 10190: (follow-up): fix: handle fallbacks in edit/add -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '26

25 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #736 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204144&action=e… Bug 10190: (follow-up): fix: reset rule info message The information message showing in the reset modal still referred to an earlier version of the UI. Update it to correctly name the relevant filter. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '26

25 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #735 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204143&action=e… Bug 10190: (follow-up): fix: mtt formating: handle unset This is needed to handle creating new triggers for libraries for which all earlier triggers are defaults (do not exist in the DB , are not explicitly set) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '26

25 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #734 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204142&action=e… Bug 10190: Add manage_circ_triggers permission for notice trigger access Replaces the broad manage_circ_rules permission requirement on the circulation triggers page with a new dedicated manage_circ_triggers sub-permission (under parameters, flag 3). - Add manage_circ_triggers to userpermissions.sql - Update atomicupdate to add the permission, grant it to existing edit_notice_status_triggers users, and remove the old permission - Update admin/circulation_triggers.pl to require manage_circ_triggers - Add manage_circ_triggers as an OR option on all circulation_rules API endpoints (GET/PUT /circulation_rules, /kinds, /config) - Restrict manage_circ_triggers users in the API controller to overdue_* rule names only on write Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0