- Koha-bugs - lists.koha-community.org

[Bug 27916] New: Fee paid message can crash SIP server if paying fee that is not "renewable"
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27916 Bug ID: 27916 Summary: Fee paid message can crash SIP server if paying fee that is not "renewable" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I'm not entirely sure how this is possible, but I've confirmed my fix works on two separate occasions. In the Koha::Account::pay, if a fine is "renewable" ( as determined by the method "renewable" the response to from the method "renew_item" is stored and returned by by pay(). Later in C4::SIP::Sip::MsgType::handle_fee_paid we assume that each element of the list in $pay_response->{renew_result} is a hashref that had an itemnumber. This is not true. We need to check for the itemnumber and then the item. If either do not exist, the SIP server will crash without responding. My suspicion is that this is caused by Koha::Account::Line::renewable returning true while the corrosponding call to renew_item contains a simple "return;" statement if RenewAccruingItemWhenPaid is not enabled ( or there is not related item or patron ). What happens here, at least for Bibliotheca self checks is that the machine will take payment, and send the fee paid to Koha via SIP. When Koha's SIP crashes and doesn't return a response, the self check machine will refund the money to the patron, *but* the payment still exists in Koha! Considering payments may be in the tens or even hundreds of dollars, this makes for a critical SIP bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 27916, which changed state. Bug 27916 Summary: Fee paid message can crash SIP server if paying fee that is not "renewable" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27916 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15262] Run Koha Run. Koha search should be fast again.
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28371 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 [Bug 28371] Improve performance of XSLTParse4Display -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15262] Run Koha Run. Koha search should be fast again.
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 [Bug 28373] Items fields not used in default XSLT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #58 from David Nind <david(a)davidnind.com> --- > Probably just my test plan missing the requirement of updating the schema > files! Can you please test again? I've done again after running dbic, but I still get the same error. Even if I don't change anything and just click save. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28341] New: Issue refund, 'Transaction type' should highlight the original 'Payment type' that was used for the transaction
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28341 Bug ID: 28341 Summary: Issue refund, 'Transaction type' should highlight the original 'Payment type' that was used for the transaction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org When issuing a refund, you can select what transaction type to record; However, it's currently very difficult to know what type of payment type was using in the original transaction and as such it's hard to choose the right type when you need to restrict refunds to be given in the same way the payment may have been taken. We should highlight the original payment type and select it by default in the resulting modal when issuing a refund. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 28342] New: Add rules for refunds
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28342 Bug ID: 28342 Summary: Add rules for refunds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org In some cases, refunds may be dissallowed, or when they are allowed, they may need to be actioned in a particular way (One payment type may only be refundable by certain transaction types.. or a particular debit type may only be partially refundable) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 28343] New: The credit payout modal would benefit from more details regarding where the credit came from.
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28343 Bug ID: 28343 Summary: The credit payout modal would benefit from more details regarding where the credit came from. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org When issuing a payout from a credit, it would be beneficial to be able to see the offset history in the modal so one may choose an appropriate payout transaction type. Example: * Patron borrows a DVD with charge X * Patron subsequently finds the DVD is scratched * Library issue a refund credit so the patron can use it against another DVD * Patron can't find another DVD they like and subsequently wants a Payout instead. * At this point, because the refund has taken place already, the librarian would need to delve into the details tab to know how the original payment for the DVD was received so they could issue a payout in the same form as the original payment (if their policy requires that). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 28305] New: Remove doc reference to XML::Simple in C4::Config
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28305 Bug ID: 28305 Summary: Remove doc reference to XML::Simple in C4::Config Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Developer documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org C4::Config doesn't need a doc reference to XML::Simple, especially not since Bug 28278 was pushed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10