- Koha-bugs - lists.koha-community.org

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121025|0 |1 is obsolete| | --- Comment #57 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 121076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121076&action=e… Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Update the database, update the schema files, restart services * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 18 May '21

18 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #56 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to David Nind from comment #55) > Thanks Aleisha. > > I'm getting an error when clicking save after making a change to a record: > > No property history for Koha::Biblio::Metadata at > /usr/share/perl5/Exception/Class/Base.pm line 88 > > in Exception::Class::Base::throw at > /usr/share/perl5/Exception/Class/Base.pm line 88 > > 85: > 86: $proto->rethrow if ref $proto; > 87: > 88: die $proto->new(@_); > 89: } > 90: > 91: sub rethrow { > > Show function arguments > in Koha::Object::set at /kohadevbox/koha/Koha/Object.pm line 270 > > 267: my @columns = @{$self->_columns()}; > 268: > 269: foreach my $p ( keys %$properties ) { > 270: unless ( grep { $_ eq $p } @columns ) { > 271: Koha::Exceptions::Object::PropertyNotFound->throw( > "No property $p for " . ref($self) ); > 272: } > 273: } > > Show function arguments > in Koha::Object::update at /kohadevbox/koha/Koha/Object.pm line 217 > > 214: sub update { > 215: my ($self, $values) = @_; > 216: Koha::Exceptions::Object::NotInStorage->throw unless > $self->in_storage; > 217: $self->set($values)->store(); > 218: } > 219: > 220: =head3 $object->delete(); > > Show function arguments > > .... Probably just my test plan missing the requirement of updating the schema files! Can you please test again? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12362] Branch transfer records orphaned on cancelled holds
by bugzilla-daemon＠bugs.koha-community.org 17 May '21

17 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon
by bugzilla-daemon＠bugs.koha-community.org 17 May '21

17 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28364 [Bug 28364] koha-z3950-responder breaks because of log4perl.conf permissions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19873] New: Make it possible to search on value 0
by bugzilla-daemon＠bugs.koha-community.org 17 May '21

17 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 Bug ID: 19873 Summary: Make it possible to search on value 0 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: gaetan.boisson(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org The current code considers a value of 0 in a search query as an empty string, that is, it won't search on it. If a library wants to search for records that specifically have the value "0" in a given field, it will not be possible. This patch aims to correct this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 May '21

17 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121027|0 |1 is obsolete| | --- Comment #47 from David Nind <david(a)davidnind.com> --- Created attachment 121038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121038&action=e… Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 May '21

17 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121026|0 |1 is obsolete| | --- Comment #46 from David Nind <david(a)davidnind.com> --- Created attachment 121037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121037&action=e… Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 May '21

17 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 17 May '21

17 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #55 from David Nind <david(a)davidnind.com> --- Thanks Aleisha. I'm getting an error when clicking save after making a change to a record: No property history for Koha::Biblio::Metadata at /usr/share/perl5/Exception/Class/Base.pm line 88 in Exception::Class::Base::throw at /usr/share/perl5/Exception/Class/Base.pm line 88 85: 86: $proto->rethrow if ref $proto; 87: 88: die $proto->new(@_); 89: } 90: 91: sub rethrow { Show function arguments in Koha::Object::set at /kohadevbox/koha/Koha/Object.pm line 270 267: my @columns = @{$self->_columns()}; 268: 269: foreach my $p ( keys %$properties ) { 270: unless ( grep { $_ eq $p } @columns ) { 271: Koha::Exceptions::Object::PropertyNotFound->throw( "No property $p for " . ref($self) ); 272: } 273: } Show function arguments in Koha::Object::update at /kohadevbox/koha/Koha/Object.pm line 217 214: sub update { 215: my ($self, $values) = @_; 216: Koha::Exceptions::Object::NotInStorage->throw unless $self->in_storage; 217: $self->set($values)->store(); 218: } 219: 220: =head3 $object->delete(); Show function arguments .... -- You are receiving this mail because: You are watching all bug changes.

1 0