- Koha-bugs - lists.koha-community.org

[Bug 27598] New: Add UPLOAD as a built-in system authorized value category
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27598 Bug ID: 27598 Summary: Add UPLOAD as a built-in system authorized value category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The upload tool directs users to create authorized values with the "UPLOAD" category. It would be helpful to add this as a default category with the "is_system" flag set to 1. My hope is that this is a first step towards adding some built-in authorized values which have the UPLOAD category such as one for Audio Alerts. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 5697] Automatic linking in guided reports
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #11 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Katrin Fischer from comment #6) > I think the feature is super nice, but there is a big issue for me as it > will currently only work on the English column names. I hadn't tested it with the new placeholder system, but after rebasing the patch and looking again my tests were successful, with one glitch: If there is a space inside the column name placeholder it won't work. So the SQL you tried: SELECT i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('<a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=', i.biblionumber, '&itemnumber=', i.itemnumber, '#edititem', '\">', i.itemnumber, '</a>' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected. I think this must be considered a bug in the placeholder parsing, since this query will fail to trigger the expected batch item modification menu: SELECT i.itemnumber AS ' itemnumber for batch' FROM items i -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5697] Automatic linking in guided reports
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110697|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 117096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117096&action=e… Bug 5697: Automatic linking in guided reports This patch modifies the output of reports so that if certain columns are returned the data in the colums automatically offer menus of actions: - borrowernumber: View, edit, check out - cardnumber: Check out - itemnumber: View, edit - biblionumber: View, edit Like the menu of batch operations, this functionality is available only if the column is returned with its original name (e.g. biblionumber, not "biblionumber AS `Biblio number`). To test, apply the patch and run a report which will return examples of each kind of data. I used: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() LIMIT 50 When the report runs you should see that the data in each affected column is displayed as a link, each of which should trigger the correct menu. Test each case to confirm that the correct page is opened. Test the "toggle data menus" control. Clicking it should hide and show the menus in the report results. Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5697] Automatic linking in guided reports
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 18146] New: C4:: Circulation CanBookBeRenewed lacks full test coverage.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18146 Bug ID: 18146 Summary: C4::Circulation CanBookBeRenewed lacks full test coverage. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com While testing bug 17941, I discovered two cases where test coverage was lacking from t/db_dependent/Circulation.t Around line 2725: if ( $restricted and $restrictionblockrenewing ) { return ( 0, 'restriction'); } elsif ( ($hasoverdues and $overduesblockrenewing eq 'block') || ($itemissue->{overdue} and $overduesblockrenewing eq 'blockitem') ) { return ( 0, 'overdue'); } The elseif is never triggered. Around line 2759: if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz() ) ) { return ( 0, "auto_too_soon" ) if $itemissue->{auto_renew}; return ( 0, "too_soon" ); } elsif ( $itemissue->{auto_renew} ) { return ( 0, "auto_renew" ); } There is no else, but the code never attempts something that would trigger one. To reproduce add: print STDERR "CHECK!\n"; just before the return ( 0, 'overdue') in the first case, and after the elsif's curly brace in the second case. running t/db_dependent/Circulation should not generate the CHECK points. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 12966] Edition statement missing from card view in Z39.50 result list (acq+cataloguing)
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12966 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | CC| |fridolin.somers(a)biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Trivial change, I choose to backport to stable. Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8326] Allow patron attributes to be made repeatable after initial creation
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Enhancement not pushed to 20.11.x Awesome enhancement :D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8287] Improve filter on checked out from overdues
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8287 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.03 released in| | CC| |fridolin.somers(a)biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27727] New: Add patron error
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27727 Bug ID: 27727 Summary: Add patron error Change sponsored?: --- Product: Koha Version: 20.11 Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs(a)lists.koha-community.org Reporter: nandan.singh(a)chitkara.edu.in QA Contact: testopia(a)bugs.koha-community.org Created attachment 117018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117018&action=e… Error display in add new petron Recently i have upgrade koha in new verion 20.11, I am getting error while add new petron. Errror log is [Fri Feb 19 12:01:58.280111 2021] [cgi:error] [pid 442415] [client x.x.x.x:42556] AH01215: [Fri Feb 19 12:01:58 2021] memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_library`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`)) [for Statement "INSERT INTO `borrowers` ( `B_address`, `B_address2`, `B_city`, `B_country`, `B_email`, `B_phone`, `B_state`, `B_streetnumber`, `B_zipcode`, `address`, `address2`, `altcontactaddress1`, `altcontactaddress2`, `altcontactaddress3`, `altcontactcountry`, `altcontactfirstname`, `altcontactphone`, `altcontactstate`, `altcontactsurname`, `altcontactzipcode`, `autorenew_checkouts`, `borrowernotes`, `borrowernumber`, `branchcode`, `cardnumber`, `categorycode`, `city`, `contactnote`, `country`, `date_renewed`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `email`, `emailpro`, `fax`, `firstname`, `initials`, `lastseen`, `mobile`, `opacnote`, `othernames`, `password`, `phone`, `phonepro`, `privacy`, `sex`, `sort1`, `sort2`, `state`, `streetnumber`, `surname`, `title`, `updated_on`, `userid`, `zipcode`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ?, ? )" with ParamValues: 0="", 1="", 2="", 3="", 4="", 5="", 6="", 7="", 8="", 9="", 10="", 11="", 12="", 13="", 14="", 15="", 16="", 17="", 18="", 19="", 20="1", 21="", 22=undef, 23="CL", 24="test00011", 25='S', 26="", 27="", 28="", 29=undef, 30='2021-02-19', 31='2029-05-19T00:00:00', 32='2003-02-19', 33=undef, 34="", 35="", 36="", 37="Test", 38="", 39=undef, 40="", 41="", 42="", 43='$2a$08$.VjCLVGfHyzq9lSqRFnwTOaq.OC4ArlxkAiDIgwdpkk9FQU.8QY.y', 44="", 45="", 46=1, 47="M", 48="", 49="", 50="", 51="", 52="test001", 53="Mr", 54="test0001", 55=""] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.: /usr/share/koha/intranet/cgi-bin/members/memberentry.pl, referer: http://10.0.1.1/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=S [Fri Feb 19 12:01:58.281846 2021] [cgi:error] [pid 442415] [client x.x.x.x:42556] AH01215: [Fri Feb 19 12:01:58 2021] memberentry.pl: DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a foreign key constraint fails (`koha_library`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`)) at /usr/share/koha/lib/Koha/Object.pm line 169: /usr/share/koha/intranet/cgi-bin/members/memberentry.pl, referer: http://10.0.1.1/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=S -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 27440] New: Improve structure and style of result toolbars in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Bug ID: 27440 Summary: Improve structure and style of result toolbars in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Several pages in the OPAC follow a similar pattern: Above the table of records (search results, lists, suggestions, etc) is a toolbar with various controls: Highlight, select all, place hold, etc. I think some improvements can be made to the markup and style of these areas of the template to make them work better and look more consistent. -- You are receiving this mail because: You are watching all bug changes.

1 20