- Koha-bugs - lists.koha-community.org

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #64 from Agustín Moyano <agustinmoyano(a)theke.io> --- (In reply to Andrew Fuerste-Henry from comment #56) > Additional issue: > 1 - on parcel.pl, check the checkboxes for one or more titles > 2 - click the individual Receive link for one of the expected titles > 3 - that takes you to orderreceive.pl for that individual title > 4 - click Cancel > 5 - when you get back to parcel.pl, the checkboxes you checked previously > are still marked, but the Receive Selected button indicates you have zero > titles selected. You must un-check and re-check the titles to get them to > register. > > We should un-check those boxes if we leave and then return to the page. Again, could not reproduce this error.. could you please copy/paste any errors that appear in browsers console? Thanks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #63 from Agustín Moyano <agustinmoyano(a)theke.io> --- (In reply to Andrew Fuerste-Henry from comment #57) > A couple of typos. To recreate: > 1 - select two or more orders to receive > 2 - in the multi-receiving modal, update all but one of your orders to have > received items > 3 - save your changes in the modal > 4 - back on the multi-receiving page, get these messages ("X" is the order > number): > Order X: No quantity to receive setted. No items will be created. > Order X: An error cocurred while saving > > Those should be: > Order 7: No quantity to receive set. No items will be created. > Order 7: An error occurred while saving. Typos fixed! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #62 from Agustín Moyano <agustinmoyano(a)theke.io> --- (In reply to Andrew Fuerste-Henry from comment #55) > To recreate the issue where receiving hangs on processing when missing a > replacement price: > 1: have a fresh Koha Testing Docker > 2: apply patch, updatedatabase, restart_all > 3: have a basket set to create item records on ordering > 4: populate basket from a marc file, only setting price and fund for the > items > 5: close basket > 6: click to Receive, create invoice > 7: on parcel.pl, "Processing" alert never resolves > The console shows: > parcel.pl?invoiceid=1:810 Uncaught TypeError: Cannot read property > 'format_price' of null > at render (parcel.pl?invoiceid=1:810) > at datatables.min_20.1200012.js:57 > at Object.b.fnGetData (datatables.min_20.1200012.js:51) > at B (datatables.min_20.1200012.js:56) > at Ha (datatables.min_20.1200012.js:64) > at P (datatables.min_20.1200012.js:68) > at vb (datatables.min_20.1200012.js:79) > at datatables.min_20.1200012.js:76 > at i (datatables.min_20.1200012.js:74) > at Object.success (datatables.min_20.1200012.js:75) > > And that error points toward: > "data": "replacement_price", > "render": function(data, type, row, meta) { > return (row.replacement_price).format_price(); > }, > }, > > In the database, I see that aqorders.replacementprice is null for all of the > orders I made. If I do an update to set aqorders.replacementprice=0, then > the receiving page populates as expected. Well, that was thorough! Thanks so much. This issue is not related to this bug, but to 20212 where the code was introduced. I created bug 27719 to fix this issue. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22713 | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22713] New: Replacement price removed when receiving if using MarcItemFieldstoOrder
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Bug ID: 22713 Summary: Replacement price removed when receiving if using MarcItemFieldstoOrder Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: nick(a)bywatersolutions.com Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 88048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88048&action=ed… replacement price in item record acq process In 18.11 the wording and functionality changed in Acquisitions with the field Replacement price. This allowed libraries to have their replacement price set in the Acquisitions order and also in the item record. However, if a library is using MarcItemFieldstoOrder system preference and setting their replacement price in the marc record upon Importing. The replacement price only stays on the Item Record and will not be included into the Acquisitions order and it won't populate into the receiving process- and therefore making it $0. It would be nice if the item record had the replacement price from the MarcItemFieldstoOrder, and this would follow it through the process and since it is there in the item, it be used in the Order. Process currently: 1. Set marcitemfieldstorder to have a $v replacement price (975$v) 2. Create a basket 3. Upload a marc file that has a replacement price in the record 4. Add this file to your basket. 5. The item record will display the replacement price. 6. The basket.pl will not display the replacement price of this item 7. CLose the basket 8. When receiving the item in Acquisitions, the replacement price is zeroed out 9. The item will not have a replacement price once it is received. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27719 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22713 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116681|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #61 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 116945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116945&action=e… Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t Sponsored-by: Virginia Polytechnic Institute and State University -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116683|0 |1 is obsolete| | --- Comment #60 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 116944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116944&action=e… Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference configuration This patch adds AcqReceiveMultipleOrderLines to koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Sponsored-by: Virginia Polytechnic Institute and State University -- You are receiving this mail because: You are watching all bug changes.

1 0