- Koha-bugs - lists.koha-community.org

[Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114193|0 |1 is obsolete| | Attachment #114194|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 114208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114208&action=e… Bug 15448: Filter out items hidden in OPAC on placing hold This patch leverages on bug 24254's Koha::Items->filter_by_visible_in_opac to filter out items that shouldn't be presented to the end user in the OPAC interface. To test: 1. Circulation and Fine rules for item-level holds are set to allow. 2. Setting the OpacHiddenItems preference to "ccode: [SUPPRESS]" 3. An item with collection Code Suppress is set. 4. Search for the title in the OPAC. => SUCCESS: The Suppress ccode item isn't shown. 5. View the detail page for the title. => SUCCESS: The suppress ccode item isn't shown. 6. Place a hold on the item: -- Click "Show more options" -- Select "A specific item" => FAIL: the ccode with the opachiddenitems rule has an item that appear in the list to place a hold 7. Apply this patch and repeat 6 => SUCCESS: The item doesn't show! 8. Sign off :-D Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #82 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 114205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114205&action=e… Bug 12430: Fix selenium/regressions.t failure Test failed with # Looks like you planned 4 tests but ran 3. t/db_dependent/selenium/regressions.t .. 2/5 # Failed test 'OPAC - Remove from cart' # at t/db_dependent/selenium/regressions.t line 109. Error while executing command: clickElement: An unknown server-side error occurred while processing the command.: Element is not clickable at point (583.7000122070312, 14). Other element would receive the click: <a class="page-link" href="/cgi-bin/koha/opac-search.pl?idx=kw&q=d&offset=420&sort_by=relevance_dsc&count=20" aria-label="Go to the last page"></a> https://pic.infini.fr//Qhq7pLBq/jT9wZ7F1 The remove from basket link for the biblio 3 is hidden by the floating toolbar. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | --- Comment #81 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Ho by the way, I pushed these patches to master! Pushed to master for 21.05.00 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #80 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Apparently the other failure is also coming from here. t/db_dependent/selenium/regressions.t # Looks like you planned 4 tests but ran 3. t/db_dependent/selenium/regressions.t .. 2/5 # Failed test 'OPAC - Remove from cart' # at t/db_dependent/selenium/regressions.t line 109. Error while executing command: clickElement: An unknown server-side error occurred while processing the command.: Element is not clickable at point (583.7000122070312, 14). Other element would receive the click: <a class="page-link" href="/cgi-bin/koha/opac-search.pl?idx=kw&q=d&offset=420&sort_by=relevance_dsc&count=20" aria-label="Go to the last page"></a> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #79 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- # Failed test 'buildQuery should keep 0 value' # at t/db_dependent/Search.t line 669. # got: 'su,phr=(rk=(0)) ' # expected: 'su,phr=0 ' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #78 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- t/db_dependent/Search.t is failing, can you have a look please? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15791] New: Don't delete a fund if existing orders are linked to it
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15791 Bug ID: 15791 Summary: Don't delete a fund if existing orders are linked to it Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/aqbudgets.pl?op=delete_confirm OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org When you go to delete a fund Koha displays this message in the confirmation dialog: "If you delete this fund, all orders linked to this fund will be deleted!" The error appears even if there are no orders linked to the fund. In order to be consistent we ought to warn the user only if existing orders will be deleted. Should it even be possible to delete a fund if there are orders linked to it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27154 --- Comment #72 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #71) > Nick, why did you copy/pasted get_yaml_pref_hash in Koha/Config/SysPref.pm > and Koha/Util/SystemPreferences.pm? > > Koha/Config/SysPref.pm:sub get_yaml_pref_hash { > Koha/Util/SystemPreferences.pm:sub get_yaml_pref_hash { Opened bug 27154. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 [Bug 27154] Koha/Util/SystemPreferences.pm must be removed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114138|0 |1 is obsolete| | --- Comment #77 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 114200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114200&action=e… Bug 12430: Add unit tests for C4::Search::buildQuery This patch adds unit tests for buildQuery, especially focusing on the use of the (rk=()) wrapper. Note that the Net::Z3950::ZOOM library is used to test the queries for CCL validity on top of the string matching used in the got/expected comparisons. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> JD amended patch: fix spelling connexion ==> connection -- You are receiving this mail because: You are watching all bug changes.

1 0