- Koha-bugs - lists.koha-community.org

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 04 Nov '20

04 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #38 from David Cook <dcook(a)prosentient.com.au> --- I like the idea that the Anonymous Patron cannot be deleted, but I think that this implementation is too narrowly cast. I think that we should consider doing Bug 26170 (Create "system" patrons that cannot be (easily) deleted via the web UI) instead of this one, since there are many scenarios where we don't want to be able to delete patron accounts that are important (e.g. SIP patron, REST API patron, etc.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23237] New: Plugin allow [% INCLUDE %] from template
by bugzilla-daemon＠bugs.koha-community.org 04 Nov '20

04 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Bug ID: 23237 Summary: Plugin allow [% INCLUDE %] from template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: frederic(a)tamil.fr QA Contact: testopia(a)bugs.koha-community.org >From a plugin template it is useful to be able to include other templates with [% INCLUDE %] directives. But TT module is used by Koha with absolute paths. Relative paths are forbidden for security reasons. A new param [% PLUGIN_DIR %] allow plugin templates to know where to find plugin home directory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 33

[Bug 26919] New: aenjeaye
by bugzilla-daemon＠bugs.koha-community.org 04 Nov '20

04 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26919 Bug ID: 26919 Summary: aenjeaye Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: alvianyulianto63(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 112966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112966&action=e… aenjeaye -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 26918] New: anjg
by bugzilla-daemon＠bugs.koha-community.org 04 Nov '20

04 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26918 Bug ID: 26918 Summary: anjg Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: alvianyulianto63(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 112965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112965&action=e… hai jambu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 04 Nov '20

04 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 [Bug 25548] Package install Apache performs unnecessary redirects -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 04 Nov '20

04 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111064|0 |1 is obsolete| | Attachment #111065|0 |1 is obsolete| | Attachment #112963|0 |1 is obsolete| | --- Comment #27 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 112964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112964&action=e… Bug 7607: [Alternate] Remove empty inputs when submitting search form This patch surrounds the operator, index, and query fields on the advanced search page wtih a 'search_set' class. This allows us to process them as a group and confirm the query is populated before submitting the other parts to the form TO test: 1 - Go to advanced search 2 - Use search boxes to search like: Title: (leave blank) Author: clinton keyword: shuffle 3 - Perform search 4 - Note no results as you searched for title:clinton etc. 5 - apply patch 6 - refresh and repeat 7 - search is now correct 8 - Try vaeious searches with 'more options' and selecting different operators Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Cook <dcook(a)prosentient.com.au> https://bugs.koha-community.org/show_bug.cgi?id=7606 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 04 Nov '20

04 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #26 from David Cook <dcook(a)prosentient.com.au> --- Ok this issue is really annoying me, so let's get it sorted... Test plan: 0. No patch 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1 2. Change 2nd "Keyword" and 3rd "Keyword" to "Author" 3. Change 2nd search box to "Martin" and 3rd search box to "Humble" 4. Change 2nd op box (between Martin and Humble) to "or" 5. Click "Search" 6. Note the following URL: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=kw&o… 7. Note the HTML response: No results match your search for 'kw,wrdl: Martin and au,wrdl: Humble'. Test plan: 0. Apply Nick's patch and "koha-plack --restart kohadev" 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1 2. Change 2nd "Keyword" and 3rd "Keyword" to "Author" 3. Change 2nd search box to "Martin" and 3rd search box to "Humble" 4. Change 2nd op box (between Martin and Humble) to "or" 5. Click "Search" 5b. If you have a quick eye, you'll see the empty search box was removed by Javascript. Yay! 6. Note the following URL: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=au&q… 7. Note the HTML response: 12 result(s) found for 'au,wrdl: Martin or au,wrdl: Humble'. Great patch, Nick! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 04 Nov '20

04 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112912|0 |1 is obsolete| | --- Comment #25 from David Nind <david(a)davidnind.com> --- Created attachment 112963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112963&action=e… Bug 7607: [Alternate] Remove empty inputs when submitting search form This patch surrounds the operator, index, and query fields on the advanced search page wtih a 'search_set' class. This allows us to process them as a group and confirm the query is populated before submitting the other parts to the form TO test: 1 - Go to advanced search 2 - Use search boxes to search like: Title: (leave blank) Author: clinton keyword: shuffle 3 - Perform search 4 - Note no results as you searched for title:clinton etc. 5 - apply patch 6 - refresh and repeat 7 - search is now correct 8 - Try vaeious searches with 'more options' and selecting different operators Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 04 Nov '20

04 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 04 Nov '20

04 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #24 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 112912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112912 Bug 7607: [Alternate] Remove empty inputs when submitting search form Review of attachment 112912: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=760…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ +140,5 @@ > + if( $(this).find('input[name="q"]').val() == "" ){ > + $(this).remove(); > + removedPrior = true; > + } > + }); I haven't tested the code but what about the idx? Wouldn't this code exacerbate the problem? -- You are receiving this mail because: You are watching all bug changes.

1 0