- Koha-bugs - lists.koha-community.org

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110146|0 |1 is obsolete| | --- Comment #92 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 110498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110498&action=e… Bug 14242: (follow-up) Move English strings out of JavaScript In order for English strings to be translatable they must be defined in the template, not in the JS file. Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110145|0 |1 is obsolete| | --- Comment #91 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 110497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110497&action=e… Bug 14242: (follow-up) Translateable js strings, $raw filter Sponsored-by: Region Halland Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110144|0 |1 is obsolete| | --- Comment #90 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 110496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110496&action=e… Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes To test, enter a valid ISBN complete with - eg 978-1-78416-110-1 The search should still work Signed-off-by: Marc <veron(a)veron.ch> Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110143|0 |1 is obsolete| | --- Comment #89 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 110495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110495&action=e… Bug 14242: (follow-up) Change the icon to words Fix a bug that meant it would search on empty ISBN To test 1. Fill in a valid ISBN (Book data is correctly loaded) 2. Clear the ISBN from the field (Book data is correctly removed) 3. Tab away from the empty ISBN field: Data is loaded for a title "ISBN 0-9690745-2-2" 4. Apply patch 5. Repeat 1,2 and 3 notice a search is no longer done Signed-off-by: Marc <veron(a)veron.ch> Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110142|0 |1 is obsolete| | --- Comment #88 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 110494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110494&action=e… Bug 14242: (follow up) renaming syspref OPACAutoFill -> OPACSuggestionAutoFill Signed-off-by: Marc <veron(a)veron.ch> Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110141|0 |1 is obsolete| | --- Comment #87 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 110493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110493&action=e… Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACAutoFill" 3. Log into OPAC and go to purchase suggetions page 4. Write a valid ISBN into the ISBN field and press the edit icon next to the field, or unfocus the field. 5. Title, Author, Publisher and Item Type fields should now be filled automaticly. 6. Press "undo" to undo - should restore all changed fields to original values Tested all patches together, works as expected. Signed-off-by: Marc <veron(a)veron.ch> Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110444|0 |1 is obsolete| | --- Comment #48 from David Nind <david(a)davidnind.com> --- Created attachment 110491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110491&action=e… Bug 14367: (follow-up) Rebasing to make patch work on master Run through test plan and confirm everything still works as expected. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110443|0 |1 is obsolete| | --- Comment #47 from David Nind <david(a)davidnind.com> --- Created attachment 110490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110490&action=e… Bug 14367: (follow-up) Fixing merge conflicts... ...and other fixes to make patch work. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110442|0 |1 is obsolete| | --- Comment #46 from David Nind <david(a)davidnind.com> --- Created attachment 110489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110489&action=e… Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Run updatedatabase.pl * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0